Merge lp:~vorlon/ubuntu/quantal/python-pam/python3 into lp:ubuntu/quantal/python-pam
Proposed by
Steve Langasek
Status: | Needs review |
---|---|
Proposed branch: | lp:~vorlon/ubuntu/quantal/python-pam/python3 |
Merge into: | lp:ubuntu/quantal/python-pam |
Diff against target: |
333 lines (+107/-78) 11 files modified
PAMmodule.c (+24/-12) debian/changelog (+14/-0) debian/compat (+1/-0) debian/control (+28/-4) debian/python-pam-dbg.install (+1/-0) debian/python-pam.examples (+1/-0) debian/python-pam.install (+2/-0) debian/python3-pam-dbg.install (+1/-0) debian/python3-pam.examples (+1/-0) debian/python3-pam.install (+2/-0) debian/rules (+32/-62) |
To merge this branch: | bzr merge lp:~vorlon/ubuntu/quantal/python-pam/python3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw (community) | Approve | ||
Review via email: mp+107314@code.launchpad.net |
Description of the change
python-pam is not maintained upstream or in Debian, so I guess it's up to
us to fix this one.
To post a comment you must log in.
Unmerged revisions
- 20. By Steve Langasek
-
Modernize packaging to dh and debhelper 9.
- 19. By Steve Langasek
-
use PyModule_Create instead of Py_InitModule for python3
- 18. By Steve Langasek
-
use PyLong_FromLong when building for python3.
- 17. By Steve Langasek
-
use PyUnicode_
FromString, not PyString_FromString - 16. By Steve Langasek
-
* Port to python3; dead project upstream so not forwarding anywhere.
- replace 'staticforward' with 'static'.
- replace ob_type with Py_TYPE(ob).
- drop tp_getattr function, we just need to set tp_methods instead.
- fix PyTypeObject definition.
Steve, this looks good. My only minor thought is the API change in the repr() to always be unicode. I.e. this is a change for the Python 2 version, but since it's just a repr it doesn't bother me. I like Saphhira's additional patch, though with a few changes.
I'll mark this approved, merge yours and Sapphira's into trunk and upload.
Thanks both of you for the patch!