Code review comment for lp:~vishalbhoj/linaro-android-build-tools/license-check
Revision history for this message
| Georgy Redkozubov (gesha) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
For the initial attempt looks good. Some items I would like to address in the future.
1) It's better to have separate MPs for issues not connected with each other. I mean adding LAVA_ADB_CHECK, mapping arndale and checking license are 3 separate issues. At least license check should be in one MP and all other small fixes better to go in another.
2) You have hardcoded groups which is not good in case we decide to add new ones. It might be better to read all requested groups from pinned-manifest.xml and then check against allowed groups from BUILD-INFO.txt.