Merge lp:~vishalbhoj/linaro-android-build-tools/license-check into lp:linaro-android-build-tools

[vishal]

[Georgy Redkozubov (gesha)]

For the initial attempt looks good. Some items I would like to address in the future.
1) It's better to have separate MPs for issues not connected with each other. I mean adding LAVA_ADB_CHECK, mapping arndale and checking license are 3 separate issues. At least license check should be in one MP and all other small fixes better to go in another.
2) You have hardcoded groups which is not good in case we decide to add new ones. It might be better to read all requested groups from pinned-manifest.xml and then check against allowed groups from BUILD-INFO.txt.

[Georgy Redkozubov (gesha)]

Thanks for splitting into separate MPs.
Let's try to address item 2) from last comment, i.e. get rid of hardcoded groups.

[vishal (vishalbhoj)]

item 2 is also addressed. The groups are not hardcoded.

[Georgy Redkozubov (gesha)]

Now it looks good. Hope you've tested it on real manifest and build-info.txt

review: Approve

[lp:~vishalbhoj/linaro-android-build-tools/license-check]

677. By Georgy Redkozubov on 2013-10-04

[merge] Update repo tool to the latest

678. By Georgy Redkozubov on 2013-10-04

[merge] map arndale with lamc device

679. By vishal on 2013-10-05

add license check support

=== modified file 'build-scripts/build-android'
--- build-scripts/build-android	2013-08-05 10:26:56 +0000
+++ build-scripts/build-android	2013-10-05 08:03:13 +0000
@@ -161,4 +161,8 @@
     (cd out/; ${BUILD_SCRIPT_ROOT}/create-user-kernel-script)
 fi
 
+if [ ! -n "$SKIP_LICENSE_CHECK" ]; then
+    ${BUILD_SCRIPT_ROOT}/license-verification.sh out/pinned-manifest.xml  out/target/product/$TARGET_PRODUCT/BUILD-INFO.txt
+fi
+
 ${BUILD_SCRIPT_ROOT}/../utils/manifest-descriptions/make.sh out/source-manifest.xml out/pinned-manifest.xml

=== added file 'build-scripts/license-verification.sh'
--- build-scripts/license-verification.sh	1970-01-01 00:00:00 +0000
+++ build-scripts/license-verification.sh	2013-10-05 08:03:13 +0000
@@ -0,0 +1,15 @@
+#! /bin/bash
+
+groups=`grep -rni "ssh:" $1 | sed 's/^.*name="//; s/".*$//'`
+
+for group in $groups
+do
+    if grep -rni "remote=" $1 | grep -Fq $group; then
+        if grep -Fq $group $2; then
+            continue
+	else
+            echo "ERROR: License mismatch between source and artifacts"
+            exit 1
+	fi
+fi
+done