Code review comment for lp:~villemvainio/ipython/ip0-unittests-1

Revision history for this message
Ville M. Vainio (villemvainio) wrote :

On Sun, Nov 30, 2008 at 6:09 AM, Brian Granger <email address hidden> wrote:

> The latest change now solves this problem and all tests pass. However, I am still getting the noise on stdout (see my previous comment). We definitely need to track this down and get rid of it.
> --

I didn't think it matters - the test case does output to stdout by
design, since it tests interactive stuff (autocall conversion). I
don't think it makes sense to redirect stdout here, since nose already
does it.

Obviously, it can be done, especially since it's the only test that
does it so far - but yet it's also among the first tests that
excercises interactive stuff, and I don't think we should set a
precedent about not allowing stdout for tests.

--
Ville M. Vainio
http://tinyurl.com/vainio

« Back to merge proposal