Code review comment for lp:~villemvainio/ipython/ip0-unittests-1

Revision history for this message
Brian Granger (ellisonbg) wrote :

Overall these changes look fine. It is great for us to begin moving these tests into IPython/tests where they will be run regularly by nose.

However, when I run iptest with this branch, I get a failure and some noise to stdout. This stuff should be cleaned up before we merge. Once these things are fixed, this can be merged.

brian-grangers-macbook:~ bgranger$ iptest
..........S.....................................................................................................................................................................................................................................................................................................................................................................................................................S....S>f2("a b c")
>f1("a", "b", "c")
>f1(1,2,3)
>f2(4)
.------------------------------------------------------------
Traceback (most recent call last):
  File "<ipython console>", line 1, in <module>
  File "<ipython console>", line 9, in test
AssertionError

F........... os.path.isdir(path)
.....
======================================================================
FAIL: %cd magic, %bookmark
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/bgranger/Library/Python/2.5/site-packages/nose-0.10.3-py2.5.egg/nose/case.py", line 182, in runTest
    self.test(*self.arg)
  File "/Users/bgranger/Documents/Computation/IPython/branches/ip0-unittests-1/IPython/tests/test_cd.py", line 35, in test_cd
    assert _ip.user_ns['success'] == 1
AssertionError:
>> assert _ip.user_ns['success'] == 1

-------------------- >> begin captured stdout << ---------------------
/
/private/tmp

--------------------- >> end captured stdout << ----------------------

----------------------------------------------------------------------
Ran 440 tests in 58.122s

FAILED (SKIP=3, failures=1)

review: Needs Fixing

« Back to merge proposal