Merge lp:~vila/ubuntu-ci-services-itself/doc-fixes into lp:ubuntu-ci-services-itself

Proposed by Vincent Ladeuil
Status: Merged
Approved by: Chris Johnston
Approved revision: 259
Merged at revision: 256
Proposed branch: lp:~vila/ubuntu-ci-services-itself/doc-fixes
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 66 lines (+14/-6)
3 files modified
cli/README (+5/-4)
test_runner/tstrun/testbed.py (+6/-1)
tests/run.py (+3/-1)
To merge this branch: bzr merge lp:~vila/ubuntu-ci-services-itself/doc-fixes
Reviewer Review Type Date Requested Status
Chris Johnston (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+207483@code.launchpad.net

Commit message

Minor doc fixes.

Description of the change

Here are a few uncommited changes I was accrying on my trunk from some minor
issues I encountered and are not worth fixing yet. I still prefer to have
these recorded in shared place in case others ran into similar issues.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:257
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/196/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/196/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) wrote :

On Thu, Feb 20, 2014 at 11:14 AM, Vincent Ladeuil <email address hidden>wrote:

> -To use this app, you will need to create the files
> -~/.ubuntu-ci/auth_config.yaml and ~/.ubuntu-ci/config.yaml.
> +To use this app, you will need to create the files ~/.ubuntu-ci
> +(./cli/ubuntu-ci-autoconfig can help). It needs to include:
>

s/files/file please as it is now only one file. Good catch on the update

258. By Vincent Ladeuil

Thanks for catch Andy !

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:258
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/197/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/197/rebuild

review: Needs Fixing (continuous-integration)
259. By Vincent Ladeuil

Tsk, tsk, typo. Thanks Chris ;)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:259
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/198/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/198/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cli/README'
--- cli/README 2014-01-10 15:35:32 +0000
+++ cli/README 2014-02-20 17:08:27 +0000
@@ -1,11 +1,12 @@
1To use this app, you will need to create the files 1To use this app, you will need to create the file ~/.ubuntu-ci
2~/.ubuntu-ci/auth_config.yaml and ~/.ubuntu-ci/config.yaml. 2(./cli/ubuntu-ci-autoconfig can help). It needs to include:
33
4auth_config.yaml needs to include:4from your cloud credentials:
5- 'auth_url'5- 'auth_url'
6- 'auth_user'6- 'auth_user'
7- 'auth_password'7- 'auth_password'
8- 'auth_tenant_name'8- 'auth_tenant_name'
9- 'auth_region_name'
910
10config.yaml needs to include:11from your juju deployment:
11- 'ci_url'12- 'ci_url'
1213
=== modified file 'test_runner/tstrun/testbed.py'
--- test_runner/tstrun/testbed.py 2014-02-17 17:54:55 +0000
+++ test_runner/tstrun/testbed.py 2014-02-20 17:08:27 +0000
@@ -209,6 +209,11 @@
209 # but there should be only one IP address defined so we just209 # but there should be only one IP address defined so we just
210 # get the first one and avoid the need for a config option for210 # get the first one and avoid the need for a config option for
211 # the network name.211 # the network name.
212
213 # FIXME: ev encountered a case where the instance is in an
214 # error state and has no networks leading to a KeyError
215 # exception. It should be handled in its own branch based on
216 # 'status == "ERROR"'. -- vila 2014-02-18
212 self.ip = networks[0][0]217 self.ip = networks[0][0]
213 log.info('Got IP {} for {}'.format(self.ip, self.instance.id))218 log.info('Got IP {} for {}'.format(self.ip, self.instance.id))
214 # FIXME: Right place to report how long it took to spin up the219 # FIXME: Right place to report how long it took to spin up the
@@ -298,7 +303,7 @@
298 # precise_image = ('ubuntu-released/ubuntu-precise-12.04'303 # precise_image = ('ubuntu-released/ubuntu-precise-12.04'
299 # '-amd64-server-20131205-disk1.img')304 # '-amd64-server-20131205-disk1.img')
300 saucy_image = ('ubuntu-released/ubuntu-saucy-13.10'305 saucy_image = ('ubuntu-released/ubuntu-saucy-13.10'
301 '-amd64-server-20140129-disk1.img')306 '-amd64-server-20140212-disk1.img')
302 test_bed = TestBed('vila1', 'm1.small', saucy_image,307 test_bed = TestBed('vila1', 'm1.small', saucy_image,
303 lambda x: None)308 lambda x: None)
304 test_bed.setup()309 test_bed.setup()
305310
=== modified file 'tests/run.py'
--- tests/run.py 2014-02-17 10:13:29 +0000
+++ tests/run.py 2014-02-20 17:08:27 +0000
@@ -94,7 +94,7 @@
9494
9595
96def destroy_services():96def destroy_services():
97 """This is a quick way of desroying the services without having to97 """This is a quick way of destroying the services without having to
98 re-bootstrap for the next test. We would just use juju-deployer -T here,98 re-bootstrap for the next test. We would just use juju-deployer -T here,
99 but https://bugs.launchpad.net/juju-deployer/+bug/1269783 prevents that for99 but https://bugs.launchpad.net/juju-deployer/+bug/1269783 prevents that for
100 now."""100 now."""
@@ -389,6 +389,8 @@
389 try:389 try:
390 subprocess.check_output(args)390 subprocess.check_output(args)
391 except subprocess.CalledProcessError as e:391 except subprocess.CalledProcessError as e:
392 # FIXME: if check_output raise an exception, we don't get a proper
393 # output to check for the text below -- vila 2014-02-07
392 if 'environment is already bootstrapped' not in e.output:394 if 'environment is already bootstrapped' not in e.output:
393 raise395 raise
394396

Subscribers

People subscribed via source and target branches