Merge lp:~vila/bzr/799212-non-ascii-confs into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Jelmer Vernooij | ||||||||||||||||
Approved revision: | no longer in the source branch. | ||||||||||||||||
Merged at revision: | 5989 | ||||||||||||||||
Proposed branch: | lp:~vila/bzr/799212-non-ascii-confs | ||||||||||||||||
Merge into: | lp:bzr | ||||||||||||||||
Diff against target: |
261 lines (+131/-16) 4 files modified
bzrlib/config.py (+21/-11) bzrlib/errors.py (+9/-0) bzrlib/tests/test_config.py (+97/-5) doc/en/release-notes/bzr-2.4.txt (+4/-0) |
||||||||||||||||
To merge this branch: | bzr merge lp:~vila/bzr/799212-non-ascii-confs | ||||||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+65199@code.launchpad.net |
Commit message
Clearer exceptions for bad-content config files
Description of the change
This complements the previous submission by making sure all
config files errors related to a non-utf8 or not parseable
content properly mention the appropriate path/url.
The least obvious part is that TransportConfig() objects have
been involved in some bugs and since it uses ConfigObj directly,
it escaped the exception cathcing that was happening in
IniBasedConfig.
To post a comment you must log in.
sent to pqm by email