Code review comment for lp:~vila/bzr/799212-non-ascii-confs

Revision history for this message
Martin Packman (gz) wrote :

This set of changes is what I had in mind.

As I understand it, bug 502060 is about TransportConfig lacking
try/except, then bug 688677 and bug 797246 are the same non-utf8 issue
in copied code. However I don't understand where bug 799212 comes in
or even what it is really from the report.

One change I'd suggest is making ConfigContentError take the
UnicodeError instance as a second param so the UI has the option of
giving more details like where in the file to look for the bad bytes.

« Back to merge proposal