Code review comment for lp:~vijit.chauhan/beeseek/fix-603119

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

Hi and thanks for you contribution, it is really appreciated. The code is more or less OK, however there is one thing that doesn't behave correctly, but probably because there were some misunderstandings.

You check the return value of BfSender_SendRaw() into BfSender_Connect(). Since BfSender_SendRaw is used also elsewhere, I think that it would be better to check the return value of send() into BfSender_SendRaw() itself, and call _Connect() in case of errors.

Feel free to ask questions if you have doubts or questions, I'm here to help. Also, a tip: run bzr whoami ;-)

Thanks again for your efforts!

« Back to merge proposal