Merge lp:~vijit.chauhan/beeseek/fix-603119 into lp:beeseek
Proposed by
vSC
Status: | Merged |
---|---|
Merged at revision: | 64 |
Proposed branch: | lp:~vijit.chauhan/beeseek/fix-603119 |
Merge into: | lp:beeseek |
Diff against target: |
103 lines (+35/-6) (has conflicts) 1 file modified
trackers/sniffer/src/sender.c (+35/-6) Text conflict in trackers/sniffer/src/sender.c |
To merge this branch: | bzr merge lp:~vijit.chauhan/beeseek/fix-603119 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Corbellini | Approve | ||
Review via email: mp+30024@code.launchpad.net |
To post a comment you must log in.
Hi and thanks for you contribution, it is really appreciated. The code is more or less OK, however there is one thing that doesn't behave correctly, but probably because there were some misunderstandings.
You check the return value of BfSender_SendRaw() into BfSender_Connect(). Since BfSender_SendRaw is used also elsewhere, I think that it would be better to check the return value of send() into BfSender_SendRaw() itself, and call _Connect() in case of errors.
Feel free to ask questions if you have doubts or questions, I'm here to help. Also, a tip: run bzr whoami ;-)
Thanks again for your efforts!