Code review comment for lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4

Revision history for this message
Robert Steckroth (robertsteckroth) wrote :

Also, I plan on jumping back into this project sooner than later, but I
have a proprietary project which is in it's prime right now.

On Mon, Nov 4, 2013 at 12:55 PM, Robert Steckroth <<email address hidden>
> wrote:

> Well, google should be in the top ten of the auto-complete list when a g
> is typed into the search box. Occasionally this will not happen correctly.
> Adding a o to the string will help --> press "go" to find google.
> Maybe a 15 second timeout would help thisl, or perhaps a sleep statement
> can knock this out. I thought that the sleep command was a little sloppy,
> but...
>
>
> On Mon, Nov 4, 2013 at 10:22 AM, Chris Gagnon <email address hidden>wrote:
>
>> What happens if the target_row doesn't find an object? we should have an
>> error message here so it's easy to diagnose the target_row is not found,
>> and not the remove_button is not found.
>>
>>
>> 43 + try:
>> 44 + o.select_single(
>> 45 + 'QQuickText',
>> 46 + objectName='companyNameText',
>> 47 + text="Google Inc."
>> 48 + )
>> 49 + target_row = o
>> 50 + break
>> 51 + except StateNotFoundError:
>> 52 + pass
>> 53 +
>> 54 + remove_button = target_row.select_single(
>> --
>>
>> https://code.launchpad.net/~veebers/stock-ticker-mobile-app/porting-autopilot-1.4/+merge/193718
>> You are reviewing the proposed merge of
>> lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4 into
>> lp:stock-ticker-mobile-app.
>>
>
>
>
> --
> <surgemcgee> Systems/Software Engineer
>
>
>
>

--
<surgemcgee> Systems/Software Engineer

« Back to merge proposal