Merge lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4 into lp:stock-ticker-mobile-app

[Christopher Lee]

Updating tests so that they pass using autopilot 1.4.

[Robert Steckroth (robertsteckroth)]

It works good. Two tests failed but..

[Robert Steckroth (robertsteckroth)]

A god start to next verison

review: Approve

[Robert Steckroth (robertsteckroth)]

A good start to next verison

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~veebers/stock-ticker-mobile-app/porting-autopilot-1.4/+merge/193718/+edit-commit-message

review: Needs Fixing (continuous-integration)

[Chris Gagnon (chris.gagnon)]

I can't get the tests or the application to work at all, I see this in the logs when I try to open the app with qmlscene

[com.ubuntu.stock-ticker-mobile] Error loading http://www.surgemcgee.com:8080/?s=&a=7&b=27&c=2013&d=10&e=4&f=2013 : Socket operation timed out
[com.ubuntu.stock-ticker-mobile] Error loading http://www.surgemcgee.com:8080/?f=sabl1vpghojkc8dre7j1n&s=http://www.surgemcgee.com:8080/?f=sabl1vpghojkc8dre7j1n&s=+yhoo : Socket operation timed out

[Chris Gagnon (chris.gagnon)]

The network calls should be mocked so the test can be run without the internet if possible.

[Chris Gagnon (chris.gagnon)]

What happens if the target_row doesn't find an object? we should have an error message here so it's easy to diagnose the target_row is not found, and not the remove_button is not found.

43 + try:
44 + o.select_single(
45 + 'QQuickText',
46 + objectName='companyNameText',
47 + text="Google Inc."
48 + )
49 + target_row = o
50 + break
51 + except StateNotFoundError:
52 + pass
53 +
54 + remove_button = target_row.select_single(

[Robert Steckroth (robertsteckroth)]

Well, google should be in the top ten of the auto-complete list when a g is
typed into the search box. Occasionally this will not happen correctly.
Adding a o to the string will help --> press "go" to find google.
Maybe a 15 second timeout would help thisl, or perhaps a sleep statement
can knock this out. I thought that the sleep command was a little sloppy,
but...

On Mon, Nov 4, 2013 at 10:22 AM, Chris Gagnon <email address hidden>wrote:

> What happens if the target_row doesn't find an object? we should have an
> error message here so it's easy to diagnose the target_row is not found,
> and not the remove_button is not found.
>
>
> 43 + try:
> 44 + o.select_single(
> 45 + 'QQuickText',
> 46 + objectName='companyNameText',
> 47 + text="Google Inc."
> 48 + )
> 49 + target_row = o
> 50 + break
> 51 + except StateNotFoundError:
> 52 + pass
> 53 +
> 54 + remove_button = target_row.select_single(
> --
>
> https://code.launchpad.net/~veebers/stock-ticker-mobile-app/porting-autopilot-1.4/+merge/193718
> You are reviewing the proposed merge of
> lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4 into
> lp:stock-ticker-mobile-app.
>

--
<surgemcgee> Systems/Software Engineer

[Robert Steckroth (robertsteckroth)]

Also, I plan on jumping back into this project sooner than later, but I
have a proprietary project which is in it's prime right now.

On Mon, Nov 4, 2013 at 12:55 PM, Robert Steckroth <<email address hidden>
> wrote:

> Well, google should be in the top ten of the auto-complete list when a g
> is typed into the search box. Occasionally this will not happen correctly.
> Adding a o to the string will help --> press "go" to find google.
> Maybe a 15 second timeout would help thisl, or perhaps a sleep statement
> can knock this out. I thought that the sleep command was a little sloppy,
> but...
>
>
> On Mon, Nov 4, 2013 at 10:22 AM, Chris Gagnon <email address hidden>wrote:
>
>> What happens if the target_row doesn't find an object? we should have an
>> error message here so it's easy to diagnose the target_row is not found,
>> and not the remove_button is not found.
>>
>>
>> 43 + try:
>> 44 + o.select_single(
>> 45 + 'QQuickText',
>> 46 + objectName='companyNameText',
>> 47 + text="Google Inc."
>> 48 + )
>> 49 + target_row = o
>> 50 + break
>> 51 + except StateNotFoundError:
>> 52 + pass
>> 53 +
>> 54 + remove_button = target_row.select_single(
>> --
>>
>> https://code.launchpad.net/~veebers/stock-ticker-mobile-app/porting-autopilot-1.4/+merge/193718
>> You are reviewing the proposed merge of
>> lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4 into
>> lp:stock-ticker-mobile-app.
>>
>
>
>
> --
> <surgemcgee> Systems/Software Engineer
>
>
>
>

--
<surgemcgee> Systems/Software Engineer

[lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4]

73. By Christopher Lee on 2013-11-08

Fix typo

[Christopher Lee (veebers)]

Hi Robert, I getting a test failure (stock_ticker.tests.test_Subtabs.TestSubtabs.test_chart_subtab) that I'm not sure how to solve. I'm wondering if you could lend me your knowledge and help me out?

The error message:
tests/autopilot/stock_ticker/tests/test_Subtabs.py", line 90, in test_chart_subtab
    self.assertThat(chart_dot.x, NotEquals(dot_x))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 417, in assertThat
    raise MismatchError(matchee, matcher, mismatch, verbose)
MismatchError: 300.0 == 300.0

I'm not certain what it (or the chart) is supposed to do in this situation so I can't offer a fix in the test or in the application itself either.

Also note that I've started a WIP MR for mocking-out the server: https://code.launchpad.net/~veebers/stock-ticker-mobile-app/mock-server-for-testing/+merge/194971

[Robert Steckroth (robertsteckroth)]

Ya sure, I am looking into it now.

On Tue, Nov 12, 2013 at 9:27 PM, Christopher Lee <email address hidden>wrote:

> Hi Robert, I getting a test failure
> (stock_ticker.tests.test_Subtabs.TestSubtabs.test_chart_subtab) that I'm
> not sure how to solve. I'm wondering if you could lend me your knowledge
> and help me out?
>
> The error message:
> tests/autopilot/stock_ticker/tests/test_Subtabs.py", line 90, in
> test_chart_subtab
> self.assertThat(chart_dot.x, NotEquals(dot_x))
> File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 417,
> in assertThat
> raise MismatchError(matchee, matcher, mismatch, verbose)
> MismatchError: 300.0 == 300.0
>
> I'm not certain what it (or the chart) is supposed to do in this situation
> so I can't offer a fix in the test or in the application itself either.
>
>
> Also note that I've started a WIP MR for mocking-out the server:
> https://code.launchpad.net/~veebers/stock-ticker-mobile-app/mock-server-for-testing/+merge/194971
> --
>
> https://code.launchpad.net/~veebers/stock-ticker-mobile-app/porting-autopilot-1.4/+merge/193718
> You are reviewing the proposed merge of
> lp:~veebers/stock-ticker-mobile-app/porting-autopilot-1.4 into
> lp:stock-ticker-mobile-app.
>

--
<surgemcgee> Systems/Software Engineer

[Robert Steckroth (robertsteckroth)]

Ok, I have looked into it but so not have the time to make the changes. Here is what you need to do.
* Remove all of the domain re-naming code from the application. This can be altered in the autopilot tests instead.
* Create a yahoo data stream for the front page. The application defaults to yahoo which is needed to run the tests.
* The chart.dot need to have an active stock to work. This will be fixed when yahoo is added as above^
* line: 52 in the Current_charts_page needs to be altered to this --> "onValueChanged: chart_day_range = value". I recommend puling from the stable branch until I find the time to fully integrate Indurate into the app.

Good python work by the way :)

[Christopher Lee (veebers)]

Hi Robert, thanks :-) Thanks for taking the time to look at that issue.

I'm not the most intimate with this applications codebase so will need to look into what your comments entail.
In the meantime could you take a look at the mock server MR and make any suggestions you have on that? I get the feeling that some of your above comments can be introduced into that MR or perhaps after that code has landed?

[Robert Steckroth (robertsteckroth)]

Ya, I did, the code looks good. I like the use of @property as a getter looping mechanism for the port (very clever).
I should be able to get a few extra days off work here shortly and polish up some things.

[Christopher Lee (veebers)]

Hi Robert,

I've let these MR's get stale (this one and
https://code.launchpad.net/~veebers/stock-ticker-mobile-app/mock-server-for-testing/+merge/194971).

At this stage I feel that _this_ branch is suitable to merge as it fixes all but
one test failure. I'll need your assistance, or ask you to take it on, to fix
the remaining as I don't have the familiarity of the application and
requirements to do so in any timely fashion.

WRT the second MR, the mock server, as mentioned previously I have this working
for me but a colleague is seeing failures. Again, I'm not familiar enough with
this application and it's data consumption use to efficiently solve this problem
so I'll ask that you can take this on and I can assist you in getting it
completed.

I'm hoping that we can get some movement on this in the near future.

Chris.

=== modified file 'Current_charts_page.qml'
--- Current_charts_page.qml	2013-09-04 01:51:45 +0000
+++ Current_charts_page.qml	2013-11-08 03:33:30 +0000
@@ -20,6 +20,7 @@
 import "javascript/graph.js" as Graph
 
 Rectangle {
+    objectName: "chartDetails"
     property var canvas_object
     onVisibleChanged: visible && displayDayInfo()
    // color: "#FCFCFC"

=== modified file 'tests/autopilot/stock_ticker/tests/__init__.py'
--- tests/autopilot/stock_ticker/tests/__init__.py	2013-11-08 03:33:30 +0000
+++ tests/autopilot/stock_ticker/tests/__init__.py	2013-11-08 03:33:30 +0000
@@ -41,7 +41,7 @@
         scenarios = [('with touch', dict(input_device_class=Touch))]
 
     local_location = "../../Stock_Ticker.qml"
-    installed_location = "/usr/share/stock-ticker-mobile-app/Stock_Tickers.qml"
+    installed_location = "/usr/share/stock-ticker-mobile-app/Stock_Ticker.qml"
     sqlite_dir = os.path.expanduser(
         "~/.local/share/com.ubuntu.stock-ticker-mobile/Databases")
     backup_dir = sqlite_dir + ".backup"

=== modified file 'tests/autopilot/stock_ticker/tests/test_Management_page.py'
--- tests/autopilot/stock_ticker/tests/test_Management_page.py	2013-10-10 18:51:45 +0000
+++ tests/autopilot/stock_ticker/tests/test_Management_page.py	2013-11-08 03:33:30 +0000
@@ -23,6 +23,7 @@
 from __future__ import absolute_import
 
 from testtools.matchers import Equals
+from autopilot.introspection.dbus import StateNotFoundError
 from autopilot.matchers import Eventually
 from stock_ticker.tests import StockTickerTestCase
 
@@ -95,19 +96,23 @@
         management_delegate = \
             management_listview.get_children()[0].get_children()
 
-        cmpy_index = -1
+        # Find the newly added row and list item.
+        target_row = None
         for o in management_delegate:
-            add_list_item = o.select_single(
-                'QQuickText', objectName='companyNameText')
-            cmpy_index += 1
-            if add_list_item and hasattr(add_list_item, 'text'):
-                if add_list_item.text == 'Google Inc.':
-                    break
-
-        self.assertThat(add_list_item.text, Eventually(Equals('Google Inc.')))
-
-        remove_button = management_delegate[cmpy_index].select_single(
-            'QQuickItem', objectName='removeButton')
+            try:
+                o.select_single(
+                    'QQuickText',
+                    objectName='companyNameText',
+                    text="Google Inc."
+                )
+                target_row = o
+                break
+            except StateNotFoundError:
+                pass
+
+        remove_button = target_row.select_single(
+            'QQuickItem',
+            objectName='removeButton')
         self.pointing_device.click_object(remove_button)
 
         self.assertThat(management_listview.count,

=== modified file 'tests/autopilot/stock_ticker/tests/test_Subtabs.py'
--- tests/autopilot/stock_ticker/tests/test_Subtabs.py	2013-11-08 03:33:30 +0000
+++ tests/autopilot/stock_ticker/tests/test_Subtabs.py	2013-11-08 03:33:30 +0000
@@ -54,32 +54,38 @@
         details_button = sub_bar.select_single(
             'UbuntuShape', objectName='detailsTab')
 
-        subtab_pages = self.app.select_single(
-            'QQuickItem', objectName='currentRectSizer').get_children()
+        tabs_container = self.app.select_single(
+            'QQuickItem', objectName='currentRectSizer')
+        chart_details = tabs_container.select_single(
+            "Current",
+            objectName="chartDetails")
+        details_listview = tabs_container.select_single(
+            "QQuickListView",
+            objectName="detailsListView")
 
         # Ensure toolbar is hidden so we can interact with buttons
         self.main_view.close_toolbar()
 
         self.pointing_device.click_object(details_button)
-        self.assertThat(subtab_pages[2].visible, Eventually(Equals(True)))
+        self.assertThat(details_listview.visible, Eventually(Equals(True)))
 
         self.pointing_device.click_object(charts_button)
 
-        self.assertThat(subtab_pages[2].visible, Eventually(Equals(False)))
-        self.assertThat(subtab_pages[1].visible, Eventually(Equals(True)))
+        self.assertThat(details_listview.visible, Eventually(Equals(False)))
+        self.assertThat(chart_details.visible, Eventually(Equals(True)))
 
         chart_dot = self.app.select_single(
             'QQuickImage', objectName='chartDot')
         chart_info = self.app.select_single(
             'QQuickText', objectName='dayInfoText')
 
-        self.pointing_device.click_object(subtab_pages[1])
+        self.pointing_device.click_object(chart_details)
 
         dot_x = chart_dot.x
         info_text = chart_info.text
 
         self.main_view.move_subtabs_bar_up()
-        self.main_view.flick_page_right(subtab_pages[1])
+        self.main_view.flick_page_right(chart_details)
 
         self.assertThat(chart_dot.x, NotEquals(dot_x))
         self.assertThat(chart_info.text, NotEquals(info_text))
@@ -106,22 +112,25 @@
         details_button = sub_bar.select_single(
             'UbuntuShape', objectName='detailsTab')
 
-        subtab_pages = self.app.select_single(
-            'QQuickItem', objectName='currentRectSizer').get_children()
+        tabs_container = self.app.select_single(
+            'QQuickItem', objectName='currentRectSizer')
+        news_listview = tabs_container.select_single(
+            "QQuickListView",
+            objectName="newsListView")
+        details_listview = tabs_container.select_single(
+            "QQuickListView",
+            objectName="detailsListView")
 
         # Ensure toolbar is hidden so we can interact with buttons
         self.main_view.close_toolbar()
 
         self.pointing_device.click_object(news_button)
-        self.assertThat(subtab_pages[3].visible, Eventually(Equals(True)))
+        self.assertThat(news_listview.visible, Eventually(Equals(True)))
 
         self.pointing_device.click_object(details_button)
 
-        self.assertThat(subtab_pages[3].visible, Eventually(Equals(False)))
-        self.assertThat(subtab_pages[2].visible, Eventually(Equals(True)))
-
-        details_listview = self.app.select_single(
-            'QQuickListView', objectName='detailsListView')
+        self.assertThat(news_listview.visible, Eventually(Equals(False)))
+        self.assertThat(details_button.visible, Eventually(Equals(True)))
 
         contentY = details_listview.contentY
 
@@ -129,7 +138,7 @@
                         Eventually(Equals(details_listview.contentY)))
 
         self.main_view.move_subtabs_bar_up()
-        self.main_view.hold_page_down(subtab_pages[2])
+        self.main_view.hold_page_down(details_listview)
 
         self.assertThat(details_listview.contentY,
                         Eventually(NotEquals(contentY)))
@@ -157,29 +166,33 @@
         details_button = sub_bar.select_single(
             'UbuntuShape', objectName='detailsTab')
 
-        subtab_pages = self.app.select_single(
-            'QQuickItem', objectName='currentRectSizer').get_children()
-
-        # Ensure toolbar is hidden so we can interact with buttons
+        tabs_container = self.app.select_single(
+            'QQuickItem',
+            objectName='currentRectSizer')
+
+        news_listview = tabs_container.select_single(
+            "QQuickListView",
+            objectName="newsListView")
+        details_listview = tabs_container.select_single(
+            "QQuickListView",
+            objectName="detailsListView")
+
         self.main_view.close_toolbar()
 
         self.pointing_device.click_object(details_button)
-        self.assertThat(subtab_pages[2].visible, Eventually(Equals(True)))
+        self.assertThat(details_listview.visible, Eventually(Equals(True)))
 
         self.pointing_device.click_object(news_button)
 
-        self.assertThat(subtab_pages[2].visible, Eventually(Equals(False)))
-        self.assertThat(subtab_pages[3].visible, Eventually(Equals(True)))
-
-        news_listview = self.app.select_single(
-            'QQuickListView', objectName='newsListView')
+        self.assertThat(details_listview.visible, Eventually(Equals(False)))
+        self.assertThat(news_listview.visible, Eventually(Equals(True)))
 
         contentY = news_listview.contentY
 
         self.assertThat(news_listview.contentY, Eventually(Equals(contentY)))
 
         self.main_view.move_subtabs_bar_up()
-        self.main_view.hold_page_down(subtab_pages[3])
+        self.main_view.hold_page_down(news_listview)
 
         self.assertThat(news_listview.contentY,
                         Eventually(NotEquals(contentY)))