Code review comment for lp:~vauxoo/openobject-addons/7.0-project_task_test_yaml_multi-company

Hello,

As I told Nhomar, I understand the idea but I still think it is more of a customization than a valid change for the core.

First, there's the issue of res.partner in addition to res.users: in many places a partner is used instead of a user (e.g. for followers, email recipients, etc.). Due to the recent bugfix for bug 1073087, partners will follow the user's company at all times. So it's not just users, and the rule for partners would become more complicated, as they don't have "company_ids" directly.

Next, if you could write a rule that allows users to see other users if they have at least one company in common, it seems it will easily allow mixing incorrect values. Imagine userABC can see userCDE because they have company C in common, this would mean they could mix up data and assign userCDE to a document from CompanyA, which userCDE would never be able to see. I agree that it may not make any business sense to do that, but it would be possible.

It seems to me that any complete multi-company deployment includes a lot of review/fine-tuning of the default rules to adapt them to the company's business rules, and this issue should simply be considered as part of it, don't you think?

That said, multi-company is clearly an area in OpenERP that deserves improvements and research in usability, but I think that requires a more profound rework of the system (like adding assistants to help setup multi-company rules but also data like locations, shops, etc.)