Merge lp:~vauxoo/openobject-addons/7.0-project_task_test_yaml_multi-company into lp:openobject-addons/7.0

[Jorge Angel Naranjo Rogel - http://www.vauxoo.com]

Added test yaml for assign tasks with users multi-company

[lp:~vauxoo/openobject-addons/7.0-project_task_test_yaml_multi-company]

9409. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-03

[FIX] Fixed messages

[Jorge Angel Naranjo Rogel - http://www.vauxoo.com (jorge-nr)]

Fixed messages of test yaml task_multicompany

review: Needs Resubmitting

[Nhomar - Vauxoo (nhomar)]

This branch is a Work in Progress, when it is solved in our OPW this test will say everything is Ok!-

[lp:~vauxoo/openobject-addons/7.0-project_task_test_yaml_multi-company]

9410. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Added test yaml in demo

9411. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Send mail message from userA to userAB

9412. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Setting Receive Messages by Email to None

9413. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[FIX][project] Fixed test yaml task_multicompany

9414. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP] Validate res_users

9415. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Separated test 1 and 2

9416. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Improvemente in message of assert

9417. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Changed of user to create task ''Task assigned to UserAB by UserA with company A''

[Moisés López - http://www.vauxoo.com (moylop260)]

We change the test to see the demo data created in RunBot.
We also changed the focus of the test to show two important cases
1. Error mail.message view
2. Operation error to assign tasks to users who regularly change company

POINT # 1:
You can see in http://runbot.openerp.com/vauxoo.html
Instance: 7.0-project_task_test_yaml_multi-company
Connect with
user: userab
password: userab
You can see the error in mail.message view
https://docs.google.com/file/d/0BwPeHBuUYqNsODZ5NEFzOU94czg/edit?usp=sharing
You can check log here:
2013-09-10 20:58:52,202 27345 INFO 7-0-project-task-test-yaml-multi-company-19725-all openerp.modules.loading: module project: loading test/task_mail_multicompany_test.yml
2013-09-10 20:58:52,208 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Test 1, Assigned task to UserA with Multi-Company user
2013-09-10 20:58:52,208 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Read task of UserAB with UserA
2013-09-10 20:58:52,211 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Read task of UserAB with UserA
2013-09-10 20:58:52,214 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Read mail of UserAB with CompanyB
2013-09-10 20:58:52,238 27345 ERROR 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: AssertionError in Python code : Wrong. UserAB with company B can read my message, but I can not see the attached task.

POINT # 2:
2013-09-10 20:58:52,238 27345 INFO 7-0-project-task-test-yaml-multi-company-19725-all openerp.modules.loading: module project: loading test/task_multicompany_user_test.yml
2013-09-10 20:58:52,242 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Test 2, Assigned task to User Multi-Company with User A
2013-09-10 20:58:52,243 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Assigned companyA in UserAB
2013-09-10 20:58:52,261 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Create task assigned to UserAB with company A create by UserA
2013-09-10 20:58:52,369 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Changed companyA to companyB in UserAB
2013-09-10 20:58:52,387 27345 TEST 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: Task assigned to UserAB with company B create by UserA
2013-09-10 20:58:52,399 27345 ERROR 7-0-project-task-test-yaml-multi-company-19725-all openerp.tools.yaml_import: AssertionError in Python code : Wrong. No userAB found. The user can not attached to this task

I UserA create a first task to UserAB when I want create a second task to UserAB this not exist.

[Olivier Dony (Odoo) (odo-openerp)]

Thanks for the update!

The errors that are highlighted by your tests are now quite clear. They are however the normal consequences of the way multi-company is designed in OpenERP at the moment. My comment (#3) on bug 1210263 explains why this is the expected behavior and gives some suggested workarounds for cases where this approach is not suitable.

This is however a case-by-case customization, as we cannot globally decide that the default multi-company rules should be less restrictive, or allow users who work in multiple companies to see records from all their companies all the time (very high chance of inconsistent data mix).

I hope you understand our position...

This may open up the debate about how multi-company works in OpenERP, but I'm not sure how we could keep it simple while still allowing this amount of flexibility. If UserAB is allowed to see documents from CompanyA and CompanyB all the time it will be a big mess, and there does not seem to be any other generic way to pass your tests?

[Moisés López - http://www.vauxoo.com (moylop260)]

Hello Oliver,

We understand you position with comment:
"Allow users who work in multiple companies to see records from all their companies all the time (very high chance of inconsistent data mix)."

We are agree with this.
We don't want mix project.task
We don't want mix purchase.order
We don't want mix sale.order
We knows inconsistent data mix in this models.

We have a functional problem that the res.users hiding or showing when it changes company_id, but other users lose control for this too.
Assign task, see responsible of purchases, add followers... (all models with res.users relation).
Then we need set a standard and special solution.

IMHO the unique model with posibility of data mixing should be res.users with company_ids ACL
No project.task, no purchase.order data mix.
Only res.users. We may assign records to users regardless if he changed his company and not generate data mix in other models.

E.G.
user1_company_ids = [1,2,3,4]
user2_company_ids = [4,5,6]
user1_read_users2_ok = any( [True for user1_company_id in user1_company_ids if user1_company_id in user2_company_ids] )
if user1_read_users2_ok:
   print "User1 read users2 because has a common company in company_ids"
else:
   print "User1 don't read users2"

[Olivier Dony (Odoo) (odo-openerp)]

Hello,

As I told Nhomar, I understand the idea but I still think it is more of a customization than a valid change for the core.

First, there's the issue of res.partner in addition to res.users: in many places a partner is used instead of a user (e.g. for followers, email recipients, etc.). Due to the recent bugfix for bug 1073087, partners will follow the user's company at all times. So it's not just users, and the rule for partners would become more complicated, as they don't have "company_ids" directly.

Next, if you could write a rule that allows users to see other users if they have at least one company in common, it seems it will easily allow mixing incorrect values. Imagine userABC can see userCDE because they have company C in common, this would mean they could mix up data and assign userCDE to a document from CompanyA, which userCDE would never be able to see. I agree that it may not make any business sense to do that, but it would be possible.

It seems to me that any complete multi-company deployment includes a lot of review/fine-tuning of the default rules to adapt them to the company's business rules, and this issue should simply be considered as part of it, don't you think?

That said, multi-company is clearly an area in OpenERP that deserves improvements and research in usability, but I think that requires a more profound rework of the system (like adding assistants to help setup multi-company rules but also data like locations, shops, etc.)

[Nhomar - Vauxoo (nhomar)]

Hello Oliver, thanks for the feedback.

Lets explain better trying to show our point.

Messages are blocking business objects! IT IS a problem __always__ no matter why.

The unique solution we found is overwrite the ACL including the concept of company_ids, you say it is incorrect by definition, we understand, but, The workaround?

WE ARE AGREED :: It is a case-by-case analysis, ok, agreed, can we work in the "Case of Users."

Have multiples users per user brake any multi-company deploy because imagine i have 100 Users per comapny, with 40 sharing companies (real case) and 6 companies (for fiscal and logistic reasons it is possible and a real case) then I will have 40x6 + specific users = +300 users, it means __only__ for enterprise reasons is a crazy scenario, didn't say for administration PoV.

We build some modules that help, like clear permissions, build our own groups and so on, but in this point we are a little confused, why? IMHO because the multi-company ACL for users __must__ be in the core.

I make you by twitter an example let me be more deep here.

What you are thinking is a "Customization" is like Linus Torvalds says "Ok say users they must be care about security in /root folder and /usr/bin" and installing linux by default when i create a limited users the machine does't run in "Some Specific Places" because the *bin* folder in " blocked " by default and -It is an expected behavior.

Good It is my complain ;-) sorry... Now the solution.

We propose you in this MP, exchange with us what do you think is a Secure Way to deal with this specific scenario "May be proposing specifically what ACL we should use" and we can test it, and may be between you and us.

1.- Propose an MP for Trunk.
2.- Propose an MP for 7.0

The Solution that "Conceptually" we should achieve is:

If I need to show some "Fields" from the core in multi-company environments the model ItSelf must manage and deal with this Fields in an special way.

In this point messages query user's names it is the problem, can we Show the Name? only, build an ACL for it, and make generic?, Show the name and block the rest of fields like password and so on?

Can you enlighten us here, because I can't see the solution quickly as you say.

I understand very well ACL if you propose the "domain" to deal with it Great, but even without use python to overwrite the behavior your statement is telling us something what is Impossible i think.

For sure I don't have problems if this job needs some consultancy hours, but I can't see the solution now.

Thanks for your time dude really thanks.

review: Needs Information

Unmerged revisions

9417. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Changed of user to create task ''Task assigned to UserAB by UserA with company A''

9416. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Improvemente in message of assert

9415. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP][project] Separated test 1 and 2

9414. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[IMP] Validate res_users

9413. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-10

[FIX][project] Fixed test yaml task_multicompany

9412. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Setting Receive Messages by Email to None

9411. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Send mail message from userA to userAB

9410. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-09

[IMP][project] Added test yaml in demo

9409. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-03

[FIX] Fixed messages

9408. By Jorge Angel Naranjo Rogel - http://www.vauxoo.com on 2013-09-02

[FIX] Added ' in fields of type string

=== modified file 'project/__openerp__.py'
--- project/__openerp__.py	2013-01-31 18:41:41 +0000
+++ project/__openerp__.py	2013-09-10 20:53:32 +0000
@@ -77,11 +77,15 @@
         'board_project_view.xml',
         'res_config_view.xml',
     ],
-    'demo': ['project_demo.xml'],
+    'demo': ['project_demo.xml',
+             'demo/task_multicompany_demo.yml',
+             ],
     'test': [
         'test/project_demo.yml',
         'test/project_process.yml',
         'test/task_process.yml',
+        'test/task_mail_multicompany_test.yml',
+        'test/task_multicompany_user_test.yml',
     ],
     'installable': True,
     'auto_install': False,

=== added directory 'project/demo'
=== added file 'project/demo/task_multicompany_demo.yml'
--- project/demo/task_multicompany_demo.yml	1970-01-01 00:00:00 +0000
+++ project/demo/task_multicompany_demo.yml	2013-09-10 20:53:32 +0000
@@ -0,0 +1,87 @@
+-
+    Test 1, Assigned task to UserA with Multi-Company user
+-
+  Create company 'CompanyTestA'
+-
+  !record {model: res.company, id: res_company_companyTestA, view: base.view_company_form}:
+    name: 'CompanyTestA'
+-
+  Create company 'CompanyTestB'
+-
+  !record {model: res.company, id: res_company_companyTestB, view: base.view_company_form}:
+    name: 'CompanyTestB'
+-
+  Create user 'UserAB'
+-
+  !record {model: res.users, id: res_users_AB, view: base.view_users_form}:
+    company_id: base.main_company
+    name: 'UserAB'
+    login: 'userab'
+    password: 'userab'
+    notification_email_send: 'none'
+    email: '[e-mail]'
+-
+  Create user 'UserA'
+-
+  !record {model: res.users, id: res_users_A, view: base.view_users_form}:
+    company_id: base.main_company
+    name: 'UserA'
+    login: 'usera'
+    password: 'usera'
+    notification_email_send: 'none'
+    email: '[e-mail]'
+-
+    Added companies to UserAB
+-
+  !python {model: res.users}: |
+    data = self.read(cr,uid, [ref('base.user_root')], ['groups_id','company_ids'], context=context)
+    groups_ids=data[0].get('groups_id')
+    groups_ids.append(ref('base.group_multi_company'))
+    data = self.read(cr,uid, [ref('res_users_AB')], ['groups_id','company_ids'], context=context)
+    company_ids=data[0].get('company_ids')
+    company_ids.append(ref('res_company_companyTestA'))
+    company_ids.append(ref('res_company_companyTestB'))
+    self.write(cr,uid, [ref('res_users_AB')], {'groups_id': [(6, 0, groups_ids)] ,'company_ids': [(6, 0, company_ids)],'company_id': ref('res_company_companyTestA')}, context=context)
+-
+    Added companies to UserA
+-
+  !python {model: res.users}: |
+    data = self.read(cr,uid, [ref('base.user_root')], ['groups_id','company_ids'], context=context)
+    groups_ids=data[0].get('groups_id')
+    groups_ids.append(ref('base.group_multi_company'))
+    data = self.read(cr,uid, [ref('res_users_A')], ['groups_id','company_ids'], context=context)
+    company_ids=data[0].get('company_ids')
+    company_ids.append(ref('res_company_companyTestA'))
+    self.write(cr,uid, [ref('res_users_A')], {'groups_id': [(6, 0, groups_ids)] ,'company_ids': [(6, 0, company_ids)],'company_id': ref('res_company_companyTestA')}, context=context)
+-
+    Create task assigned to UserAB
+-
+  !python {model: project.task}: |
+    vals = {'name':'Task assigned to UserAB by UserA with company A','user_id': ref('res_users_AB')}
+    self.create(cr, ref('res_users_A'), vals, context=context)
+-
+    Changed companyA to companyB in UserAB
+-
+  !python {model: res.users}: |
+    self.write(cr,uid, [ref('res_users_AB')], {'company_id': ref('res_company_companyTestB')}, context=context)
+-
+  Send mail message from userA to userAB
+-
+  !python {model: mail.message}: |
+    task_id = self.pool.get('project.task').search(cr, ref('res_users_A'), [('name','like','Task assigned to UserAB by UserA with company A')])[0]
+    partner_id = self.pool.get('res.users').browse(cr, ref('res_users_A'), [ref('res_users_A')])[0].partner_id.id
+    mail_parent_id = self.search(cr, ref('res_users_A'), [('res_id', '=', task_id )])[0]
+    vals = {'subject': 'Do you remember this task?',
+            'model': 'project.task',
+            'res_id': task_id ,
+            'body': """Hello. I would like to know that happened with this task. """,
+            'type': 'email',
+            'subtype_id': ref('mail.mt_comment'),
+            'parent_id': mail_parent_id,
+            'email_from': '[e-mail]',
+            'author_id': partner_id,
+            }
+    self.create(cr, ref('res_users_A'), vals, context=context)
+
+
+

=== added file 'project/test/task_mail_multicompany_test.yml'
--- project/test/task_mail_multicompany_test.yml	1970-01-01 00:00:00 +0000
+++ project/test/task_mail_multicompany_test.yml	2013-09-10 20:53:32 +0000
@@ -0,0 +1,23 @@
+-
+    Test 1, Assigned task to UserA with Multi-Company user
+-
+    Read task of UserAB with UserA
+-
+  !python {model: project.task}: |
+    task_id = self.search(cr, ref('res_users_A'), [('name','like','Task assigned to UserAB by UserA with company A')])
+    assert len(self.read(cr, ref('res_users_A'), task_id , ['name','user_id'])) > 0, 'Wrong. UserA with company A can not read this task'
+-
+    Read task of UserAB with UserA
+-
+  !python {model: project.task}: |
+    task_id = self.search(cr, ref('res_users_A'), [('name','like','Task assigned to UserAB by UserA with company A')])
+    assert len(self.read(cr, ref('res_users_A'), task_id , ['name','user_id'])) > 0, 'Wrong. UserA with company A can not read this task'
+-
+    Read mail of UserAB with CompanyB
+-
+  !python {model: mail.message}: |
+    mail_id = self.search(cr, ref('res_users_AB'), [('subject','like','Do you remember this task?')])
+    assert len(mail_id) > 0, 'Wrong. UserAB with company B can not read this mail'
+    mail_read = self.read(cr, ref('res_users_AB'), mail_id , ['subject','body','res_id'])
+    task_ids = self.pool.get('project.task').search(cr, ref('res_users_AB'), [('id','=',mail_read[0].get('res_id'))])
+    assert len(task_ids) > 0, 'Wrong. UserAB with company B can read my message, but I can not see the attached task.'

=== added file 'project/test/task_multicompany_user_test.yml'
--- project/test/task_multicompany_user_test.yml	1970-01-01 00:00:00 +0000
+++ project/test/task_multicompany_user_test.yml	2013-09-10 20:53:32 +0000
@@ -0,0 +1,35 @@
+-
+    Test 2, Assigned task to User Multi-Company with User A
+-
+    Assigned companyA in UserAB
+-
+  !python {model: res.users}: |
+    self.write(cr,uid, [ref('res_users_AB')], {'company_id': ref('res_company_companyTestA')}, context=context)
+-
+    Create task assigned to UserAB with company A create by UserA
+-
+  !python {model: project.task}: |
+    res_user_id = self.pool.get('res.users').search(cr, ref('res_users_A') , [('id','=',ref('res_users_AB'))])
+    assert len(res_user_id) > 0, 'Wrong. No userAB found '
+    vals = {
+    'name':'Task assigned to UserAB with company A create by UserA',
+    'user_id': res_user_id[0],
+    }
+    self.create(cr, ref('res_users_A'), vals, context=context)
+-
+    Changed companyA to companyB in UserAB
+-
+  !python {model: res.users}: |
+    self.write(cr,uid, [ref('res_users_AB')], {'company_id': ref('res_company_companyTestB')}, context=context)
+-
+    Task assigned to UserAB with company B create by UserA
+-
+  !python {model: project.task}: |
+    res_user_id = self.pool.get('res.users').search(cr, ref('res_users_A') , [('id','=',ref('res_users_AB'))])
+    assert len(res_user_id) > 0, 'Wrong. No userAB found. The user can not attached to this task'
+    vals = {
+    'name':'Task assigned to UserAB with company B create by UserA',
+    'user_id': res_user_id[0] ,
+    }
+    self.create(cr, ref('res_users_A'), vals, context=context)
+