Code review comment for lp:~vanvugt/unity/regionalDamage

FYI, this is going to have pretty giant conflict with:

https://code.launchpad.net/~smspillaz/unity/unity.less-paint-insanity/+merge/110267

Since the "should we repaint" logic was moved into a separate file.

You should be able to get away with:

12 + /*
13 + * TODO: Figure out if we can ask compiz when:
14 + * output->containsFullscreenWindows();
15 + * and if true, then force doShellRepaint=false here.
16 + */
           bool doShellRepaint = wt->GetDrawList().size() > 0 ||
18 + BackgroundEffectHelper::HasDirtyHelpers() ||
19 + switcher_controller_->Visible() ||
20 + launcher_controller_->IsOverlayOpen() ||
21 + (mask & (PAINT_SCREEN_TRANSFORMED_MASK |
22 + PAINT_SCREEN_FULL_MASK |
23 + PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_MASK));
24 +

if (doShellRepaint)
  ShellRepaintRequired ();

25 + /* Warning: ^ checking for PAINT_SCREEN_FULL_MASK is necessary right now
26 + * to avoid flickering. However it will nullify our performance
27 + * optimizations for people who have enabled "Force full screen
28 + * redraws" in the Workarounds plugin.
29 + */

A small note - it would certainly be nice if we had a method to get a collection of all the nux base windows.