Code review comment for lp:~vanvugt/unity/fix-1021541

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This looks okay.

If you're having trouble with override redirect windows not visually obscuring the dash and launcher, but logically doing so and thus causing the dash and launcher to flicker, I'd suggest using CompWindow::region () instead of CompWindow::geometry (), as the former will include the XShape region.

Either that or don't include override redirect windows in the calculation when the cursor is grabbed.

« Back to merge proposal