Merge lp:~vanvugt/unity/fix-1021541 into lp:unity
Proposed by
Daniel van Vugt
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Łukasz Zemczak | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 2473 | ||||
Proposed branch: | lp:~vanvugt/unity/fix-1021541 | ||||
Merge into: | lp:unity | ||||
Diff against target: |
160 lines (+37/-33) 3 files modified
manual-tests/Dash.txt (+15/-0) plugins/unityshell/src/unityshell.cpp (+20/-32) plugins/unityshell/src/unityshell.h (+2/-1) |
||||
To merge this branch: | bzr merge lp:~vanvugt/unity/fix-1021541 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak | Approve | ||
Review via email:
|
Commit message
Ensure the unity shell gets drawn before (below) windows stacked above it,
like DnD icons (LP: #1021541)
Description of the change
Ensure the unity shell gets drawn before (below) windows stacked above it,
like DnD icons (LP: #1021541)
UNBLOCK
To post a comment you must log in.
This looks okay.
If you're having trouble with override redirect windows not visually obscuring the dash and launcher, but logically doing so and thus causing the dash and launcher to flicker, I'd suggest using CompWindow::region () instead of CompWindow: :geometry (), as the former will include the XShape region.
Either that or don't include override redirect windows in the calculation when the cursor is grabbed.