Mir

Code review comment for lp:~vanvugt/mir/log-level

Revision history for this message
Robert Carr (robertcarr) wrote :

I think Chris is right w.r.t. report interface on the logger.

Daniel wrote:
"That would create some two-way coupling where really we want to keep it one-way...
Reports sometimes use Loggers. Loggers shouldn't know that reports exist."

I expect we could use a seperate interface, Reports then would use reporters which of course know that reports exist. Of course in implementation it may be the same logger object.

« Back to merge proposal