Merge lp:~vanvugt/mir/log-level into lp:mir

[Daniel van Vugt]

Set sane limits on how much logging is output by default:
  Servers: Log everything.
  Clients: Log errors only by default, or more if a report requires.
  Nested servers (which are also clients): Log everything.

(LP: #1414883)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2207
http://jenkins.qa.ubuntu.com/job/mir-ci/2585/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/755
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/755
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/717
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/582
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/582/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/717
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/717/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3847
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16866

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2585/rebuild

review: Approve (continuous-integration)

[Robert Carr (robertcarr)]

Needs information/discussion.

I think I understand the logic for servers and clients.

# Servers: Log everything
# Clients: Log errors only by default, or more if a report requires.

A server is unlikely to be run directly by the user, or if it is, is likely to be run by a user
with an interest in log output. Likewise, clients are relatively likely to be run by a user, e.g.
running an app from a terminal.

I don't think I agree with the tests case though:
# Tests: Log errors only

It's easy to see if a test fails and locate the failing test. Either by color coding or searching for "FAIL". All passing test output can be ignored. Why else wouldn't you want the most detailed logging possible for a failing test?

review: Needs Information

[Daniel van Vugt (vanvugt)]

Robert: I think you misinterpret what I mean by logging in tests. It's just one stray message I'm hiding from tests; see bug 1408231. Actually it's a continuation of bug 1394221.

[Alan Griffiths (alan-griffiths)]

50 + void set_level(Severity max_level) { log_level = max_level; }
51 +

We shouldn't have implementation in an interface or in a header. This fails on both counts.

~~~~

63 +std::shared_ptr<Logger> get_logger();

So the only point of this is to be able to set the log level? Why not just set a suitable logger? Or have a set_level() function?

~~~~~

113 + // Ensure clients don't get polluted with Mir information/debug
114 + // messages by default.
115 + ret->set_level(mir::logging::Severity::error);

This play badly with servers that use the client API. We don't want to override their logging defaults.

Also, it would be convenient to configure the logging level at runtime. E.g. environment variable for clients or the command line for servers.

review: Needs Fixing

[Robert Carr (robertcarr)]

>> Robert: I think you misinterpret what I mean by logging in tests. It's just one stray message I'm
>> hiding from tests;

I don't think I did? That log of course isn't useful, but there could be other informational logs from the server which are useful to debugging a failing test right?

[Chris Halse Rogers (raof)]

I'm actually going to go one further, and say that the log message that you're trying to silence is *exactly* the sort of message you *want* in the test log output. There is nothing more frustrating than trying to fix a test that's broken because the test environment is loading a different version of the code to what you're expecting.

The interaction with the reports looks rather weird. Because you've asked for the InputReceiverReport you'll additionally get a bunch of unrelated messages, too?

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Alan:
You might notice in the history I did try for pure virtual. But dropped the idea as it doubled the diff size and still wasn't yet functional. I found it was an extreme case of "if you make this class pure virtual then the coupling and maintenance effort increases unacceptably". I'm undecided but intentionally left it in the history in case it had to be re-attempted.

[Daniel van Vugt (vanvugt)]

Chris:
Yes the single message described in bug 1408231 is pretty harmless. The harm is if we don't fix this and more log messages get added later (which we will). Then all tests will get cluttered by all those new log messages too.

[Daniel van Vugt (vanvugt)]

> 113 + // Ensure clients don't get polluted with Mir information/debug
> 114 + // messages by default.
> 115 + ret->set_level(mir::logging::Severity::error);
>
> This play badly with servers that use the client API. We don't want to
> override their logging defaults.

Yeah still needs fixing for nested servers.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2213
http://jenkins.qa.ubuntu.com/job/mir-ci/2615/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/796
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/796
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/758
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/612
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/612/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/758
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/758/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3887
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16989

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2615/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2219
http://jenkins.qa.ubuntu.com/job/mir-ci/2616/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/799
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/799
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/761
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/613
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/613/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/761
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/761/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/3888
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16991

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2616/rebuild

review: Approve (continuous-integration)

[Chris Halse Rogers (raof)]

Hm, on further thought, I think I want the following:

*) Tests run on CI should spew every piece of plausibly useful information available. The cost for missing useful information is high.
*) Enabling a report =log should make just that log's messages output, not change global log verbosity.
*) Some sort of MIR_CLIENT_DEBUG environment variable to set the global client log verbosity.

I don't really mind if hugely verbose logging is not default on local test runs; it's cheap to turn back on.

Furthermore, I think that we *can* output messages to stdout/stderr by default for clients; although they're likely to be run by users from a terminal, users who do that are unlikely to mind some log messages. And if they do, they already hate glib/gtk, which will reliably spew tens to hundreds of lines of messages for lots of apps in normal operation.

We should *also* give clients the ability to hook in their own logger; they can then silence us if they really care.

Alternatively, as Ryan suggests, we could log to the journal :).

[Daniel van Vugt (vanvugt)]

It's just a matter of annoyance. Mir (like GTK) should only pollute your terminal if you do something wrong (hence errors and worse). Otherwise the terminal output should be reserved for the app itself to use. It's unacceptable for a bug-free app to be ported to Mir and get log messages sent to its stdout against its will.

[Robert Carr (robertcarr)]

>> I don't really mind if hugely verbose logging is not default on local test runs; it's cheap to turn >> back on.

Unless you miss the logging from a test which has failed and hard to reproduce. On the other hand, when would clean test output ever help? The termination of the test suite will always be clean, and you can see if there was a failure at this stage. At this point you can use your terminal to locate "FAIL"

[Daniel van Vugt (vanvugt)]

BTW, in this new version of the proposal I'm not changing the logging in tests. We don't need to discuss that here - I've separated it.

[Alan Griffiths (alan-griffiths)]

I agree about clients not spamming stdout/stderr but I don't like this solution.

The problem is with the logging::log() behaviour (not the reports) so there should be no need to interfere with the logging::Log hierarchy. Doing so makes this whole proposal overly complex and risks interfering with reports that may be requested. (Not to mention having two logging level settings in glog is weird.)

All that is needed is a logging::set_level() function and a namespace scope variable to set the logging level that it shares with logging::log().

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Yeah I can see we only have a stdout issue here. If we can just "fix" DumbConsolerLogger and nothing else then we should. The problem is; everything else in Mir works with a generic Logger. Even:
  void set_logger(std::shared_ptr<Logger> const& new_logger);
indicates that the default process-wide logger can be any implementation. So we need to touch the generic Logger interface.

I'm not sure how set_level could be made safe and reliable. I've implemented raise_level instead, because that guarantees all callers' requests are honoured (the log level never decreases to less than you need).

"The problem is with the logging::log()" ... I'm not sure it's a good idea to provide different behaviour for log() vs somelogger->log(). Sounds like it would be quite inconsistent, which this current proposal is not.

[Daniel van Vugt (vanvugt)]

Hmm... what if I dropped the reports' raise_level hacks and modified the reports to accept:
   MIR_SOMETHING_REPORT=log-<level>
?

[Chris Halse Rogers (raof)]

Another option would be to add an always-reported output option to the
Logger interface?

[Daniel van Vugt (vanvugt)]

You're suggesting severity become a two dimensional quantity instead of one? I would rather avoid that.

[Chris Halse Rogers (raof)]

I'm suggesting that severity not be the sole determinant of whether or not a message is printed. I don't think that's making severity two-dimensional, though.

[Daniel van Vugt (vanvugt)]

It is two dimensional kind of. I understand what you're suggesting but it sounds like more of a hack than what's proposed here. Or what I proposed in MIR_SOMETHING_REPORT=log-<level>.

[Daniel van Vugt (vanvugt)]

Ah. Actually my latest suggestion won't work. We still need raise_level to cover the nested server case.

[Robert Carr (robertcarr)]

review: Abstain

[Chris Halse Rogers (raof)]

I think this exposes a flaw in our architecture for logging/reporting; namely, that they're two separate things, but we've only got one Logger interface to support both.

I think we need an interface for reporting that is separate from the interface for logging. This is not a hack, this is the *undoing* of a hack.

Regardless of the outcome of that particular discussion, we've got severity/raise_level the wrong way around. debug is not a higher severity than critical :)

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Good point; by raise_level I think I meant raise_verbosity. That's confusing.

Although we could resolve the reporting issue with:
   MIR_SOMETHING_REPORT=log-<level>
which I think would be preferable to adding some "reporting" log level that exists outside the present one-dimensional range of Severity.

For servers, the reporting issue could be resolved trivially by making sure all reports are Info level. And all servers always log Info level anyway. That only leaves the reporting log level problem an issue for clients.

[Chris Halse Rogers (raof)]

Isn't the suggestion “just mandate that all reports are Info level” a pretty obvious indication that reports don't have a reporting level?

[Chris Halse Rogers (raof)]

Just to be clear, I'm not suggesting adding a “reporting” log level. I'm suggesting that the Logger (or possibly an entirely separate thing) grow a report() interface. Mandating that reports must use the Info severity is exactly the same as adding that interface but without any compiler checking.

[Daniel van Vugt (vanvugt)]

That would create some two-way coupling where really we want to keep it one-way...
Reports sometimes use Loggers. Loggers shouldn't know that reports exist.

[lp:~vanvugt/mir/log-level]

2220. By Daniel van Vugt on 2015-01-14

Merge latest trunk

2221. By Daniel van Vugt on 2015-01-15

Merge latest trunk

2222. By Daniel van Vugt on 2015-01-16

Merge latest trunk

2223. By Daniel van Vugt on 2015-01-19

Merge latest trunk

2224. By Daniel van Vugt on 2015-01-20

Merge latest trunk

2225. By Daniel van Vugt on 2015-01-21

Merge latest trunk

2226. By Daniel van Vugt on 2015-01-21

Merge latest trunk

2227. By Daniel van Vugt on 2015-01-22

Merge latest trunk

2228. By Daniel van Vugt on 2015-01-23

Merge latest trunk

2229. By Daniel van Vugt on 2015-01-23

Clarify raise_level confusion.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2229
http://jenkins.qa.ubuntu.com/job/mir-ci/2792/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1040
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1039
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1001/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/789
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/789/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1001/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2792/rebuild

review: Needs Fixing (continuous-integration)

[lp:~vanvugt/mir/log-level]

2230. By Daniel van Vugt on 2015-01-27

Merge latest trunk

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2230
http://jenkins.qa.ubuntu.com/job/mir-ci/2817/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1073
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1034
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/814
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/814/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1034
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1034/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4094
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17493

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2817/rebuild

review: Approve (continuous-integration)

[lp:~vanvugt/mir/log-level]

2231. By Daniel van Vugt on 2015-01-27

Merge latest trunk

2232. By Daniel van Vugt on 2015-01-28

Merge latest trunk and fix conflicts.

[Daniel van Vugt (vanvugt)]

Hmm, this is tricky now. Breaking the mircommon ABI might be off limits until we resolve bug 1415321.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2232
http://jenkins.qa.ubuntu.com/job/mir-ci/2840/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1065
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/837
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/837/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1065
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1065/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4121
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17540

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2840/rebuild

review: Approve (continuous-integration)

[lp:~vanvugt/mir/log-level]

2233. By Daniel van Vugt on 2015-01-29

Merge latest trunk and fix the same conflict, again.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2233
http://jenkins.qa.ubuntu.com/job/mir-ci/2849/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1118
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1117
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1079
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/846
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/846/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1079
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1079/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4133
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17591

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/2849/rebuild

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

Needs more reviewers now. I think I've found a reasonable middle ground based on previous review comments...

[Robert Carr (robertcarr)]

I think Chris is right w.r.t. report interface on the logger.

Daniel wrote:
"That would create some two-way coupling where really we want to keep it one-way...
Reports sometimes use Loggers. Loggers shouldn't know that reports exist."

I expect we could use a seperate interface, Reports then would use reporters which of course know that reports exist. Of course in implementation it may be the same logger object.

[Alan Griffiths (alan-griffiths)]

I still think this is conflating (at least) two issues.

As things are (without this MP) specific loggers can be configured to handle different logging levels differently. E.g. --glog-minloglevel constrains the levels that are logged and --glog-stderrthreshold determines which levels are written to stderr.

Point 1: This functionality already exists in GlogLogger I see no reason to add it there again:
61 +void mir::examples::GlogLogger::enable(ml::Severity severity)

Reports can optionally write to the logger and, by specifying different logging levels for their messages, enable the above capabilities. But the reports should not decide how the logger handles these levels:

Point 2: The fact that a report is writing log messages is no guarantee that those messages should appear:

168 + logger->enable(ml::Severity::informational);

Users of the global logging functions can also exploit this capability by specifying different logging levels for their messages. What doesn't currently exist is an option (as already exists for the reports) of not writing these messages to the logger.

Trying to control the global logging functions via an enable(ml::Severity severity) function in the base class is primitive compared to what users can already do using glog.

We already have logging suppressed (by default - it's an option "--logging [on|off]") in the test framework and AFAICS providing the same (or similar) facility to clients would meet the desire for quiet clients without the complexity and inflexibility of this approach.

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

OK, I have a more palatable alternative proposed:
https://code.launchpad.net/~vanvugt/mir/no-common-log/+merge/248764

Unmerged revisions

2233. By Daniel van Vugt on 2015-01-29

Merge latest trunk and fix the same conflict, again.

2232. By Daniel van Vugt on 2015-01-28

Merge latest trunk and fix conflicts.

2231. By Daniel van Vugt on 2015-01-27

Merge latest trunk

2230. By Daniel van Vugt on 2015-01-27

Merge latest trunk

2229. By Daniel van Vugt on 2015-01-23

Clarify raise_level confusion.

2228. By Daniel van Vugt on 2015-01-23

Merge latest trunk

2227. By Daniel van Vugt on 2015-01-22

Merge latest trunk

2226. By Daniel van Vugt on 2015-01-21

Merge latest trunk

2225. By Daniel van Vugt on 2015-01-21

Merge latest trunk

2224. By Daniel van Vugt on 2015-01-20

Merge latest trunk

=== modified file 'common-ABI-sha1sums'
--- common-ABI-sha1sums	2015-01-28 22:37:50 +0000
+++ common-ABI-sha1sums	2015-01-29 03:32:23 +0000
@@ -16,7 +16,7 @@
 dcf8b8982f138bdde39a241825c610e955cd5e33  include/common/mir/input/input_platform.h
 208cd6aed5ef5f8f39b3eb86604e4133cb840485  include/common/mir/input/input_receiver_thread.h
 be7d58c9fde2ce91cc66dd6144b76e08b536266b  include/common/mir/int_wrapper.h
-2de47e2790d0f7643e23eada2d8aa2987f58d086  include/common/mir/logging/logger.h
+4a94ca579b3d693e3515448820ec06a1dda4d7b8  include/common/mir/logging/logger.h
 3c9bd47bbe0764d39aa40ddd27a861557ba1d949  include/common/mir/log.h
 31b9c24e2ce7194aeea6694e81c160354033d28a  include/common/mir/optional_value.h
 9ae8473df05dd9e048a73797f01a2f34f7447554  include/common/mir/time/types.h

=== modified file 'debian/control'
--- debian/control	2015-01-23 16:25:00 +0000
+++ debian/control	2015-01-29 03:32:23 +0000
@@ -94,7 +94,7 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmircommon3 (= ${binary:Version}), 
+Depends: libmircommon4 (= ${binary:Version}), 
          libprotobuf-dev (>= 2.4.1),
          libxkbcommon-dev,
          ${misc:Depends},
@@ -254,7 +254,7 @@
  .
  Contains a tool for stress testing the Mir display server
 
-Package: libmircommon3
+Package: libmircommon4
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same

=== renamed file 'debian/libmircommon3.install' => 'debian/libmircommon4.install'
--- debian/libmircommon3.install	2015-01-14 06:39:13 +0000
+++ debian/libmircommon4.install	2015-01-29 03:32:23 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmircommon.so.3
+usr/lib/*/libmircommon.so.4

=== modified file 'examples/glog_logger.cpp'
--- examples/glog_logger.cpp	2015-01-14 06:39:13 +0000
+++ examples/glog_logger.cpp	2015-01-29 03:32:23 +0000
@@ -70,6 +70,9 @@
 
 void mir::examples::GlogLogger::log(ml::Severity severity, std::string const& message, std::string const& component)
 {
+    if (severity > log_level)
+        return;
+
     static int glog_level[] =
     {
         google::GLOG_FATAL,     // critical = 0,
@@ -83,3 +86,9 @@
     google::LogMessage(__FILE__, __LINE__, glog_level[static_cast<int>(severity)]).stream()
         << '[' << component << "] " << message;
 }
+
+void mir::examples::GlogLogger::enable(ml::Severity severity)
+{
+    if (severity > log_level)
+        log_level = severity;
+}

=== modified file 'examples/glog_logger.h'
--- examples/glog_logger.h	2015-01-14 06:39:13 +0000
+++ examples/glog_logger.h	2015-01-29 03:32:23 +0000
@@ -36,6 +36,10 @@
         mir::logging::Severity severity,
         std::string const& message,
         std::string const& component) override;
+
+    void enable(mir::logging::Severity) override;
+
+    mir::logging::Severity log_level = mir::logging::Severity::debug;
 };
 }
 }

=== modified file 'include/common/mir/logging/logger.h'
--- include/common/mir/logging/logger.h	2015-01-14 06:39:13 +0000
+++ include/common/mir/logging/logger.h	2015-01-29 03:32:23 +0000
@@ -45,6 +45,15 @@
                      const std::string& message,
                      const std::string& component) = 0;
 
+    /**
+     * Raise the log verbosity level allowed to be output.
+     * So that a process and multiple components can all share the same
+     * Logger, we need to guarantee every user's enable() request is honoured.
+     * This is done by only allowing the verbosity to be raised but never
+     * reduced.
+     */
+    virtual void enable(Severity max_level) = 0;
+
 protected:
     Logger() {}
     virtual ~Logger() = default;
@@ -54,6 +63,7 @@
 
 void log(Severity severity, const std::string& message, const std::string& component);
 void set_logger(std::shared_ptr<Logger> const& new_logger);
+std::shared_ptr<Logger> get_logger();
 
 }
 }

=== modified file 'platform-ABI-sha1sums'
--- platform-ABI-sha1sums	2015-01-28 22:37:50 +0000
+++ platform-ABI-sha1sums	2015-01-29 03:32:23 +0000
@@ -16,7 +16,7 @@
 dcf8b8982f138bdde39a241825c610e955cd5e33  include/common/mir/input/input_platform.h
 208cd6aed5ef5f8f39b3eb86604e4133cb840485  include/common/mir/input/input_receiver_thread.h
 be7d58c9fde2ce91cc66dd6144b76e08b536266b  include/common/mir/int_wrapper.h
-2de47e2790d0f7643e23eada2d8aa2987f58d086  include/common/mir/logging/logger.h
+4a94ca579b3d693e3515448820ec06a1dda4d7b8  include/common/mir/logging/logger.h
 3c9bd47bbe0764d39aa40ddd27a861557ba1d949  include/common/mir/log.h
 31b9c24e2ce7194aeea6694e81c160354033d28a  include/common/mir/optional_value.h
 9ae8473df05dd9e048a73797f01a2f34f7447554  include/common/mir/time/types.h

=== modified file 'server-ABI-sha1sums'
--- server-ABI-sha1sums	2015-01-29 02:03:42 +0000
+++ server-ABI-sha1sums	2015-01-29 03:32:23 +0000
@@ -16,7 +16,7 @@
 dcf8b8982f138bdde39a241825c610e955cd5e33  include/common/mir/input/input_platform.h
 208cd6aed5ef5f8f39b3eb86604e4133cb840485  include/common/mir/input/input_receiver_thread.h
 be7d58c9fde2ce91cc66dd6144b76e08b536266b  include/common/mir/int_wrapper.h
-2de47e2790d0f7643e23eada2d8aa2987f58d086  include/common/mir/logging/logger.h
+4a94ca579b3d693e3515448820ec06a1dda4d7b8  include/common/mir/logging/logger.h
 3c9bd47bbe0764d39aa40ddd27a861557ba1d949  include/common/mir/log.h
 31b9c24e2ce7194aeea6694e81c160354033d28a  include/common/mir/optional_value.h
 9ae8473df05dd9e048a73797f01a2f34f7447554  include/common/mir/time/types.h

=== modified file 'src/client/default_connection_configuration.cpp'
--- src/client/default_connection_configuration.cpp	2015-01-26 18:57:21 +0000
+++ src/client/default_connection_configuration.cpp	2015-01-29 03:32:23 +0000
@@ -23,7 +23,7 @@
 #include "display_configuration.h"
 #include "rpc/make_rpc_channel.h"
 #include "rpc/null_rpc_report.h"
-#include "mir/logging/dumb_console_logger.h"
+#include "mir/logging/logger.h"
 #include "mir/input/input_platform.h"
 #include "mir/input/null_input_receiver_report.h"
 #include "logging/rpc_report.h"
@@ -104,7 +104,10 @@
     return logger(
         []
         {
-            return std::make_shared<mir::logging::DumbConsoleLogger>();
+            auto ret = mir::logging::get_logger();
+            // Client logs show errors only by default
+            ret->enable(mir::logging::Severity::error);
+            return ret;
         });
 }
 

=== modified file 'src/client/logging/input_receiver_report.cpp'
--- src/client/logging/input_receiver_report.cpp	2015-01-28 19:44:36 +0000
+++ src/client/logging/input_receiver_report.cpp	2015-01-29 03:32:23 +0000
@@ -39,6 +39,7 @@
 mcll::InputReceiverReport::InputReceiverReport(std::shared_ptr<ml::Logger> const& logger)
     : logger{logger}
 {
+    logger->enable(ml::Severity::informational);
 }
 
 namespace
@@ -125,5 +126,5 @@
 
     format_event(ss, event);
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }

=== modified file 'src/client/logging/perf_report.cpp'
--- src/client/logging/perf_report.cpp	2015-01-14 06:39:13 +0000
+++ src/client/logging/perf_report.cpp	2015-01-29 03:32:23 +0000
@@ -34,6 +34,7 @@
                          std::make_shared<mir::time::SteadyClock>())
     , logger(logger)
 {
+    logger->enable(ml::Severity::informational);
 }
 
 void logging::PerfReport::display(const char *name, long fps100,

=== modified file 'src/client/logging/rpc_report.cpp'
--- src/client/logging/rpc_report.cpp	2015-01-14 06:39:13 +0000
+++ src/client/logging/rpc_report.cpp	2015-01-29 03:32:23 +0000
@@ -36,6 +36,7 @@
 mcll::RpcReport::RpcReport(std::shared_ptr<ml::Logger> const& logger)
     : logger{logger}
 {
+    logger->enable(ml::Severity::informational);
 }
 
 void mcll::RpcReport::invocation_requested(
@@ -45,7 +46,7 @@
     ss << "Invocation request: id: " << invocation.id()
        << " method_name: " << invocation.method_name();
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::invocation_succeeded(
@@ -55,7 +56,7 @@
     ss << "Invocation succeeded: id: " << invocation.id()
        << " method_name: " << invocation.method_name();
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::invocation_failed(
@@ -85,7 +86,7 @@
     std::stringstream ss;
     ss << "Result received: id: " << result.id();
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::result_receipt_failed(
@@ -104,7 +105,7 @@
     /* TODO: Log more information about event */
     ss << "Event parsed";
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::event_parsing_failed(
@@ -132,7 +133,7 @@
     std::stringstream ss;
     ss << "Complete response: id: " << result.id();
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::result_processing_failed(
@@ -154,7 +155,7 @@
     for (auto f : fds)
         ss << f << " ";
 
-    logger->log(ml::Severity::debug, ss.str(), component);
+    logger->log(ml::Severity::informational, ss.str(), component);
 }
 
 void mcll::RpcReport::connection_failure(std::exception const& x)

=== modified file 'src/common/CMakeLists.txt'
--- src/common/CMakeLists.txt	2015-01-27 23:18:05 +0000
+++ src/common/CMakeLists.txt	2015-01-29 03:32:23 +0000
@@ -53,7 +53,7 @@
 )
 
 # TODO we need a place to manage ABI and related versioning but use this as placeholder
-set(MIRCOMMON_ABI 3)
+set(MIRCOMMON_ABI 4)
 set(symbol_map ${CMAKE_CURRENT_SOURCE_DIR}/symbols.map)
 
 set_target_properties(mircommon

=== modified file 'src/common/logging/dumb_console_logger.cpp'
--- src/common/logging/dumb_console_logger.cpp	2015-01-16 02:57:31 +0000
+++ src/common/logging/dumb_console_logger.cpp	2015-01-29 03:32:23 +0000
@@ -16,7 +16,7 @@
  * Authored by: Thomas Voß <[e-mail]>
  */
 
-#include "mir/logging/dumb_console_logger.h"
+#include "dumb_console_logger.h"
 
 #include <iostream>
 #include <ctime>
@@ -28,6 +28,8 @@
                                 const std::string& message,
                                 const std::string& component)
 {
+    if (severity > log_level)
+        return;
 
     static const char* lut[5] =
     {
@@ -55,3 +57,9 @@
         << message
         << "\n";
 }
+
+void ml::DumbConsoleLogger::enable(ml::Severity max)
+{
+    if (max > log_level)
+        log_level = max;
+}

=== renamed file 'src/include/common/mir/logging/dumb_console_logger.h' => 'src/common/logging/dumb_console_logger.h'
--- src/include/common/mir/logging/dumb_console_logger.h	2015-01-14 06:39:13 +0000
+++ src/common/logging/dumb_console_logger.h	2015-01-29 03:32:23 +0000
@@ -27,10 +27,11 @@
 {
 class DumbConsoleLogger : public Logger
 {
-public:
-
 protected:
     void log(Severity severity, const std::string& message, const std::string& component) override;
+    void enable(Severity max_level) override;
+private:
+    Severity log_level = Severity::critical;
 };
 }
 }

=== modified file 'src/common/logging/logger.cpp'
--- src/common/logging/logger.cpp	2014-12-19 02:31:34 +0000
+++ src/common/logging/logger.cpp	2015-01-29 03:32:23 +0000
@@ -16,7 +16,7 @@
  * Authored by: Cemil Azizoglu <[e-mail]>
  */
 
-#include "mir/logging/dumb_console_logger.h"
+#include "dumb_console_logger.h"
 #include "mir/logging/logger.h"
 
 #include <memory>
@@ -28,8 +28,9 @@
 {
 std::mutex log_mutex;
 std::shared_ptr<ml::Logger> the_logger;
+}
 
-std::shared_ptr<ml::Logger> get_logger()
+std::shared_ptr<ml::Logger> ml::get_logger()
 {
     if (auto const result = the_logger)
     {
@@ -44,7 +45,6 @@
         return the_logger;
     }
 }
-}
 
 void ml::log(ml::Severity severity, const std::string& message, const std::string& component)
 {

=== modified file 'src/common/symbols.map'
--- src/common/symbols.map	2015-01-28 17:46:42 +0000
+++ src/common/symbols.map	2015-01-29 03:32:23 +0000
@@ -221,6 +221,7 @@
       mir::dispatch::SimpleDispatchThread::?SimpleDispatchThread*;
       typeinfo?for?mir::dispatch::SimpleDispatchThread;
       vtable?for?mir::dispatch::SimpleDispatchThread;
-      mir::events::*
+      mir::events::*;
+      mir::logging::get_logger*;
     };
 } MIR_COMMON_3.1;

=== modified file 'src/server/default_server_configuration.cpp'
--- src/server/default_server_configuration.cpp	2015-01-14 06:39:13 +0000
+++ src/server/default_server_configuration.cpp	2015-01-29 03:32:23 +0000
@@ -25,7 +25,7 @@
 #include "mir/emergency_cleanup.h"
 #include "mir/default_configuration.h"
 
-#include "mir/logging/dumb_console_logger.h"
+#include "mir/logging/logger.h"
 #include "mir/options/program_option.h"
 #include "mir/frontend/session_credentials.h"
 #include "mir/frontend/session_authorizer.h"
@@ -208,6 +208,9 @@
     return logger(
         [this]() -> std::shared_ptr<ml::Logger>
         {
-            return std::make_shared<ml::DumbConsoleLogger>();
+            auto ret = ml::get_logger();
+            // Servers always log everything
+            ret->enable(ml::Severity::debug);
+            return ret;
         });
 }

=== modified file 'src/server/display_server.cpp'
--- src/server/display_server.cpp	2015-01-28 19:44:36 +0000
+++ src/server/display_server.cpp	2015-01-29 03:32:23 +0000
@@ -214,6 +214,8 @@
 
 void mir::DisplayServer::run()
 {
+    // Servers should always log everything
+    mir::logging::get_logger()->enable(mir::logging::Severity::debug);
     mir::log_info("Mir version " MIR_VERSION);
 
     p->connector->start();

=== added file 'tests/include/mir_test_doubles/mock_logger.h'
--- tests/include/mir_test_doubles/mock_logger.h	1970-01-01 00:00:00 +0000
+++ tests/include/mir_test_doubles/mock_logger.h	2015-01-29 03:32:23 +0000
@@ -0,0 +1,44 @@
+/*
+ * Copyright © 2015 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authored by: Daniel van Vugt <[e-mail]>
+ */
+
+#ifndef MIR_TEST_DOUBLES_MOCK_LOGGER_H_
+#define MIR_TEST_DOUBLES_MOCK_LOGGER_H_
+
+#include "mir/logging/logger.h"
+#include <gmock/gmock.h>
+
+namespace mir
+{
+namespace test
+{
+namespace doubles
+{
+
+class MockLogger : public mir::logging::Logger
+{
+public:
+    MOCK_METHOD3(log, void(mir::logging::Severity, const std::string&, const std::string&));
+    MOCK_METHOD1(enable, void(mir::logging::Severity));
+    ~MockLogger() noexcept(true) {}
+};
+
+} // namespace doubles
+} // namespace test
+} // namespace mir
+
+#endif /* MIR_TEST_DOUBLES_MOCK_LOGGER_H_ */

=== modified file 'tests/include/mir_test_doubles/null_logger.h'
--- tests/include/mir_test_doubles/null_logger.h	2014-11-21 11:11:34 +0000
+++ tests/include/mir_test_doubles/null_logger.h	2015-01-29 03:32:23 +0000
@@ -34,6 +34,7 @@
 class NullLogger : public mir::logging::Logger
 {
 void log(mir::logging::Severity, const std::string&, const std::string&) override;
+void enable(mir::logging::Severity) override;
 };
 }
 }

=== modified file 'tests/mir_test_doubles/null_logger.cpp'
--- tests/mir_test_doubles/null_logger.cpp	2014-11-21 11:11:34 +0000
+++ tests/mir_test_doubles/null_logger.cpp	2015-01-29 03:32:23 +0000
@@ -26,3 +26,7 @@
 void mtd::NullLogger::log(mir::logging::Severity, const std::string&, const std::string&)
 {
 }
+
+void mtd::NullLogger::enable(mir::logging::Severity)
+{
+}

=== modified file 'tests/unit-tests/android_input/input_reader.cpp'
--- tests/unit-tests/android_input/input_reader.cpp	2015-01-28 19:44:36 +0000
+++ tests/unit-tests/android_input/input_reader.cpp	2015-01-29 03:32:23 +0000
@@ -27,25 +27,13 @@
 #include "mir/logging/logger.h"
 #include "mir/report/legacy_input_report.h"
 #include "mir_test/fake_event_hub.h"
+#include "mir_test_doubles/null_logger.h"
 
 namespace ml = mir::logging;
 
 using std::string;
 using mir::input::android::FakeEventHub;
-
-namespace
-{
-class TestLogger : public ml::Logger
-{
-public:
-    void log(ml::Severity severity, const string& message, const string& component) override {
-        (void)severity;
-        (void)message;
-        (void)component;
-    }
-};
-}
-
+using mir::test::doubles::NullLogger;
 
 namespace android {
 
@@ -569,7 +557,7 @@
     sp<InstrumentedInputReader> mReader;
 
     virtual void SetUp() {
-        mir::report::legacy_input::initialize(std::make_shared<TestLogger>());
+        mir::report::legacy_input::initialize(std::make_shared<NullLogger>());
         mReader = new InstrumentedInputReader(mFakeEventHub, mFakePolicy, mFakeListener);
     }
 
@@ -790,7 +778,7 @@
     InputDevice* mDevice;
 
     virtual void SetUp() {
-        mir::report::legacy_input::initialize(std::make_shared<TestLogger>());
+        mir::report::legacy_input::initialize(std::make_shared<NullLogger>());
         mFakeEventHub = new FakeEventHub();
         mFakePolicy = new FakeInputReaderPolicy();
         mFakeListener = new FakeInputListener();
@@ -980,7 +968,7 @@
     InputDevice* mDevice;
 
     virtual void SetUp() {
-        mir::report::legacy_input::initialize(std::make_shared<TestLogger>());
+        mir::report::legacy_input::initialize(std::make_shared<NullLogger>());
         mFakeEventHub = new FakeEventHub();
         mFakePolicy = new FakeInputReaderPolicy();
         mFakeListener = new FakeInputListener();

=== modified file 'tests/unit-tests/graphics/mesa/test_display.cpp'
--- tests/unit-tests/graphics/mesa/test_display.cpp	2015-01-22 03:10:13 +0000
+++ tests/unit-tests/graphics/mesa/test_display.cpp	2015-01-29 03:32:23 +0000
@@ -26,6 +26,7 @@
 #include "mir/time/steady_clock.h"
 #include "mir/glib_main_loop.h"
 
+#include "mir_test_doubles/mock_logger.h"
 #include "mir_test_doubles/mock_egl.h"
 #include "mir_test_doubles/mock_gl.h"
 #include "src/server/report/null_report_factory.h"
@@ -59,16 +60,10 @@
 namespace mtf=mir_test_framework;
 namespace mr=mir::report;
 
+using MockLogger = mir::test::doubles::MockLogger;
+
 namespace
 {
-struct MockLogger : public ml::Logger
-{
-    MOCK_METHOD3(log,
-                 void(ml::Severity, const std::string&, const std::string&));
-
-    ~MockLogger() noexcept(true) {}
-};
-
 class MockEventRegister : public mg::EventHandlerRegister
 {
 public:

=== modified file 'tests/unit-tests/graphics/test_graphics_platform.cpp'
--- tests/unit-tests/graphics/test_graphics_platform.cpp	2015-01-14 06:39:13 +0000
+++ tests/unit-tests/graphics/test_graphics_platform.cpp	2015-01-29 03:32:23 +0000
@@ -31,13 +31,11 @@
 #else
 #include "mir_test_doubles/mock_android_hw.h"
 #endif
-#include "mir/logging/dumb_console_logger.h"
 
 
 #include <gtest/gtest.h>
 
 namespace mg = mir::graphics;
-namespace ml = mir::logging;
 namespace geom = mir::geometry;
 namespace mtd = mir::test::doubles;
 namespace mo = mir::options;
@@ -48,7 +46,7 @@
 class GraphicsPlatform : public ::testing::Test
 {
 public:
-    GraphicsPlatform() : logger(std::make_shared<ml::DumbConsoleLogger>())
+    GraphicsPlatform()
     {
         using namespace testing;
 
@@ -71,8 +69,6 @@
         return mtd::create_platform_with_null_dependencies();
     }
 
-    std::shared_ptr<ml::Logger> logger;
-
     ::testing::NiceMock<mtd::MockEGL> mock_egl;
     ::testing::NiceMock<mtd::MockGL> mock_gl;
 #ifdef ANDROID

=== modified file 'tests/unit-tests/logging/message_processor_report.cpp'
--- tests/unit-tests/logging/message_processor_report.cpp	2015-01-14 06:39:13 +0000
+++ tests/unit-tests/logging/message_processor_report.cpp	2015-01-29 03:32:23 +0000
@@ -20,6 +20,7 @@
 #include "mir/logging/logger.h"
 
 #include "mir_test/fake_shared.h"
+#include "mir_test_doubles/mock_logger.h"
 
 #include <gtest/gtest.h>
 #include <gmock/gmock.h>
@@ -40,16 +41,9 @@
     ~MockClock() noexcept(true) {}
 };
 
-class MockLogger : public ml::Logger
-{
-public:
-    MOCK_METHOD3(log, void(ml::Severity severity, const std::string& message, const std::string& component));
-    ~MockLogger() noexcept(true) {}
-};
-
 struct MessageProcessorReport : public Test
 {
-    MockLogger logger;
+    mir::test::doubles::MockLogger logger;
     MockClock clock;
 
     mir::report::logging::MessageProcessorReport report;

=== modified file 'tests/unit-tests/logging/test_compositor_report.cpp'
--- tests/unit-tests/logging/test_compositor_report.cpp	2015-01-14 06:39:13 +0000
+++ tests/unit-tests/logging/test_compositor_report.cpp	2015-01-29 03:32:23 +0000
@@ -36,10 +36,13 @@
 class Recorder : public ml::Logger
 {
 public:
-    void log(ml::Severity, string const& message, string const&)
+    void log(ml::Severity, string const& message, string const&) override
     {
         last = message;
     }
+    void enable(ml::Severity) override
+    {
+    }
     string const& last_message() const
     {
         return last;

=== modified file 'tests/unit-tests/logging/test_display_report.cpp'
--- tests/unit-tests/logging/test_display_report.cpp	2015-01-14 06:39:13 +0000
+++ tests/unit-tests/logging/test_display_report.cpp	2015-01-29 03:32:23 +0000
@@ -17,7 +17,7 @@
  */
 
 #include "src/server/report/logging/display_report.h"
-#include "mir/logging/logger.h"
+#include "mir_test_doubles/mock_logger.h"
 #include "mir_test_doubles/mock_egl.h"
 
 #include <gtest/gtest.h>
@@ -30,13 +30,6 @@
 
 namespace
 {
-class MockLogger : public ml::Logger
-{
-public:
-    MOCK_METHOD3(log, void(ml::Severity severity, const std::string& message, const std::string& component));
-    ~MockLogger() noexcept(true) {}
-};
-
 struct DisplayReport : public testing::Test
 {
     DisplayReport()
@@ -45,10 +38,10 @@
 
     void SetUp()
     {
-        logger = std::make_shared<MockLogger>();
+        logger = std::make_shared<mtd::MockLogger>();
     }
 
-    std::shared_ptr<MockLogger> logger;
+    std::shared_ptr<mtd::MockLogger> logger;
     mtd::MockEGL mock_egl;
 };
 

=== modified file 'tests/unit-tests/logging/test_legacy_input_report.cpp'
--- tests/unit-tests/logging/test_legacy_input_report.cpp	2015-01-14 06:39:13 +0000
+++ tests/unit-tests/logging/test_legacy_input_report.cpp	2015-01-29 03:32:23 +0000
@@ -17,7 +17,7 @@
  */
 
 #include "mir/report/legacy_input_report.h"
-#include "mir/logging/logger.h"
+#include "mir_test_doubles/mock_logger.h"
 
 #include <std/Log.h>
 
@@ -33,16 +33,9 @@
 
 namespace
 {
-class MockLogger : public ml::Logger
-{
-public:
-    MOCK_METHOD3(log, void(ml::Severity severity, const std::string& message, const std::string& component));
-    ~MockLogger() noexcept(true) {}
-};
-
 struct InputReport : public testing::Test
 {
-    MockLogger     logger;
+    mir::test::doubles::MockLogger logger;
 
     InputReport()
     {