Code review comment for lp:~vanvugt/mir/graphics-abi-is-not-libmirplatform-abi
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Indeed abigail or whatever will provide the final word, but this proposal shouldn't break the ABI if it's just removing non-existent symbols.
In fact if you break the symbols in question then you're actually breaking the graphics platform ABI, which is not the libmirplatform ABI. So it's unreasonably misleading to put those non-existent symbols in the map. If you break the symbols then you're not actually breaking the libmircommon ABI but are breaking the graphics ABI.