Merge lp:~vanvugt/mir/graphics-abi-is-not-libmirplatform-abi into lp:mir

[Daniel van Vugt]

src/platform/symbols.map: Remove a bunch of non-existent symbols

While they may indeed name some interfaces that affect the graphics platform ABI, those symbols do not exist in the libmirplatform binary so need not be listed for export.

[Mir CI Bot (mir-ci-bot)]

FAILED: Continuous integration, rev:4006
https://mir-jenkins.ubuntu.com/job/mir-ci/2906/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3838/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3917
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3907
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3907
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3907
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3865
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3865/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3865/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3865
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3865/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3865
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3865/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3865
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3865/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3865
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3865/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2906/rebuild

review: Needs Fixing (continuous-integration)

[Daniel van Vugt (vanvugt)]

^^^
Bug 1646558

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:4007
https://mir-jenkins.ubuntu.com/job/mir-ci/2910/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3842
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3921
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3911
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3911
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3911
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3869/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3869/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3869/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3869/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3869/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3869
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3869/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2910/rebuild

review: Approve (continuous-integration)

[Chris Halse Rogers (raof)]

Hm. At least some of these *should* appear in libmirplatform; most of the Renderable ones, some of the Buffer ones, CursorImage, GLConfig. These are symbols a platform will require in order to work.

If they're not exported from libmirplatform, then they should be (and this is what should be fixed).

review: Disapprove

[Daniel van Vugt (vanvugt)]

They're virtual functions. So if they don't exist in binary yet that's probably because they haven't been used, internally(?). Can we force their creation? Should we?

[Daniel van Vugt (vanvugt)]

Actually they're pure virtual functions of pure visual base classes. Would they ever get symbols emitted that we can export?

[Chris Halse Rogers (raof)]

Hmm. I actually don't know - it's conceivable that they would be real symbols under *some* ABI. There's no particular reason why they shouldn't have real code associated with them.

I think the Linux x64 C++ ABI just hardcodes posts offsets into the vtable, so having the vtable symbols published should be enough.

Hopefully abigail can detect when we change those...

[Daniel van Vugt (vanvugt)]

Indeed abigail or whatever will provide the final word, but this proposal shouldn't break the ABI if it's just removing non-existent symbols.

In fact if you break the symbols in question then you're actually breaking the graphics platform ABI, which is not the libmirplatform ABI. So it's unreasonably misleading to put those non-existent symbols in the map. If you break the symbols then you're not actually breaking the libmircommon ABI but are breaking the graphics ABI.

[Daniel van Vugt (vanvugt)]

* If you break the symbols then you're not actually breaking the libmirplatform ABI but are breaking the graphics ABI.

[Chris Halse Rogers (raof)]

Hm, so I think that at least:

- vtable?for?mir::graphics::CursorImage;
- vtable?for?mir::graphics::GLConfig;
- vtable?for?mir::graphics::Renderable;

should be exported by libmirplatform, as those are types that the platforms need the vtables for in order to function.

Dunno about the typeinfo, and the rest of the vtables.

review: Needs Information

[Daniel van Vugt (vanvugt)]

It appears the rule is that those symbols won't exist (never emitted by the compiler) unless a class has one or more non-virtual non-default methods. Any pure virtual class (which may have some defaulted methods) will have no symbols emitted by the compiler, and don't need mentioning in symbols.map.

Certainly it's probably better maintenance practice going forward if we just add individual symbols as required (indicated by linker errors) rather than scripting the insertion of symbols that don't exist in binary. Otherwise we find ourselves in a situation I'm in now where I'm breaking a symbol that's in symbols.map, but doesn't actually exist in binary so it's no ABI break.

[Mir CI Bot (mir-ci-bot)]

FAILED: Continuous integration, rev:4009
https://mir-jenkins.ubuntu.com/job/mir-ci/2947/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3905/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3991
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3981
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3981
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3981
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3932/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3932
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3932/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3932
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3932/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3932
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3932/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3932
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3932/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3932
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3932/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2947/rebuild

review: Needs Fixing (continuous-integration)

[Daniel van Vugt (vanvugt)]

^^^
Bug 1646558

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:4010
https://mir-jenkins.ubuntu.com/job/mir-ci/2949/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3907
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3993
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3983
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3983
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3983
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3934/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3934/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3934/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3934/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3934/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3934
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3934/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2949/rebuild

review: Approve (continuous-integration)

[Cemil Azizoglu (cemil-azizoglu)]

I'm fine with that.

review: Approve

[Mir CI Bot (mir-ci-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/1091/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3961/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1152/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4047
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4037
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4037
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4037
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3988/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3988
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3988/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3988/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3988
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3988/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3988
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3988/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3988
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3988/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)

[Daniel van Vugt (vanvugt)]

^^^
Network failures from yesterday. Hopefully now fixed.

[Mir CI Bot (mir-ci-bot)]

review: Approve (continuous-integration)

=== modified file 'src/platform/symbols.map'
--- src/platform/symbols.map	2017-01-18 02:29:37 +0000
+++ src/platform/symbols.map	2017-02-07 09:21:17 +0000
@@ -5,33 +5,6 @@
 # ../tools/process_doxygen_xml.py doc/xml/*.xml | grep "^mirplatform public" | sed "s/mirplatform public: /    /" | sort  
     mir::graphics::BufferBasic::BufferBasic*;
     mir::graphics::Buffer::Buffer*;
-    mir::graphics::Buffer::id*;
-    mir::graphics::Buffer::native_buffer_base*;
-    mir::graphics::Buffer::native_buffer_handle*;
-    mir::graphics::Buffer::pixel_format*;
-    mir::graphics::Buffer::size*;
-    mir::graphics::Cursor::?Cursor*;
-    mir::graphics::Cursor::Cursor*;
-    mir::graphics::Cursor::hide*;
-    mir::graphics::CursorImage::as_argb_8888*;
-    mir::graphics::CursorImage::?CursorImage*;
-    mir::graphics::CursorImage::CursorImage*;
-    mir::graphics::CursorImage::hotspot*;
-    mir::graphics::CursorImage::operator*;
-    mir::graphics::CursorImage::size*;
-    mir::graphics::Cursor::move_to*;
-    mir::graphics::Cursor::operator*;
-    mir::graphics::Cursor::show*;
-    mir::graphics::DisplayBuffer::DisplayBuffer*;
-    mir::graphics::DisplayBuffer::native_display_buffer*;
-    mir::graphics::DisplayBuffer::operator*;
-    mir::graphics::DisplayBuffer::orientation*;
-    mir::graphics::DisplayBuffer::overlay*;
-    mir::graphics::DisplayBuffer::view_area*;
-    mir::graphics::Display::configuration*;
-    mir::graphics::DisplayConfiguration::DisplayConfiguration*;
-    mir::graphics::DisplayConfiguration::for_each_card*;
-    mir::graphics::DisplayConfiguration::for_each_output*;
     mir::graphics::DisplayConfiguration::operator*;
     mir::graphics::DisplayConfigurationOutput::extents*;
     mir::graphics::DisplayConfigurationOutput::valid*;
@@ -40,16 +13,6 @@
     mir::graphics::DisplayConfigurationPolicy::DisplayConfigurationPolicy*;
     mir::graphics::DisplayConfigurationPolicy::operator*;
     mir::graphics::DisplayConfiguration::valid*;
-    mir::graphics::Display::configure*;
-    mir::graphics::Display::create_gl_context*;
-    mir::graphics::Display::create_hardware_cursor*;
-    mir::graphics::Display::Display*;
-    mir::graphics::Display::for_each_display_buffer*;
-    mir::graphics::Display::native_display*;
-    mir::graphics::Display::pause*;
-    mir::graphics::Display::register_configuration_change_handler*;
-    mir::graphics::Display::register_pause_resume_handlers*;
-    mir::graphics::Display::resume*;
     mir::graphics::EventHandlerRegister::?EventHandlerRegister*;
     mir::graphics::EventHandlerRegister::EventHandlerRegister*;
     mir::graphics::EventHandlerRegister::operator*;
@@ -57,41 +20,9 @@
     mir::graphics::EventHandlerRegister::register_signal_handler*;
     mir::graphics::EventHandlerRegister::unregister_fd_handler*;
     mir::graphics::GammaCurves::GammaCurves*;
-    mir::graphics::GLConfig::depth_buffer_bits*;
-    mir::graphics::GLConfig::?GLConfig*;
-    mir::graphics::GLConfig::GLConfig*;
-    mir::graphics::GLConfig::operator*;
-    mir::graphics::GLConfig::stencil_buffer_bits*;
-    mir::graphics::GraphicBufferAllocator::alloc_buffer*;
-    mir::graphics::GraphicBufferAllocator::?GraphicBufferAllocator*;
-    mir::graphics::GraphicBufferAllocator::GraphicBufferAllocator*;
-    mir::graphics::GraphicBufferAllocator::operator*;
-    mir::graphics::GraphicBufferAllocator::supported_pixel_formats*;
     mir::graphics::LinearGammaLUTs::LinearGammaLUTs*;
     mir::graphics::module_for_device*;
     mir::graphics::operator*;
-    mir::graphics::Platform::create_buffer_allocator*;
-    mir::graphics::Platform::create_display*;
-    mir::graphics::PlatformIpcOperations::connection_ipc_package*;
-    mir::graphics::PlatformIpcOperations::operator*;
-    mir::graphics::PlatformIpcOperations::pack_buffer*;
-    mir::graphics::PlatformIpcOperations::?PlatformIpcOperations*;
-    mir::graphics::PlatformIpcOperations::PlatformIpcOperations*;
-    mir::graphics::PlatformIpcOperations::unpack_buffer*;
-    mir::graphics::Platform::make_ipc_operations*;
-    mir::graphics::Platform::operator*;
-    mir::graphics::Platform::Platform*;
-    mir::graphics::Renderable::alpha*;
-    mir::graphics::Renderable::buffer*;
-    mir::graphics::Renderable::buffers_ready_for_compositor*;
-    mir::graphics::Renderable::id*;
-    mir::graphics::Renderable::operator*;
-    mir::graphics::Renderable::?Renderable*;
-    mir::graphics::Renderable::Renderable*;
-    mir::graphics::Renderable::screen_position*;
-    mir::graphics::Renderable::shaped*;
-    mir::graphics::Renderable::transformation*;
-    mir::graphics::Renderable::swap_interval*;
     mir::graphics::UserDisplayConfigurationOutput::extents*;
     mir::graphics::UserDisplayConfigurationOutput::UserDisplayConfigurationOutput*;
     mir::options::arw_server_socket_opt*;
@@ -154,72 +85,18 @@
     mir::options::shared_library_prober_report_opt*;
     mir::options::shell_report_opt;
     mir::options::touchspots_opt*;
-    non-virtual?thunk?to?mir::graphics::Cursor::?Cursor*;
-    non-virtual?thunk?to?mir::graphics::CursorImage::?CursorImage*;
-    non-virtual?thunk?to?mir::graphics::DisplayConfigurationPolicy::?DisplayConfigurationPolicy*;
-    non-virtual?thunk?to?mir::graphics::DisplayConfiguration::valid*;
-    non-virtual?thunk?to?mir::graphics::EventHandlerRegister::?EventHandlerRegister*;
-    non-virtual?thunk?to?mir::graphics::GLConfig::?GLConfig*;
-    non-virtual?thunk?to?mir::graphics::GraphicBufferAllocator::?GraphicBufferAllocator*;
-    non-virtual?thunk?to?mir::graphics::PlatformIpcOperations::?PlatformIpcOperations*;
-    non-virtual?thunk?to?mir::graphics::Renderable::?Renderable*;
-    non-virtual?thunk?to?mir::options::Configuration::?Configuration*;
-    non-virtual?thunk?to?mir::options::DefaultConfiguration::?DefaultConfiguration*;
-    non-virtual?thunk?to?mir::options::DefaultConfiguration::parse_arguments*;
-    non-virtual?thunk?to?mir::options::DefaultConfiguration::parse_config_file*;
-    non-virtual?thunk?to?mir::options::DefaultConfiguration::parse_environment*;
-    non-virtual?thunk?to?mir::options::DefaultConfiguration::the_options*;
-    non-virtual?thunk?to?mir::options::Option::?Option*;
-    non-virtual?thunk?to?mir::options::ProgramOption::get*;
-    non-virtual?thunk?to?mir::options::ProgramOption::is_set*;
     typeinfo?for?mir::AbnormalExit;
-    typeinfo?for?mir::FatalErrorStrategy;
     typeinfo?for?mir::graphics::Buffer;
     typeinfo?for?mir::graphics::BufferBasic;
-    typeinfo?for?mir::graphics::BufferProperties;
-    typeinfo?for?mir::graphics::Cursor;
-    typeinfo?for?mir::graphics::CursorImage;
-    typeinfo?for?mir::graphics::Display;
-    typeinfo?for?mir::graphics::DisplayBuffer;
     typeinfo?for?mir::graphics::DisplayConfiguration;
-    typeinfo?for?mir::graphics::DisplayConfigurationCard;
-    typeinfo?for?mir::graphics::DisplayConfigurationMode;
-    typeinfo?for?mir::graphics::DisplayConfigurationOutput;
-    typeinfo?for?mir::graphics::DisplayConfigurationPolicy;
-    typeinfo?for?mir::graphics::EventHandlerRegister;
-    typeinfo?for?mir::graphics::GLConfig;
-    typeinfo?for?mir::graphics::GraphicBufferAllocator;
-    typeinfo?for?mir::graphics::Platform;
-    typeinfo?for?mir::graphics::PlatformIpcOperations;
-    typeinfo?for?mir::graphics::PlatformIPCPackage;
-    typeinfo?for?mir::graphics::Renderable;
-    typeinfo?for?mir::graphics::UserDisplayConfigurationOutput;
     typeinfo?for?mir::options::Configuration;
     typeinfo?for?mir::options::DefaultConfiguration;
     typeinfo?for?mir::options::Option;
     typeinfo?for?mir::options::ProgramOption;
     vtable?for?mir::AbnormalExit;
-    vtable?for?mir::FatalErrorStrategy;
     vtable?for?mir::graphics::Buffer;
     vtable?for?mir::graphics::BufferBasic;
-    vtable?for?mir::graphics::BufferProperties;
-    vtable?for?mir::graphics::Cursor;
-    vtable?for?mir::graphics::CursorImage;
-    vtable?for?mir::graphics::Display;
-    vtable?for?mir::graphics::DisplayBuffer;
     vtable?for?mir::graphics::DisplayConfiguration;
-    vtable?for?mir::graphics::DisplayConfigurationCard;
-    vtable?for?mir::graphics::DisplayConfigurationMode;
-    vtable?for?mir::graphics::DisplayConfigurationOutput;
-    vtable?for?mir::graphics::DisplayConfigurationPolicy;
-    vtable?for?mir::graphics::EventHandlerRegister;
-    vtable?for?mir::graphics::GLConfig;
-    vtable?for?mir::graphics::GraphicBufferAllocator;
-    vtable?for?mir::graphics::Platform;
-    vtable?for?mir::graphics::PlatformIpcOperations;
-    vtable?for?mir::graphics::PlatformIPCPackage;
-    vtable?for?mir::graphics::Renderable;
-    vtable?for?mir::graphics::UserDisplayConfigurationOutput;
     vtable?for?mir::options::Configuration;
     vtable?for?mir::options::DefaultConfiguration;
     vtable?for?mir::options::Option;