Merge lp:~vanvugt/compiz/fix-1049100 into lp:compiz/0.9.8

Proposed by Daniel van Vugt
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3369
Merged at revision: 3369
Proposed branch: lp:~vanvugt/compiz/fix-1049100
Merge into: lp:compiz/0.9.8
Diff against target: 31 lines (+7/-3)
2 files modified
cmake/CompizCommon.cmake (+6/-2)
cmake/CompizPackage.cmake (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/compiz/fix-1049100
Reviewer Review Type Date Requested Status
jenkins (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+123922@code.launchpad.net

Commit message

Don't ever enter the subdir of a plugin that is disabled. (LP: #1049100)

Description of the change

Don't ever enter the subdir of a plugin that is disabled. (LP: #1049100)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This will fix the bug for the lp:compiz case but won't work for plugins that compile standalone.

Then again, there's not a lot of point in having a standalone plugin you can disable. So +1 from me.

review: Approve
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cmake/CompizCommon.cmake'
--- cmake/CompizCommon.cmake 2012-09-03 07:19:30 +0000
+++ cmake/CompizCommon.cmake 2012-09-12 10:22:21 +0000
@@ -443,8 +443,12 @@
443 )443 )
444444
445 foreach (_plugin ${_plugins_in})445 foreach (_plugin ${_plugins_in})
446 get_filename_component (_plugin_dir ${_plugin} PATH)446 get_filename_component (_plugin_dir ${_plugin} PATH)
447 add_subdirectory (${folder}/${_plugin_dir})447 string (TOUPPER ${_plugin_dir} _plugin_upper)
448 if (NOT COMPIZ_DISABLE_PLUGIN_${_plugin_upper})
449 add_subdirectory (${folder}/${_plugin_dir})
450 set (COMPIZ_ENABLED_PLUGIN_${_plugin_upper} Y CACHE INTERNAL "")
451 endif ()
448 endforeach ()452 endforeach ()
449endmacro ()453endmacro ()
450454
451455
=== modified file 'cmake/CompizPackage.cmake'
--- cmake/CompizPackage.cmake 2010-05-17 18:18:56 +0000
+++ cmake/CompizPackage.cmake 2012-09-12 10:22:21 +0000
@@ -67,7 +67,7 @@
67 string (TOUPPER ${_plugin_name} _PLUGIN)67 string (TOUPPER ${_plugin_name} _PLUGIN)
68 compiz_format_string (${_plugin_name} 14 _plugin_name)68 compiz_format_string (${_plugin_name} 14 _plugin_name)
6969
70 if (COMPIZ_DISABLE_PLUGIN_${_PLUGIN})70 if (NOT COMPIZ_ENABLED_PLUGIN_${_PLUGIN})
71 compiz_color_message (" ${_plugin_name}: ${_escape}[1;34mDisabled${_escape}[0m")71 compiz_color_message (" ${_plugin_name}: ${_escape}[1;34mDisabled${_escape}[0m")
72 else ()72 else ()
73 if (COMPIZ_${_PLUGIN}_BUILD)73 if (COMPIZ_${_PLUGIN}_BUILD)

Subscribers

People subscribed via source and target branches