Code review comment for ~utkarsh/ubuntu/+source/multipath-tools:merge-multipath-tools-impish

I'm seeing debian/patches/newer-jsonc.patch removed when diffing from old/ubuntu to both your "split" and "logical" tags, which I'm not expecting. Did you intend to have fixed that since we discussed it? I understand what's going on so I can just ignore it, but it mismatches the workflow in case you were expecting something different.

Have you looked into upstreaming any of this? Whether to Debian or directly to upstream. Some of the changes at least don't look specific to Ubuntu. Looking into the history, I found https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/multipath-tools/+git/multipath-tools/+merge/387017/comments/1016743 which suggests that upstreaming is appropriate now. Is there a reason not to attempt this in this package merge?

The actual only Debian change (fix bashism) isn't really going to make a functional difference to us in Ubuntu, so it seems to me that the value in merging this would be in cleaning up and minimising the delta, rather than just transferring it over. Could you make sure to understand the delta, please, and based on that understanding, where appropriate set the gears in motion to have that delta upstreamed? I appreciate this is probably quite a lot of work given the current delta, and that you'll probably need to consult some of the people who added individual bits of delta. Given we are early in the cycle, it's probably worth taking an initial pass at this at least. It might be worth checking with colleagues more familiar with the package to see if they concur.

It may be the case that with bullseye being in freeze, the actual merge result is the same even after "upstreaming" because none of it will be able to be accepted yet. In that case I suppose I'm just asking for upstreaming status to be trackable from our delta.