Merge ~utkarsh/ubuntu/+source/isc-dhcp:isc-dhcp-lp1894172-interfaces-env into ubuntu/+source/isc-dhcp:ubuntu/devel
Proposed by
Utkarsh Gupta
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | d0a11aa589a16bd22fecd7ee95c4dc05c69419f3 | ||||
Proposed branch: | ~utkarsh/ubuntu/+source/isc-dhcp:isc-dhcp-lp1894172-interfaces-env | ||||
Merge into: | ubuntu/+source/isc-dhcp:ubuntu/devel | ||||
Diff against target: |
43 lines (+11/-2) 3 files modified
debian/changelog (+9/-0) debian/isc-dhcp-server.isc-dhcp-server.service (+1/-1) debian/isc-dhcp-server.isc-dhcp-server6.service (+1/-1) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Durigan Junior (community) | Approve | ||
Canonical Server | Pending | ||
git-ubuntu developers | Pending | ||
Review via email: mp+398790@code.launchpad.net |
Description of the change
This MR fixes env variable for INTERFACES (LP: #1894172).
PPA: https:/
Unfortunately there weren't tests in this package but the change is trivial and I've done a manual test of this.
Should you need any more details, let me know.
Requesting you to please review, upload, and push the tag. TIA!
To post a comment you must log in.
Thanks, the patch LGTM, so I'm approving this MP.
A comment about git tags: you should not create the upload tag yourself, since you're not going to do the upload. It's the uploader's job to create and push the upload tag (just like we do when we're asking for sponsorship in Debian). Also, even if you could do the upload yourself, it is not a good idea to create the tag before the MP has been reviewed and approved, since you might need to make changes to the branch and force-push things. A good thing here is that the tags you created are under the "utkarsh/" namespace, so they don't conflict with the git-ubuntu tag.
A last comment is that you shouldn't create a "debian/xxyyzz" tag. When using git-ubuntu, we just have to create the "upload/xxyyzz" tag (which is done by running "git ubuntu tag --upload").
About the PPA: we usually upload using the "~ppa1" suffix, which helps to "version" the PPA uploads and makes it easier to deal with multiple uploads of the same package.
Having said all that, I uploaded and pushed the tag:
$ git push pkg upload/ 4.4.1-2. 2ubuntu5 launchpad. net/ubuntu/ +source/ isc-dhcp 4.4.1-2. 2ubuntu5 -> upload/ 4.4.1-2. 2ubuntu5
Enumerating objects: 15, done.
Counting objects: 100% (15/15), done.
Delta compression using up to 8 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.29 KiB | 331.00 KiB/s, done.
Total 10 (delta 7), reused 0 (delta 0)
To ssh://git.
* [new tag] upload/
$ dput isc-dhcp_ 4.4.1-2. 2ubuntu5_ source. changes work/isc- dhcp/isc- dhcp_4. 4.1-2.2ubuntu5_ source. changes: Valid signature from 106DA1C8C3CBBF14 work/isc- dhcp/isc- dhcp_4. 4.1-2.2ubuntu5. dsc: Valid signature from 106DA1C8C3CBBF14 4.4.1-2. 2ubuntu5. dsc: done. 4.4.1-2. 2ubuntu5. debian. tar.xz: done. 4.4.1-2. 2ubuntu5_ source. buildinfo: done. 4.4.1-2. 2ubuntu5_ source. changes: done.
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/
Checking signature on .dsc
gpg: /home/sergio/
Uploading to ubuntu (via ftp to upload.ubuntu.com):
Uploading isc-dhcp_
Uploading isc-dhcp_
Uploading isc-dhcp_
Uploading isc-dhcp_
Successfully uploaded packages.