Code review comment for ~utkarsh/ubuntu/+source/isc-dhcp:isc-dhcp-lp1894172-interfaces-env

Hi Sergio,

> Thanks, the patch LGTM, so I'm approving this MP.

Thank you!

> A comment about git tags: you should not create the upload tag yourself,
> since you're not going > to do the upload. It's the uploader's job to
> create and push the upload tag (just like we do when we're asking for
> sponsorship in Debian). Also, even if you could do the upload yourself,
> it is not a good idea to create the tag before the MP has been reviewed
> and approved, since you might need to make changes to the branch and
> force-push things. A good thing here is that the tags you created are
> under the "utkarsh/" namespace, so they don't conflict with the git-ubuntu tag.

Aah, okay. Duly noted, thanks!

> A last comment is that you shouldn't create a "debian/xxyyzz" tag.
> When using git-ubuntu, we just have to create the "upload/xxyyzz" tag
> (which is done by running "git ubuntu tag --upload").

Gotcha! I didn't know this previously, so a nice learning point.

> About the PPA: we usually upload using the "~ppa1" suffix, which
> helps to "version" the PPA uploads and makes it easier to deal with
> multiple uploads of the same package.

Eeks, my bad. Thanks for bringing this up. The only bad side I guess is
that I need to build it again (with different version string) for PPA,
but that's okay, I guess?

> Having said all that, I uploaded and pushed the tag: (...)

Super awesome, thanks for such a careful and a helpful assist! \o/