Code review comment for ~utkarsh/ubuntu/+source/at:lp1677748-add-dep8-tests

Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hi Bryce,

Thanks for the great review. I've adjusted the MP according to the suggestions proposed. The only bit remaining is "skipping error checking in favor of set -ex". I'd personally like explicit checks (as do you) because it really helps in debugging and reading through as to what it was supposed to do v/s what's happening.

Whilst this is a trivial test and it's easier to figure out this but in more complex cases, I'd personally use them to be explicitly explicit.

I'm OK in removing those as well if that's still preferable and if you'd like me to do so. Please let me know! \o/

« Back to merge proposal