Merge ~utkarsh/ubuntu/+source/at:lp1677748-add-dep8-tests into ubuntu/+source/at:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Bryce Harrington | ||||
Approved revision: | 2d3edc970a8cd5d44eef23a87d95539c7bedd9cd | ||||
Merged at revision: | 2d3edc970a8cd5d44eef23a87d95539c7bedd9cd | ||||
Proposed branch: | ~utkarsh/ubuntu/+source/at:lp1677748-add-dep8-tests | ||||
Merge into: | ubuntu/+source/at:ubuntu/devel | ||||
Diff against target: |
91 lines (+71/-0) 3 files modified
debian/changelog (+7/-0) debian/tests/basic-usage (+61/-0) debian/tests/control (+3/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server | Pending | ||
Canonical Server packageset reviewers | Pending | ||
Review via email: mp+399718@code.launchpad.net |
Description of the change
Hello,
This MP adds a DEP8 test for the at package, using and for at and atq functionalities.
This is a trivial but good test to catch regressions, if there's any. I also intend to send this to Debian hopefully after this is merged here and uploaded.
PPA at https:/
Autopkgtest is clean and happy as well:
```
autopkgtest [02:20:37]: test basic-usage: -------
autopkgtest [02:20:37]: test basic-usage: - - - - - - - - - - results - - - - - - - - - -
basic-usage PASS
autopkgtest [02:20:38]: @@@@@@@
```
Requesting y'all to please review and sponsor the upload. TIA!
* Changelog:
- [-] old content and logical tag match as expected
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [-] update-maintainer has been run
* Actual changes:
- [-] no upstream changes to consider
- [-] no further upstream version to consider
- [√] debian changes look safe
* Old Delta:
- [-] dropped changes are ok to be dropped
- [-] nothing else to drop
- [√] changes forwarded upstream/debian (if appropriate)
+ (Yes, mp indicates will be forwarded subsequently)
* New Delta: patches/ series
- [√] no new patches added
- [-] patches match what was proposed upstream
- [-] patches correctly included in debian/
- [-] patches have correct DEP3 metadata
* Build/Test:
- [√] build is ok
- [√] verified PPA package installs/uninstalls
- [√] autopkgtest against the PPA package passes
- [√] sanity checks test fine
Some review comments inline below. Most are suggestions and you can take or not as you wish, the only actual coding error is the '-eq' -> '=' one.
DEP8 passes for autopkgtest when run with an ephemeral container, however I did find a situation where it will fail to pass (see below).