Code review comment for lp:~uros-jovanovic/charms/trusty/juju-gui/hackingreview

Revision history for this message
Richard Harding (rharding) wrote :

Couple of comments, will let Jay do the final looks good approval based
on successful lxc and ec2 test runs.

https://codereview.appspot.com/113720043/diff/20001/HACKING.md
File HACKING.md (right):

https://codereview.appspot.com/113720043/diff/20001/HACKING.md#newcode107
HACKING.md:107: make ftest JUJU_ENV="myenv" JUJU_ENV_TYPE="local"
The doc is about colocation. Should this be a COLO=false flag instead?

https://codereview.appspot.com/113720043/diff/20001/Makefile
File Makefile (right):

https://codereview.appspot.com/113720043/diff/20001/Makefile#newcode20
Makefile:20: rsync xvfb firefox charm-tools
why is firefox the requirement? Are we not able to assume a browser and
let the dev select?

https://codereview.appspot.com/113720043/

« Back to merge proposal