Merge lp:~uros-jovanovic/charms/trusty/juju-gui/hackingreview into lp:~juju-gui/charms/trusty/juju-gui/trunk
Proposed by
Uros Jovanovic
Status: | Merged |
---|---|
Merged at revision: | 187 |
Proposed branch: | lp:~uros-jovanovic/charms/trusty/juju-gui/hackingreview |
Merge into: | lp:~juju-gui/charms/trusty/juju-gui/trunk |
Diff against target: |
102 lines (+30/-8) 4 files modified
HACKING.md (+17/-4) Makefile (+1/-2) tests/20-functional.test (+12/-1) tests/deploy.py (+0/-1) |
To merge this branch: | bzr merge lp:~uros-jovanovic/charms/trusty/juju-gui/hackingreview |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju GUI Hackers | Pending | ||
Review via email: mp+226270@code.launchpad.net |
Description of the change
enables ftests on local env
Create local environment (with "local" also being the name of that environment) and ftests can be now be run local as well.
To post a comment you must log in.
Reviewers: mp+226270_ code.launchpad. net,
Message:
Please take a look.
Description:
minor change in hacking.md
https:/ /code.launchpad .net/~uros- jovanovic/ charms/ trusty/ juju-gui/ hackingreview/ +merge/ 226270
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/113720043/
Affected files (+12, -6 lines): functional. test
M HACKING.md
A [revision details]
M tests/20-
M tests/deploy.py
Index: HACKING.md lib/juju/ units/[ NAME OF UNIT]`. There is a charm.log file to lib/juju/ agents/ [NAME OF UNIT]` (or instead of agents use
=== modified file 'HACKING.md'
--- HACKING.md 2014-04-22 10:28:39 +0000
+++ HACKING.md 2014-07-10 10:24:19 +0000
@@ -140,10 +140,10 @@
When something goes wrong, on your local machine run
`juju debug-hooks juju-gui/0` or similar. This will initially put you on
the
unit that has the problem. You can look at what is going on in
-`/var/
-investigate, and a charm directory which contains the charm. The charm
-directory contains the `juju-gui` and `juju` directories, so everything you
-need is there.
+`/var/
`containers`
+in the local environment. There is a charm.log file to investigate, and a
+charm directory which contains the charm. The charm directory contains the
+`juju-gui` and `juju` directories, so everything you need is there.
If juju recognized an error (for instance, the unit is in
an "install-error"
state) then you can do more. In another terminal on your local machine,
run
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: tests/20- functional. test 20-functional. test' functional. test 2014-04-14 17:00:09 +0000 functional. test 2014-07-10 11:53:35 +0000
=== modified file 'tests/
--- tests/20-
+++ tests/20-
@@ -23,6 +23,7 @@
import unittest
import urllib2
import urlparse
+import os
from selenium.webdriver import Firefox webdriver. support import ui node_series = juju_status( )['machines' ]['0'][ 'series' ]
from selenium.
@@ -50,6 +51,10 @@
print(err)
bootstrap_
+forced_machine = 0 'JUJU_ENV' )
+env_par = os.getenv(
+if env_par == "local":
+ forced_machine = None
def juju_deploy_ gui(options= None): name(prefix= 'juju-gui- ')
'juju- gui', service_ name=service_ name, options=options, bootstrap_ node_series) forced_ machine, series= bootstrap_ node_series)
"""Deploy the Juju GUI charm with the given options.
@@ -62,7 +67,7 @@
service_name = make_service_
unit_info = juju_deploy(
- force_machine=0, series=
+ force_machine=
return service_name, unit_info
Index: tests/deploy.py for_unit,
=== modified file 'tests/deploy.py'
--- tests/deploy.py 2014-04-22 09:27:01 +0000
+++ tests/deploy.py 2014-07-10 11:53:35 +0000
@@ -32,7 +32,6 @@
wait_
)
-
'-- exclude' , '.git',
'-- exclude' , '.bzr',
rsync = command('rsync', '-a',