That looks all good now.
I have only one minor concern: in TestSuggestions.setUp(), you’re assigning to self.server, which is later overridden when calling the parent’s setUp(). I understand you’re doing that because the the ping_server() method relies on self.server, but I think this is confusing and makes the code harder to maintain in the long run. Can you modify ping_server() to take the server object as parameter, and assign the search suggestions server instance to a different member variable?
That looks all good now. .setUp( ), you’re assigning to self.server, which is later overridden when calling the parent’s setUp(). I understand you’re doing that because the the ping_server() method relies on self.server, but I think this is confusing and makes the code harder to maintain in the long run. Can you modify ping_server() to take the server object as parameter, and assign the search suggestions server instance to a different member variable?
I have only one minor concern: in TestSuggestions