lp:~uriboni/webbrowser-app/search-suggestions

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:webbrowser-app at revision 1006

Olivier Tilloy: Approve on 2015-05-12

PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-05-12

Diff: 659 lines (+272/-54)

11 files modified

CMakeLists.txt (+2/-0)
src/app/config.h.in (+5/-0)
src/app/webbrowser/Browser.qml (+26/-5)
src/app/webbrowser/SearchSuggestions.qml (+78/-0)
src/app/webbrowser/Suggestion.qml (+5/-2)
src/app/webbrowser/Suggestions.qml (+22/-11)
src/app/webbrowser/searchengine.cpp (+13/-1)
src/app/webbrowser/searchengine.h (+4/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+6/-6)
tests/autopilot/webbrowser_app/tests/http_server.py (+14/-1)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+97/-28)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1351151: [browser] Implement auto-suggest for the address bar

High

Fix Released

Link a bug report

Related blueprints

995. By Ugo Riboni on 2015-05-12

Better names

994. By Ugo Riboni on 2015-05-12

Do the same in the package main

993. By Ugo Riboni on 2015-05-12

More safely store the server in an instance variable

992. By Ugo Riboni on 2015-05-12

Keep the server in a temporary variable, instead of in the test instance

991. By Ugo Riboni on 2015-05-12

Add project name in main cmake file, for convenience in qtcreator

990. By Ugo Riboni on 2015-05-12

Remove unnecessary sleep

989. By Ugo Riboni on 2015-05-12

Implement suggestions from code review

988. By Ugo Riboni on 2015-05-12

Create a new "active" property instead of overriding the Item.enabled property which might have side effects. Always abort the request when resetting.

987. By Ugo Riboni on 2015-05-12

More fixes due to temp locations support

986. By Ugo Riboni on 2015-05-12

Merge new prerequisite branch to create separate temp dir for ~/.config