Code review comment for lp:~uriboni/webbrowser-app/search-suggestions

Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m seeing one funny behaviour: I’m adding a custom search engine definition (https://duckduckgo.com/opensearch.xml) and making it the default search engine, but the suggestions URL doesn’t seem to be used, instead the default suggestions from Google are used.

There are two things to fix here:
 - that XML description file seems to have a valid suggestions URL, for some reason it’s not being parsed/used, it should be
 - when loading a valid XML description file that doesn’t have a suggestions URL, we shouldn’t fall back to Google, instead there shouldn’t be any search suggestions

review: Needs Fixing

« Back to merge proposal