Code review comment for lp:~uriboni/webbrowser-app/keyboard-navigation

Revision history for this message
Olivier Tilloy (osomon) wrote :

The flake8 unit test fails.

A few functional issues (I haven’t done a complete review yet):

 - If the address bar is empty and focused (e.g. when opening a new blank tab), pressing the down arrow key removes focus from it, and pressing the up arrow key doesn’t restore it.

 - If I type a word in the address bar and wait for search suggestions to appear, then press the down arrow key to navigate the suggestions list, the search suggestions disappear.

 - If I focus the address bar, then open the drawer menu with the mouse and open the history view from there, it cannot be dismissed with ESC (it works as expected if the address bar wasn’t focused or if the view was opened with Ctrl+H).

review: Needs Fixing

« Back to merge proposal