lp:~uriboni/webbrowser-app/keyboard-navigation

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:webbrowser-app at revision 1063

Olivier Tilloy: Approve on 2015-06-16

PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-06-16

Diff: 1236 lines (+756/-78)

16 files modified

src/app/webbrowser/AddressBar.qml (+16/-8)
src/app/webbrowser/Browser.qml (+213/-21)
src/app/webbrowser/Chrome.qml (+3/-0)
src/app/webbrowser/KeyboardShortcut.qml (+25/-0)
src/app/webbrowser/KeyboardShortcuts.qml (+41/-0)
src/app/webbrowser/Suggestion.qml (+3/-2)
src/app/webbrowser/Suggestions.qml (+40/-38)
src/app/webbrowser/limit-proxy-model.cpp (+16/-0)
src/app/webbrowser/limit-proxy-model.h (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+17/-2)
tests/autopilot/webbrowser_app/tests/__init__.py (+10/-2)
tests/autopilot/webbrowser_app/tests/http_server.py (+4/-0)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+0/-2)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+276/-0)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+68/-3)
tests/unittests/limit-proxy-model/tst_LimitProxyModelTests.cpp (+22/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1287361: [browser] add support for keyboard shortcuts

High

Fix Released

Link a bug report

Related blueprints

1097. By Ugo Riboni on 2015-06-16

Fix flake8

1096. By Ugo Riboni on 2015-06-16

Use testtools.skipIf to skip the entire class of tests if not on desktop

1095. By Ugo Riboni on 2015-06-16

Skip each test on its own since class-level skip does not work due to a bug in autopilot

1094. By Ugo Riboni on 2015-06-16

Remove some checks from failing AP test as they don't belong to this test anyway

1093. By Ugo Riboni on 2015-06-15

style: fix indentation

1092. By Ugo Riboni on 2015-06-15

Group shortcuts that do the same thing near each other in the code

1091. By Ugo Riboni on 2015-06-15

Explicitly default to Qt.NoModifiers

1090. By Ugo Riboni on 2015-06-15

Reset focus to the web view after escaping a view or the address bar. Verify this in AP tests

1089. By Ugo Riboni on 2015-06-15

Fix autopilot test that was testing the wrong thing after commit 1085

1088. By Ugo Riboni on 2015-06-15

Fix typo so that the correct icon is passed when bookmarking a site from the keyboard shortcut