Code review comment for lp:~uriboni/oxide/find-in-page

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks. There's a few stylistic nits (eg, 4-space indents in some places) and some other things (eg, the constructor for OxideQFindController shouldn't be exported). The API looks like it's fine now.

I'm going to approve this though, as I'm currently working on re-architecting oxide::WebView which is probably going to be quite disruptive to this branch - I've already created some merge conflicts with http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1087, which I'll fix up

review: Approve

« Back to merge proposal