lp:~uriboni/oxide/find-in-page

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~oxide-developers/oxide/oxide.trunk at revision 1088

Chris Coulson: Approve on 2015-05-21

Diff: 863 lines (+587/-1)

15 files modified

qt/core/api/oxideqfindcontroller.cc (+97/-0)
qt/core/api/oxideqfindcontroller.h (+71/-0)
qt/core/api/oxideqfindcontroller_p.h (+46/-0)
qt/core/browser/oxide_qt_web_view.cc (+16/-1)
qt/core/browser/oxide_qt_web_view.h (+7/-0)
qt/core/core.gyp (+9/-0)
qt/core/glue/oxide_qt_web_view_proxy.h (+11/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+5/-0)
qt/quick/api/oxideqquickwebview.cc (+7/-0)
qt/quick/api/oxideqquickwebview_p.h (+10/-0)
qt/tests/qmltests/api/tst_WebView_findController.html (+13/-0)
qt/tests/qmltests/api/tst_WebView_findController.qml (+152/-0)
qt/tests/qmltests/api/tst_WebView_findControllerManyResults.html (+9/-0)
shared/browser/oxide_web_view.cc (+102/-0)
shared/browser/oxide_web_view.h (+32/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1312260: [browser] There is no search in page option in webbrowser-app (like ctrl+F)

Medium

Fix Released

Link a bug report

Related blueprints

1074. By Ugo Riboni on 2015-05-20

Move all non-QT code to oxide::WebView

1073. By Ugo Riboni on 2015-05-19

Merge changes from trunk

1072. By Ugo Riboni on 2015-05-19

Refactor all the logic into an OxideQFindController class owned by oxide::qt::WebView. The QML API merely exposes it through the renamed findController property. Address other minor issues from code review.

1071. By Ugo Riboni on 2015-05-14

Merge changes from trunk

1070. By Ugo Riboni on 2015-05-12

Add explanatory comment and fix indentation

1069. By Ugo Riboni on 2015-05-12

Remove useless initialization

1068. By Ugo Riboni on 2015-05-12

Improve some tests

1067. By Ugo Riboni on 2015-05-12

Fix code style (braces, indentation)

1066. By Ugo Riboni on 2015-05-12

Merge changes from trunk

1065. By Ugo Riboni on 2015-05-11

Make findInPage group property constant to prevent non-notifyable property warnings