Code review comment for lp:~urbanape/ubuntu-sso-client/initial-darwin-port

Revision history for this message
Manuel de la Peña (mandel) wrote :

I get a segfault when running the tests on linux:

ubuntuone.devtools.testcases.dbus
  DBusTestCase
    runTest ... [OK]
ubuntu_sso.utils.tests.test_txsecrets
  ItemTestCase
    test_delete ... [OK]
    test_delete_prompt ... [OK]
    test_delete_prompt_dismissed ... [OK]
    test_delete_throws_dbus_error ... [OK]
    test_get_value ... [OK]
    test_get_value_throws_dbus_error ... [OK]
  SecretServiceTestCase
    test_create_collection ... [OK]
    test_create_collection_prompt ... [OK]
    test_create_collection_prompt_dismissed ... [OK]
    test_create_collection_throws_dbus_error ... [OK]
    test_get_collections ... [OK]
    test_get_default_collection_created_if_no_default ... [OK]
    test_get_default_collection_created_if_nonexistent ... [OK]
    test_get_default_collection_honours_default_path ... [OK]
    test_get_default_collection_honours_readalias ... [OK]
    test_get_default_collection_is_unlocked_default_path ... [OK]
    test_get_default_collection_is_unlocked_readalias ... [OK]
    test_get_default_collection_set_as_default_if_nonexistent ... [OK]
    test_open_session ... [OK]
    test_open_session_fails_before_opening_as_failure ... [OK]
    test_open_session_throws_dbus_error_as_failure ... [OK]
    test_prompt_accepted ... [OK]
    test_prompt_dismissed ... [OK]
    test_search_items_merges_unlocked_and_locked_items ... [OK]
    test_search_items_merges_unlocked_locked_and_prompt_items ... [OK]
    test_search_locked_items ... [OK]
    test_search_locked_items_prompts ... [OK]
    test_search_locked_items_prompts_dismissed ... [OK]
    test_search_unlocked_items ... [OK]
ubuntu_sso.utils.tests.test_qtwisted
  QtDeferToThreadTestCase
    test_exceptions_become_failures ... QThread: Destroyed while thread is still running
Segmentation fault (core dumped)

review: Needs Fixing

« Back to merge proposal