lp:~urbanape/ubuntu-sso-client/initial-darwin-port

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:ubuntu-sso-client

Manuel de la Peña (community): Disapprove on 2012-04-30

Diego Sarmentero (community): Needs Fixing on 2012-04-24

Diff: 1544 lines (+766/-429)

23 files modified

data/qt/darwin.qss (+5/-0)
data/qt/resources.qrc (+1/-0)
run-tests (+1/-1)
ubuntu_sso/keyring/__init__.py (+2/-6)
ubuntu_sso/keyring/linux.py (+0/-6)
ubuntu_sso/keyring/pykeyring.py (+2/-3)
ubuntu_sso/keyring/tests/test_pykeyring.py (+8/-9)
ubuntu_sso/main/__init__.py (+27/-1)
ubuntu_sso/main/darwin.py (+110/-0)
ubuntu_sso/main/perspective_broker.py (+352/-0)
ubuntu_sso/main/tests/test_darwin.py (+43/-0)
ubuntu_sso/main/tests/test_windows.py (+3/-1)
ubuntu_sso/main/windows.py (+23/-335)
ubuntu_sso/networkstate/__init__.py (+11/-11)
ubuntu_sso/networkstate/darwin.py (+95/-0)
ubuntu_sso/networkstate/linux.py (+7/-39)
ubuntu_sso/networkstate/networkstates.py (+51/-0)
ubuntu_sso/networkstate/tests/test_linux.py (+9/-10)
ubuntu_sso/qt/__init__.py (+7/-0)
ubuntu_sso/qt/main/__init__.py (+1/-1)
ubuntu_sso/utils/__init__.py (+6/-2)
ubuntu_sso/utils/qtwisted.py (+1/-3)
ubuntu_sso/utils/tests/test_qtwisted.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

964. By Zachery Bir on 2012-04-23

Add a specific darwin.qss, and mediate the proper resource in utils/__init__.py

963. By Zachery Bir on 2012-04-23

Merged diegosarmentero's branch, and changed the flippant comment in qt/__init__.py

962. By Zachery Bir on 2012-04-20

Skip the shared code tests between darwin and windows

961. By Zachery Bir on 2012-04-20

Provide the name here for Windows tests to pass.

960. By Zachery Bir on 2012-04-20

Import these names at the appropriate place

959. By Zachery Bir on 2012-04-20

Flow long lines and import SSO_SERVICE_NAME from the right module

958. By Zachery Bir on 2012-04-20

Clean up unused imports, move a pylint exclusion to the shared code,
and provide docstrings (and abstract out the get_user_id function)

957. By Zachery Bir on 2012-04-20

Move the pylint exclusion

956. By Zachery Bir on 2012-04-20

Clean up long lines and unused imports

955. By Zachery Bir on 2012-04-19

Use the new shared networkstates constants, and trim headers.