Code review comment for lp:~uranium235/pluck-cms/pluck-cms

Revision history for this message
Uranium235 (uranium235) wrote :

I think I fixed most open issues. I tested as good as I could, but it wouldn't hurt if someone else took a look at it.

The SITE_URL constant now actually is the URL (not URI as before) and is used everywhere where links are created to avoid the problem with the seo module enabled that relative links are practically impossible.

New constants SITE_SCHEME and SITE_URI were introduced.

The HOME_PAGE constant now points to the homepage URI, to be RFC compliant when used in redirects.

The theme's CSS may need to use the ".active" class instead of "#active" id when upgrading and using custom themes. But that only affects pages with sub-menus, as I left the id in place in addition to the new class attribute for the actual active page. I adjusted the two packaged theme's CSS accordingly.

One small issue is pending though:
If you name your sub-page "album", "blog" or "blog-category" and enable the seo module, things go havoc. Not sure how to fix this without a re-design or forbidding those names.

review: Needs Resubmitting

« Back to merge proposal