Code review comment for lp:~unity-team/music-app/infographics-translations

Revision history for this message
David Planella (dpm) wrote :

This now looks more inline with the SDK, good work!

Just two comments:
- See inline comment for RTL languages
- I know it's a separate issue that we'll handle separately, but just for the record we should see if we can find a solution or a workaround for supporting plural forms. From my understanding from talking on IRC, the limitation lies in the fact that in theory libusermetrics could be showing floating-point strings, but gettext supports only integers for plural forms.

Approve, but pending the i18n.noop() merge from the SDK upstream

review: Approve

« Back to merge proposal