Ubuntu Music App

Code review comment for lp:~unity-team/music-app/infographics-translations

  1. infographics-translations
  2. Merge into remix
Revision history for this message
Pete Woods (pete-woods) wrote :

Thinking about it more, I don't think we have a choice about changing the format string.

The app is doing translate(prefix + "translatable_string") -> infographics server.

The "translatable_string" gets extracted into the catalogue.

The infographics server then tries to translate translate("prefix+translatable_string"). This won't work for two reasons:
1) The catalogue contains "translatable_string" instead of "prefix+translatable_string"
2) The combined string has already been translated by the music app.

We need to simplify all that and just put a straightforward translatable format string into the catalogue, as I have done in this MR.

« Back to merge proposal