Merge ubuntu-security-tools:allow-skipping-downloaded into ubuntu-security-tools:master

Proposed by Mark Esler
Status: Merged
Merge reported by: Mark Esler
Merged at revision: 1d610a85ad1092a50f9a699cb0d05d9f003c464d
Proposed branch: ubuntu-security-tools:allow-skipping-downloaded
Merge into: ubuntu-security-tools:master
Diff against target: 34 lines (+5/-4)
1 file modified
audits/uaudit (+5/-4)
Reviewer Review Type Date Requested Status
Seth Arnold Approve
Review via email: mp+426983@code.launchpad.net

Commit message

allows previously downloaded packages and adds umt like parameters

To post a comment you must log in.
Revision history for this message
Mark Esler (eslerm) wrote :

If a release is already downloaded `out` will be set to ~`ERROR: Package directory '<package>' exists. Skipping.`

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Oh hey this "skipping" change may make it easier to re-run uaudit when it goes wrong; I've just been removing the whole directory again because I'm very lazy, but this looks even lazier! nice.

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/audits/uaudit b/audits/uaudit
2index 75e9594..0f8eeb5 100755
3--- a/audits/uaudit
4+++ b/audits/uaudit
5@@ -454,8 +454,9 @@ def download(package, release, proposed=False):
6 prog.insert(2, '-p')
7 rc, out = cmd(prog)
8 msg(out)
9- if rc != 0 or "Skipping" in out:
10- error("Problem downloading package")
11+ if rc != 0:
12+ if "Skipping" not in out:
13+ error("Problem downloading package")
14 # This is probably not good enough
15 d = glob.glob(os.path.join(package, release, "%s-*" % package))[0]
16 msg("Unpacked source: %s" % os.path.join(os.getcwd(), d))
17@@ -1013,7 +1014,7 @@ if __name__ == "__main__":
18 default=None,
19 metavar="SBUILD_DEP_RESOLVER",
20 help="specify sbuild-dep-resolver for umt binary to use")
21- parser.add_option("--download-release",
22+ parser.add_option("-r", "--download-release",
23 dest="download_release",
24 default=None,
25 metavar="RELEASE",
26@@ -1028,7 +1029,7 @@ if __name__ == "__main__":
27 default=False,
28 help="build with --force-updates",
29 action='store_true')
30- parser.add_option("--force-build",
31+ parser.add_option("-f", "--force-build",
32 default=False,
33 help="Disable umt checks and force build",
34 action='store_true')

Subscribers

People subscribed via source and target branches