Ubuntu UI Toolkit

Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow

  1. outTheWindow
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> + QObject::connect(UbuntuI18n::instance(this), SIGNAL(domainChanged()),
> + this, SIGNAL(i18nChanged()));
> + QObject::connect(UbuntuI18n::instance(this), SIGNAL(languageChanged()),
> + this, SIGNAL(i18nChanged()));
> I see the newer style connects used further down, why the old style here?

One reason I can see that the new style connect doesn't resolve the situation when the client overrides the i18nChanged signal in JS. For that the meta-method based connect is needed.

« Back to merge proposal