Merge into staging : outTheWindow : Code : Ubuntu UI Toolkit

Reviewer	Review Type	Date Requested	Status
ubuntu-sdk-build-bot	continuous-integration		Approve on 2017-01-13
Zsombor Egri		2016-07-27	Approve on 2017-01-13
Loïc Molinari (community)			Approve on 2016-09-21
Review via email: mp+301278@code.launchpad.net

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-07-27:

#

FAILED: Continuous integration, rev:2041
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/874/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4700/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/874/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-07-27:

#

FAILED: Continuous integration, rev:2041
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1103/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4701/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1103/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-07-27:

#

FAILED: Continuous integration, rev:2041
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/903/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4702/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/903/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-07-27:

#

FAILED: Continuous integration, rev:2041
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1119/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4703/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1119/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-07-27:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/578/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-02

2042. By Cris Dywan on 2016-08-02: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-02:

#

FAILED: Continuous integration, rev:2042
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/894/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4799/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/894/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-02:

#

FAILED: Continuous integration, rev:2042
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1123/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4800/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1123/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-02:

#

FAILED: Continuous integration, rev:2042
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/923/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4801/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/923/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-02:

#

FAILED: Continuous integration, rev:2042
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1139/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4802/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1139/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-02:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/597/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-02:

#

install -m 644 -p /tmp/buildd/ubuntu-ui-toolkit-1.3.2030+16.10.20160726.2/src/Ubuntu/Components/Themes/Ambiance/1.3/HighlightMagnifier.qml /tmp/buildd/ubuntu-ui-toolkit-1.3.2030+16.10.20160726.2/debian/tmp/usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/Themes/Ambiance/1.3/
Aborted (core dumped)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-08

2043. By Cris Dywan on 2016-08-08: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-08:

#

FAILED: Continuous integration, rev:2043
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/921/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4927/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/921/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-08:

#

FAILED: Continuous integration, rev:2043
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1150/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4928/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1150/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-08:

#

FAILED: Continuous integration, rev:2043
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/950/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4929/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/950/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-08:

#

FAILED: Continuous integration, rev:2043
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1166/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4930/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1166/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-08:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/617/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-09:

#

Aborted (core dumped)
Makefile:357: recipe for target '/tmp/buildd/ubuntu-ui-toolkit-1.3.2030+16.10.20160726.2/qml/Ubuntu/Components/Labs/plugins.qmltypes' failed

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-10

2044. By Cris Dywan on 2016-08-10: Pass parent to UbuntuI18n/UCUnits::instance in constructor
2045. By Cris Dywan on 2016-08-10: Add Labs dependency so it's available to AP

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2044
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/936/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4998/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/936/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2044
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/965/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/4999/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/965/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2044
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1181/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5000/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1181/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2044
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1165/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5001/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1165/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/628/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

FAILED: Continuous integration, rev:2045
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/937/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5003/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/937/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2045
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1166/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5005/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1166/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2045
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/966/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5006/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/966/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

PASSED: Continuous integration, rev:2045
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1182/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5007/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1182/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/629/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-08-10:

#

Don't we need more tests?

review: Needs Fixing

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-08-10:

#

Also, forgot to ask for this inline.

review: Needs Information

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-12:

#

> > + qml-module-ubuntu-components-labs,
> Why is this required here?
Because I'm using MainWindow in the AutoPilot test case.

> You need also an ActionManager instance,
> into which the context must be registered.

As discussed elsewhere, it's not needed.

Note to self: adding test cases so they don't need to be done once the component is promoted to supported API.

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-15

2046. By Cris Dywan on 2016-08-15: Units instance per MainWindow and unit tests

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-15:

#

FAILED: Continuous integration, rev:2046
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/976/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5182/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/976/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-15:

#

FAILED: Continuous integration, rev:2046
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1207/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5183/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1207/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-15:

#

FAILED: Continuous integration, rev:2046
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1005/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5184/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1005/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-15:

#

FAILED: Continuous integration, rev:2046
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1222/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5185/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1222/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-15:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/649/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-16:

#

> Why do you derive from PageTreeNode?
An oversight indeed. Thanks for noticing.

> For now this is OK. But in general, as next step, the window should have its own units instance
Between said discussion and now the goal seems to have changed from starting with a proof of concept to having a full implementation including tests - fine by me, I was starting to think about it as well, but just to point out that this is changing the plan :-D

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-08-18:

#

> > Why do you derive from PageTreeNode?
> An oversight indeed. Thanks for noticing.
>
> > For now this is OK. But in general, as next step, the window should have its
> own units instance
> Between said discussion and now the goal seems to have changed from starting
> with a proof of concept to having a full implementation including tests - fine
> by me, I was starting to think about it as well, but just to point out that
> this is changing the plan :-D

We can have proof of concepts, of course. This component however seemed to me like a complete one, but yes, we can leave the tests for now, and add them once we move them into the main module.

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-08-18:

#

Why do you move this to the main module? Why haven't you let it stay in Labs?

We discussed some time ago that we need a Window component which exports the units (and a hidden PopupContext), and derive the MainWindow from it, which adds MainView specific things (theme, applicationName, etc). I see you moved the component to main, and these haven't been addressed.

It can go into Labs without this but in the mains would mean API break if we do the super class change. Let's chat about it.

review: Needs Information

Revision history for this message

Zsombor Egri (zsombi) wrote on 2016-08-18:

#

Oh, just seen that you've exported as labs 1.3 Perhaps we go for 1.0 with this one, the module has just been introduced, and all the other components are exported in 1,0 version. Let's keep it that way.

review: Needs Fixing

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-22:

#

> Oh, just seen that you've exported as labs 1.3 Perhaps we go for 1.0

Does it make any difference if it's 5.5 or 0.3? We're not going to support it anyway so I went for 1.3 so one doesn't have to think about the import at all. Any version should work for the sake of convenience.

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-08-22:

#

Filed bug 1615591 with regard to eventually moving MainWindow out of Labs and adding more tests.

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-23

2047. By Cris Dywan on 2016-08-22: Merge lp:ubuntu-ui-toolkit/staging
2048. By Cris Dywan on 2016-08-22: Move MainWindow to Ubuntu.Components.Labs 1.0

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-23:

#

FAILED: Continuous integration, rev:2048
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1050/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5525/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1050/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-23:

#

FAILED: Continuous integration, rev:2048
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1300/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5526/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1300/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-23:

#

FAILED: Continuous integration, rev:2048
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1289/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5527/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1289/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-23:

#

FAILED: Continuous integration, rev:2048
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1083/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5528/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1083/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-23:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/680/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-24

2049. By Cris Dywan on 2016-08-24: Remove redundant MainWindow test bits and handle errors better

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-24:

#

FAILED: Continuous integration, rev:2049
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1290/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5530/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1290/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-24:

#

FAILED: Continuous integration, rev:2049
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1051/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5531/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1051/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-24:

#

FAILED: Continuous integration, rev:2049
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1084/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5532/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1084/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-24:

#

PASSED: Continuous integration, rev:2049
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1301/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5533/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1301/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-24:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/681/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-08-25

2050. By Cris Dywan on 2016-08-25: Merge lp:ubuntu-ui-toolkit/staging
2051. By Cris Dywan on 2016-08-25: mainwindow seems to require x11

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-25:

#

PASSED: Continuous integration, rev:2051
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1308/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5567/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1308/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-25:

#

FAILED: Continuous integration, rev:2051
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1058/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5568/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1058/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-25:

#

FAILED: Continuous integration, rev:2051
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1091/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5570/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1091/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-25:

#

PASSED: Continuous integration, rev:2051
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1298/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/5571/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1298/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-08-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/686/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-09-13

2052. By Cris Dywan on 2016-09-13: Use custom_qpa for mainwindow unit test

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

FAILED: Continuous integration, rev:2052
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1176/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6250/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1176/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

FAILED: Continuous integration, rev:2052
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1392/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6251/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1392/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

FAILED: Continuous integration, rev:2052
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1142/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6252/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1142/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

FAILED: Continuous integration, rev:2052
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1385/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6253/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1385/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/740/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-09-13

2053. By Cris Dywan on 2016-09-13: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

PASSED: Continuous integration, rev:2053
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1180/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6267/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1180/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

FAILED: Continuous integration, rev:2053
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1146/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6271/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1146/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

PASSED: Continuous integration, rev:2053
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1396/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6272/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1396/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

PASSED: Continuous integration, rev:2053
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1389/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6273/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1389/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-13:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/743/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-09-20

2054. By Cris Dywan on 2016-09-20: Include test-include.pri so custom_qpa actually works

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

FAILED: Continuous integration, rev:2054
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1215/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6606/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1215/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

FAILED: Continuous integration, rev:2054
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1458/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6607/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1458/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

PASSED: Continuous integration, rev:2054
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/29/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6608/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/29/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

PASSED: Continuous integration, rev:2054
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1249/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6611/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1249/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

PASSED: Continuous integration, rev:2054
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1465/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6612/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1465/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-20:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/778/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Loïc Molinari (loic.molinari) wrote on 2016-09-20:

#

Hi Christian.

I'm not going to comment on the change in itself but on the header inclusion part that I recently tried to fix and standardise. Everything is explained in the CODING file at the root of the project, it's mostly Qt rules plus a few things. I hope not to be too picky but I think we should try to respect these rules as best as possible to keep it clean and usable outside of the UITK.

I added the comments inline.

review: Needs Fixing

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-09-21

2055. By Cris Dywan on 2016-09-21: Touch up include files to conform to guidelines
2056. By Cris Dywan on 2016-09-21: Add CONFIG before include

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

FAILED: Continuous integration, rev:2056
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1216/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6614/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1216/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

PASSED: Continuous integration, rev:2056
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/30/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6615/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/30/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

PASSED: Continuous integration, rev:2056
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1250/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6616/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1250/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

PASSED: Continuous integration, rev:2056
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1466/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6617/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1466/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

FAILED: Continuous integration, rev:2056
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1459/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6618/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1459/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-21:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/779/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Loïc Molinari (loic.molinari) wrote on 2016-09-21:

#

Thanks dude!

review: Approve

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2016-09-22

2057. By Cris Dywan on 2016-09-22: Retain both MainWindow{ and Window { MainView { AP tests

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

FAILED: Continuous integration, rev:2057
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1239/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6747/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1239/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

PASSED: Continuous integration, rev:2057
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1273/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6748/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1273/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

PASSED: Continuous integration, rev:2057
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1489/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6752/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1489/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

PASSED: Continuous integration, rev:2057
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/53/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6763/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/53/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

FAILED: Continuous integration, rev:2057
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1482/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/6764/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/1482/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-09-22:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/797/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-09-29:

#

Program received signal SIGSEGV, Segmentation fault.
0xf68de251 in operator==(QString const&, QString const&) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#0 0xf68de251 in operator==(QString const&, QString const&) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#1 0xf7e3b88a in UCMainWindow::setApplicationName(QString) () from /tmp/buildd/ubuntu-ui-toolkit-gles-1.3.2085+16.10.20160915/lib/libUbuntuToolkit.so.5
#2 0xf7e3bbb6 in UCMainWindow::qt_metacall(QMetaObject::Call, int, void**) () from /tmp/buildd/ubuntu-ui-toolkit-gles-1.3.2085+16.10.20160915/lib/libUbuntuToolkit.so.5
#3 0xf6a93f82 in QMetaObject::metacall(QObject*, QMetaObject::Call, int, void**) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#10 0xf6f41c0a in QQmlComponentPrivate::beginCreate(QQmlContextData*) () from /usr/lib/i386-linux-gnu/libQt5Qml.so.5
#11 0xf6f42051 in QQmlComponent::create(QQmlContext*) () from /usr/lib/i386-linux-gnu/libQt5Qml.so.5
#12 0x08049ade in loadTest (document=..., this=<optimized out>) at tst_mainwindow.cpp:73
#13 testCase_AppName (this=<optimized out>) at tst_mainwindow.cpp:117
#14 tst_MainWindow::qt_static_metacall (_o=0xffffc484, _c=135136696, _id=2, _a=0xffffbc70) at .moc/tst_mainwindow.moc:76
#15 0xf6a960ac in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#16 0xf6a9b007 in QMetaObject::invokeMethod(QObject*, char const*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#18 0xf71b2395 in QTest::qExec(QObject*, int, char**) () from /usr/lib/i386-linux-gnu/libQt5Test.so.5
#19 0x0804975c in main (argc=7, argv=0xffffc554) at tst_mainwindow.cpp:125

Program received signal SIGSEGV, Segmentation fault.
0xf68de251 in operator==(QString const&, QString const&) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#0  0xf68de251 in operator==(QString const&, QString const&) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#1  0xf7e3b88a in UCMainWindow::setApplicationName(QString) () from /tmp/buildd/ubuntu-ui-toolkit-gles-1.3.2085+16.10.20160915/lib/libUbuntuToolkit.so.5
#2  0xf7e3bbb6 in UCMainWindow::qt_metacall(QMetaObject::Call, int, void**) () from /tmp/buildd/ubuntu-ui-toolkit-gles-1.3.2085+16.10.20160915/lib/libUbuntuToolkit.so.5
#3  0xf6a93f82 in QMetaObject::metacall(QObject*, QMetaObject::Call, int, void**) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#10 0xf6f41c0a in QQmlComponentPrivate::beginCreate(QQmlContextData*) () from /usr/lib/i386-linux-gnu/libQt5Qml.so.5
#11 0xf6f42051 in QQmlComponent::create(QQmlContext*) () from /usr/lib/i386-linux-gnu/libQt5Qml.so.5
#12 0x08049ade in loadTest (document=..., this=<optimized out>) at tst_mainwindow.cpp:73
#13 testCase_AppName (this=<optimized out>) at tst_mainwindow.cpp:117
#14 tst_MainWindow::qt_static_metacall (_o=0xffffc484, _c=135136696, _id=2, _a=0xffffbc70) at .moc/tst_mainwindow.moc:76
#15 0xf6a960ac in QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#16 0xf6a9b007 in QMetaObject::invokeMethod(QObject*, char const*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) () from /usr/lib/i386-linux-gnu/sse2/libQt5Core.so.5
#18 0xf71b2395 in QTest::qExec(QObject*, int, char**) () from /usr/lib/i386-linux-gnu/libQt5Test.so.5
#19 0x0804975c in main (argc=7, argv=0xffffc554) at tst_mainwindow.cpp:125

Revision history for this message

Gerry Boland (gerboland) wrote on 2017-01-06:

#

+ QObject::connect(UbuntuI18n::instance(this), SIGNAL(domainChanged()),
+ this, SIGNAL(i18nChanged()));
+ QObject::connect(UbuntuI18n::instance(this), SIGNAL(languageChanged()),
+ this, SIGNAL(i18nChanged()));
I see the newer style connects used further down, why the old style here?

Revision history for this message

Zsombor Egri (zsombi) wrote on 2017-01-09:

#

> + QObject::connect(UbuntuI18n::instance(this), SIGNAL(domainChanged()),
> + this, SIGNAL(i18nChanged()));
> + QObject::connect(UbuntuI18n::instance(this), SIGNAL(languageChanged()),
> + this, SIGNAL(i18nChanged()));
> I see the newer style connects used further down, why the old style here?

One reason I can see that the new style connect doesn't resolve the situation when the client overrides the i18nChanged signal in JS. For that the meta-method based connect is needed.

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-09

2058. By Cris Dywan on 2017-01-09: Merge lp:ubuntu-ui-toolkit/staging

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-09:

#

FAILED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1338/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7326/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1338/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-09:

#

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1372/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7327/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1372/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-09:

#

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/152/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7328/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/152/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-09:

#

PASSED: Continuous integration, rev:2058
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1588/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7329/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1588/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-09:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/850/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-10

2059. By Cris Dywan on 2017-01-10: Add d_func()->init() to UCMainWindow constructor

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

FAILED: Continuous integration, rev:2059
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1343/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7350/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1343/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

FAILED: Continuous integration, rev:2059
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1377/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7352/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1377/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

PASSED: Continuous integration, rev:2059
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1593/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7353/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1593/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

PASSED: Continuous integration, rev:2059
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/157/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7354/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/157/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/854/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-10:

#

PASSED: Continuous integration, rev:2059
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1380/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7363/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1380/rebuild

review: Approve (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-11

2060. By Cris Dywan on 2017-01-11: Cf. applicationName to "" rather than empty like MainView

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

FAILED: Continuous integration, rev:2060
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1346/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7364/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1346/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2060
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/160/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7365/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/160/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2060
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1596/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7366/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1596/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2060
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1381/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7367/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1381/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/855/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-11

2061. By Cris Dywan on 2017-01-11: Add debug statements to UCMainWindow for CI

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

FAILED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1347/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7369/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1347/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1382/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7370/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1382/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/161/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7371/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/161/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

PASSED: Continuous integration, rev:2061
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1597/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7372/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1597/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-11:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/856/rebuild

review: Needs Fixing (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-12

2062. By Cris Dywan on 2017-01-12: Base MainWindowPrivate on QQuickWindowPrivate

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2062
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1348/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7374/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1348/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2062
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/162/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7375/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/162/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2062
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1598/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7376/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1598/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2062
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1383/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7377/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1383/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/857/rebuild

review: Approve (continuous-integration)

lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow updated on 2017-01-12

2063. By Cris Dywan on 2017-01-12: Drop debug statements

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1349/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7379/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1349/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1384/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7380/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1384/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/163/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7381/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/163/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1599/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7382/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1599/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-12:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/858/rebuild

review: Approve (continuous-integration)

Revision history for this message

Zsombor Egri (zsombi) wrote on 2017-01-13:

#

All fine for now, let's get this in.

review: Approve

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-13:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1353/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7399/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/1353/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-13:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/167/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7400/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-yakkety/167/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-13:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1388/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7401/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1388/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2017-01-13:

#

PASSED: Continuous integration, rev:2063
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1603/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/7402/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/1603/rebuild

review: Approve (continuous-integration)

Ubuntu UI Toolkit

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow into lp:ubuntu-ui-toolkit/staging

Commit message

Description of the change

Preview Diff

Subscribers

 === modified file 'src/UbuntuToolkit/UbuntuToolkit.pro'
 --- src/UbuntuToolkit/UbuntuToolkit.pro	2016-11-04 09:37:32 +0000
 +++ src/UbuntuToolkit/UbuntuToolkit.pro	2017-01-12 02:42:37 +0000
@@ -106,6 +106,8 @@
      $$PWD/uclistitemstyle_p.h \
      $$PWD/ucmainviewbase_p.h \
      $$PWD/ucmainviewbase_p_p.h \
++    $$PWD/ucmainwindow_p.h \
++    $$PWD/ucmainwindow_p_p.h \
      $$PWD/ucmargins_p.h \
      $$PWD/ucmathutils_p.h \
      $$PWD/ucmouse_p.h \
@@ -203,6 +205,7 @@
      $$PWD/uclistitemlayout.cpp \
      $$PWD/uclistitemstyle.cpp \
      $$PWD/ucmainviewbase.cpp \
++    $$PWD/ucmainwindow.cpp \
      $$PWD/ucmathutils.cpp \
      $$PWD/ucmousefilters.cpp \
      $$PWD/ucpagetreenode.cpp \
 === modified file 'src/UbuntuToolkit/ubuntutoolkitmodule.cpp'
 --- src/UbuntuToolkit/ubuntutoolkitmodule.cpp	2016-09-29 10:19:06 +0000
 +++ src/UbuntuToolkit/ubuntutoolkitmodule.cpp	2017-01-12 02:42:37 +0000
@@ -39,6 +39,7 @@
  #include "inversemouseareatype_p.h"
  #include "listener_p.h"
  #include "livetimer_p.h"
++#include "ucmainwindow_p.h"
  #include "menu_p.h"
  #include "menubar_p.h"
  #include "menugroup_p.h"
@@ -439,6 +440,7 @@
      qmlRegisterType<SplitView>(uri, 1, 0, "SplitView");
      qmlRegisterType<SplitViewLayout>(uri, 1, 0, "SplitViewLayout");
      qmlRegisterType<ViewColumn>(uri, 1, 0, "ViewColumn");
++    qmlRegisterType<UCMainWindow>(uri, 1, 0, "MainWindow");
      qmlRegisterType<Menu>(uri, 1, 0, "Menu");
      qmlRegisterType<MenuBar>(uri, 1, 0, "MenuBar");
      qmlRegisterType<MenuGroup>(uri, 1, 0, "MenuGroup");
 === modified file 'src/UbuntuToolkit/ucmainviewbase.cpp'
 --- src/UbuntuToolkit/ucmainviewbase.cpp	2016-09-12 09:03:50 +0000
 +++ src/UbuntuToolkit/ucmainviewbase.cpp	2017-01-12 02:42:37 +0000
@@ -145,6 +145,7 @@
  void UCMainViewBase::setApplicationName(QString applicationName)
+ {
      Q_D(UCMainViewBase);
++
      if (d->m_applicationName == applicationName)
          return;
 === added file 'src/UbuntuToolkit/ucmainwindow.cpp'
 --- src/UbuntuToolkit/ucmainwindow.cpp	1970-01-01 00:00:00 +0000
 +++ src/UbuntuToolkit/ucmainwindow.cpp	2017-01-12 02:42:37 +0000
@@ -0,0 +1,215 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#include "ucmainwindow_p_p.h"
++
++#include <QtCore/QCoreApplication>
++
++#include "ucactionmanager_p.h"
++#include "ucactioncontext_p.h"
++#include "ucapplication_p.h"
++#include "uctheme_p.h"
++#include "i18n_p.h"
++#include "quickutils_p.h"
++
++UT_NAMESPACE_BEGIN
++
++/*!
++  \internal
++  \qmlabstract MainWindow
++  \inqmlmodule Ubuntu.Components.Labs
++  \ingroup ubuntu
++  \brief MainWindow is an alternate window-based root Item providing \l units
++  and \l i18n as native properties, an \ actionContext and an \l applicationName.
++  Unlike \l MainView there is no built-in header.
++
++  The simplest way to use a MainWindow is to include a single \l Page object:
++  \qml
++      import QtQuick 2.4
++      import Ubuntu.Components 1.3
++      import Ubuntu.Components.Labs 1.3
++
++      MainWindow {
++          minimumWidth: units.gu(48)
++          minimumHeight: units.gu(60)
++
++          Page {
++	      anchors.fill: parent
++              header: PageHeader {
++                  title: "Simple page"
++              }
++              Button {
++                  anchors {
++                      horizontalCenter: parent.horizontalCenter
++                      top: pageHeader.bottom
++                      topMargin: units.gu(5)
++                  }
++                  width: units.gu(15)
++                  text: "Push me"
++                  onClicked: print("Click!")
++              }
++          }
++      }
++  \endqml
++  Anchors need to be set, there's no automatic fill like with \l MainView.
++
++  Do not include multiple Pages directly, but use \l AdaptivePageLayout
++  inside MainWindow to navigate between several Pages.
++
++  If the \l Page inside the MainWindow includes a Flickable, set the flickable property of
++  the PageHeader to automatically hide and show the header when the user scrolls up or down:
++  \qml
++      import QtQuick 2.4
++      import Ubuntu.Components 1.3
++      import Ubuntu.Components.Labs 1.3
++
++      MainWindow {
++          minimumWidth: units.gu(48)
++          maximumHeight: units.gu(60)
++
++          Page {
++              anchors.fill: parent
++              header: PageHeader {
++                  title: "Page with Flickable"
++                  flickable: myFlickable
++              }
++
++              Flickable {
++                  id: myFlickable
++                  anchors.fill: parent
++                  contentHeight: column.height
++
++                  Column {
++                      id: column
++                      Repeater {
++                          model: 100
++                          Label {
++                              text: "line "+index
++                          }
++                      }
++                  }
++              }
++          }
++      }
++  \endqml
++  The same header behavior is automatic when using a ListView instead of a Flickable in the above
++  example.
++
++  The examples above show how to include a single \l Page inside a MainWindow, but more
++  advanced application structures are possible using \l AdaptivePageLayout.
++**/
++UCMainWindowPrivate::UCMainWindowPrivate()
++    : m_actionContext(nullptr),
++      m_units(nullptr)
++{
++}
++
++void UCMainWindowPrivate::init()
++{
++    Q_Q(UCMainWindow);
++
++    //need to init here because the q pointer is null in constructor
++    m_actionContext = new UCPopupContext(q);
++
++    m_actionContext->setObjectName(QStringLiteral("RootContext"));
++    m_actionContext->setActive(true);
++}
++
++UCMainWindow::UCMainWindow(QWindow *parent)
++    : QQuickWindow(*(new UCMainWindowPrivate), parent)
++{
++    d_func()->init();
++
++    QObject::connect(UbuntuI18n::instance(this), SIGNAL(domainChanged()),
++                     this, SIGNAL(i18nChanged()));
++    QObject::connect(UbuntuI18n::instance(this), SIGNAL(languageChanged()),
++                     this, SIGNAL(i18nChanged()));
++}
++
++/*!
++  \qmlproperty string MainWindow::applicationName
++
++  The property holds the application's name, which must be the same as the
++  desktop file's name.
++  The name also sets the name of the QCoreApplication and defaults for data
++  and cache folders that work on the desktop and under confinement, as well as
++  the default gettext domain.
++  C++ code that writes files may use QStandardPaths::writableLocation with
++  QStandardPaths::DataLocation or QStandardPaths::CacheLocation.
++*/
++QString UCMainWindow::applicationName() const
++{
++    return d_func()->m_applicationName;
++}
++
++void UCMainWindow::setApplicationName(QString applicationName)
++{
++    Q_D(UCMainWindow);
++
++    if (d->m_applicationName == applicationName)
++        return;
++
++    d->m_applicationName = applicationName;
++
++    if (applicationName != QStringLiteral("")) {
++        UbuntuI18n::instance()->setDomain(applicationName);
++        UCApplication::instance()->setApplicationName(applicationName);
++    }
++    Q_EMIT applicationNameChanged(applicationName);
++}
++
++/*!
++  \qmlproperty Units MainWindow::units
++
++  Grid units for this particular window - unlike the global context property
++  by the same name.
++*/
++UCUnits* UCMainWindow::units()
++{
++    Q_D(UCMainWindow);
++
++    if (!d->m_units) {
++        d->m_units = new UCUnits(this);
++        QObject::connect(d->m_units, SIGNAL(gridUnitChanged()),
++                         this, SIGNAL(unitsChanged()));
++    }
++    return d->m_units;
++}
++
++/*!
++  \qmlproperty Units MainWindow::i18n
++
++  The property holds its breath for documentation.
++*/
++UbuntuI18n* UCMainWindow::i18n() const
++{
++    return UbuntuI18n::instance();
++}
++
++/*!
++  \qmlproperty ActionContext MainWindow::actionContext
++  \readonly
++  \since Ubuntu.Components 1.3
++  The action context of the MainWindow.
++  */
++UCPopupContext *UCMainWindow::actionContext() const
++{
++    return d_func()->m_actionContext;
++}
++
++UT_NAMESPACE_END
++
++#include "moc_ucmainwindow_p.cpp"
 === added file 'src/UbuntuToolkit/ucmainwindow_p.h'
 --- src/UbuntuToolkit/ucmainwindow_p.h	1970-01-01 00:00:00 +0000
 +++ src/UbuntuToolkit/ucmainwindow_p.h	2017-01-12 02:42:37 +0000
@@ -0,0 +1,73 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef UCMAINWINDOW_P_H
++#define UCMAINWINDOW_P_H
++
++#include <QtQuick/QQuickWindow>
++
++#include <UbuntuToolkit/private/i18n_p.h>
++#include <UbuntuToolkit/private/ucunits_p.h>
++
++UT_NAMESPACE_BEGIN
++
++class UCMainWindowPrivate;
++class UCPopupContext;
++class UCAction;
++
++class UBUNTUTOOLKIT_EXPORT UCMainWindow : public QQuickWindow
++{
++    Q_OBJECT
++    Q_PROPERTY(QString applicationName READ applicationName WRITE setApplicationName NOTIFY applicationNameChanged)
++#ifndef Q_QDOC
++    Q_PROPERTY(UT_PREPEND_NAMESPACE(UCUnits)* units READ units NOTIFY unitsChanged)
++    Q_PROPERTY(UT_PREPEND_NAMESPACE(UbuntuI18n)* i18n READ i18n NOTIFY i18nChanged)
++    Q_PROPERTY(UT_PREPEND_NAMESPACE(UCPopupContext)* actionContext READ actionContext NOTIFY actionContextChanged)
++#else
++    Q_PROPERTY(UCUnits* units READ units NOTIFY unitsChanged)
++    Q_PROPERTY(UbuntuI18n* i18n READ i18n NOTIFY i18nChanged)
++    Q_PROPERTY(UCPopupContext* actionContext READ actionContext NOTIFY actionContextChanged)
++#endif
++
++public:
++    UCMainWindow(QWindow *parent = nullptr);
++
++
++    QString applicationName() const;
++    void setApplicationName(QString applicationName);
++
++    UCUnits* units();
++    UbuntuI18n* i18n() const;
++
++    UCPopupContext* actionContext() const;
++
++Q_SIGNALS:
++    void applicationNameChanged(QString applicationName);
++    void i18nChanged();
++    void unitsChanged();
++#ifndef Q_QDOC
++    void actionContextChanged(UT_PREPEND_NAMESPACE(UCPopupContext)* actionContext);
++#else
++    void actionContextChanged(UCPopupContext* actionContext);
++#endif
++
++private:
++    Q_DECLARE_PRIVATE(UCMainWindow)
++};
++
++UT_NAMESPACE_END
++
++#endif // UCMAINWINDOW_P_H
 === added file 'src/UbuntuToolkit/ucmainwindow_p_p.h'
 --- src/UbuntuToolkit/ucmainwindow_p_p.h	1970-01-01 00:00:00 +0000
 +++ src/UbuntuToolkit/ucmainwindow_p_p.h	2017-01-12 02:42:37 +0000
@@ -0,0 +1,47 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++#ifndef UCMAINWINDOW_P_P_H
++#define UCMAINWINDOW_P_P_H
++
++#include <UbuntuToolkit/private/ucmainwindow_p.h>
++
++#include <QtQml/QQmlProperty>
++
++#include <QtQuick/private/qquickwindow_p.h>
++
++UT_NAMESPACE_BEGIN
++
++class UCMainWindow;
++class UCPopupContext;
++
++class UCMainWindowPrivate : public QQuickWindowPrivate
++{
++    Q_DECLARE_PUBLIC(UCMainWindow)
++
++public:
++    UCMainWindowPrivate();
++    void init();
++
++    QString m_applicationName;
++    UCPopupContext* m_actionContext = nullptr;
++    UCUnits* m_units = nullptr;
++
++};
++
++UT_NAMESPACE_END
++
++#endif // UCMAINWINDOW_P_P_H
 === modified file 'src/UbuntuToolkit/ucunits.cpp'
 --- src/UbuntuToolkit/ucunits.cpp	2016-09-12 09:03:50 +0000
 +++ src/UbuntuToolkit/ucunits.cpp	2017-01-12 02:42:37 +0000
@@ -97,18 +97,44 @@
   * isolated from Qt's own scaling concept.
   */
++UCUnits::UCUnits(QWindow *parent) :
++    QObject(parent),
++    m_devicePixelRatio(parent->devicePixelRatio())
++{
++    m_gridUnit = getenvFloat(ENV_GRID_UNIT_PX, DEFAULT_GRID_UNIT_PX * m_devicePixelRatio);
++    QObject::connect(parent, &QWindow::screenChanged,
++                     this, &UCUnits::screenChanged);
++    m_screen = parent->screen();
++    if (m_screen)
++        QObject::connect(m_screen, &QScreen::physicalDotsPerInchChanged,
++                         this, &UCUnits::devicePixelRatioChanged);
++}
++
++void UCUnits::screenChanged(QScreen *screen)
++{
++    if (m_screen)
++        QObject::disconnect(m_screen, &QScreen::physicalDotsPerInchChanged,
++                            this, &UCUnits::devicePixelRatioChanged);
++    m_screen = screen;
++    QObject::connect(m_screen, &QScreen::physicalDotsPerInchChanged,
++                     this, &UCUnits::devicePixelRatioChanged);
++    m_devicePixelRatio = screen->devicePixelRatio();
++    setGridUnit(DEFAULT_GRID_UNIT_PX * m_devicePixelRatio);
++}
++
++void UCUnits::devicePixelRatioChanged(qreal dpi)
++{
++    m_devicePixelRatio = dpi;
++    setGridUnit(DEFAULT_GRID_UNIT_PX * m_devicePixelRatio);
++}
++
  UCUnits *UCUnits::m_units = nullptr;
  UCUnits::UCUnits(QObject *parent) :
      QObject(parent),
      m_devicePixelRatio(qGuiApp->devicePixelRatio())
+ {
--    // If GRID_UNIT_PX set, always use it. If not, 1GU := DEFAULT_GRID_UNIT_PX * m_devicePixelRatio
--    if (qEnvironmentVariableIsSet(ENV_GRID_UNIT_PX)) {
--        m_gridUnit = getenvFloat(ENV_GRID_UNIT_PX, DEFAULT_GRID_UNIT_PX);
--    } else {
--        m_gridUnit = DEFAULT_GRID_UNIT_PX * m_devicePixelRatio;
--    }
++    m_gridUnit = getenvFloat(ENV_GRID_UNIT_PX, DEFAULT_GRID_UNIT_PX * m_devicePixelRatio);
      auto nativeInterface = qGuiApp->platformNativeInterface();
      if (nativeInterface) {
 === modified file 'src/UbuntuToolkit/ucunits_p.h'
 --- src/UbuntuToolkit/ucunits_p.h	2016-09-09 17:49:07 +0000
 +++ src/UbuntuToolkit/ucunits_p.h	2017-01-12 02:42:37 +0000
@@ -23,6 +23,7 @@
  #include <QtCore/QObject>
  #include <QtCore/QString>
  #include <QtCore/QUrl>
++#include <QtGui/QWindow>
  #include <UbuntuToolkit/ubuntutoolkitglobal.h>
@@ -48,6 +49,7 @@
+     }
      explicit UCUnits(QObject *parent = 0);
++    explicit UCUnits(QWindow *parent);
      ~UCUnits();
      Q_INVOKABLE float dp(float value);
      Q_INVOKABLE float gu(float value);
@@ -68,10 +70,13 @@
  private Q_SLOTS:
      void windowPropertyChanged(QPlatformWindow *window, const QString &propertyName);
++    void screenChanged(QScreen *screen);
++    void devicePixelRatioChanged(qreal dpi);
  private:
      static UCUnits *m_units;
      float m_devicePixelRatio;
++    QScreen *m_screen;
      float m_gridUnit;
  };
 === renamed file 'tests/autopilot/ubuntuuitoolkit/tests/test_launcher.window.qml' => 'tests/autopilot/ubuntuuitoolkit/tests/test_launcher.mainwindow.qml'
 --- tests/autopilot/ubuntuuitoolkit/tests/test_launcher.window.qml	2016-07-12 12:05:11 +0000
 +++ tests/autopilot/ubuntuuitoolkit/tests/test_launcher.mainwindow.qml	2017-01-12 02:42:37 +0000
@@ -17,23 +17,30 @@
  import QtQuick 2.4
  import QtQuick.Window 2.2 // Not Ubuntu.Test
  import Ubuntu.Components 1.3
++import Ubuntu.Components.Labs 1.3
--Window {
--    title: "Hello World"
++MainWindow {
++    title: i18n.tr("Hello World")
      minimumWidth: units.gu(30)
      minimumHeight: units.gu(50)
      maximumWidth: units.gu(90)
      maximumHeight: units.gu(120)
--    MainView {
++
++    Item {
++        anchors.fill: parent
          objectName: "mainView"
          Page {
--            title: "Launcher/Window"
++            anchors.fill: parent
++            header: PageHeader {
++                title: "Launcher/Window"
++            }
              Column {
++                anchors.top: parent.header.bottom
                  Label {
                      objectName: "label"
--                    text: "Lorem ipsum dolor sit amet"
++                    text: i18n.tr("Lorem ipsum dolor sit amet")
                      width: units.gu(25)
                      height: units.gu(25)
+                 }
 === modified file 'tests/autopilot/ubuntuuitoolkit/tests/test_launcher.py'
 --- tests/autopilot/ubuntuuitoolkit/tests/test_launcher.py	2016-07-12 12:05:11 +0000
 +++ tests/autopilot/ubuntuuitoolkit/tests/test_launcher.py	2017-01-12 02:42:37 +0000
@@ -49,6 +49,18 @@
                          Eventually(Equals("Lorem ipsum dolor sit amet")))
++class LauncherMainWindowTestCase(tests.QMLFileAppTestCase):
++    path = os.path.abspath(__file__)
++    dir_path = os.path.dirname(path)
++    test_qml_file_path = os.path.join(
++        dir_path, 'test_launcher.mainwindow.qml')
++
++    def test_window_root_item(self):
++        label = self.main_view.select_single(objectName="label")
++        self.assertThat(label.text,
++                        Eventually(Equals("Lorem ipsum dolor sit amet")))
++
++
  class LauncherQtTestTestCase(tests.QMLFileAppTestCase):
      path = os.path.abspath(__file__)
      dir_path = os.path.dirname(path)
 === added file 'tests/autopilot/ubuntuuitoolkit/tests/test_launcher.window.qml'
 --- tests/autopilot/ubuntuuitoolkit/tests/test_launcher.window.qml	1970-01-01 00:00:00 +0000
 +++ tests/autopilot/ubuntuuitoolkit/tests/test_launcher.window.qml	2017-01-12 02:42:37 +0000
@@ -0,0 +1,43 @@
++/*
++ * Copyright 2014-2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++import QtQuick 2.4
++import QtQuick.Window 2.2 // Not Ubuntu.Test
++import Ubuntu.Components 1.3
++
++Window {
++    title: "Hello World"
++    minimumWidth: units.gu(30)
++    minimumHeight: units.gu(50)
++    maximumWidth: units.gu(90)
++    maximumHeight: units.gu(120)
++    MainView {
++        objectName: "mainView"
++
++        Page {
++            title: "Launcher/Window"
++
++            Column {
++                Label {
++                    objectName: "label"
++                    text: "Lorem ipsum dolor sit amet"
++                    width: units.gu(25)
++                    height: units.gu(25)
++                }
++            }
++        }
++    }
++}
 === added directory 'tests/unit/mainwindow'
 === added file 'tests/unit/mainwindow/AppName.qml'
 --- tests/unit/mainwindow/AppName.qml	1970-01-01 00:00:00 +0000
 +++ tests/unit/mainwindow/AppName.qml	2017-01-12 02:42:37 +0000
@@ -0,0 +1,28 @@
++/*
++ * Copyright 2013-2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++
++import QtQuick 2.4
++import Ubuntu.Components 1.3
++import Ubuntu.Components.Labs 1.0
++
++MainWindow {
++    objectName: "appName"
++    applicationName: "org.gnu.wildebeest"
++
++    Label {
++        text: "Lorem ipsum dolor sit amet"
++    }
++}
 === added file 'tests/unit/mainwindow/mainwindow.pro'
 --- tests/unit/mainwindow/mainwindow.pro	1970-01-01 00:00:00 +0000
 +++ tests/unit/mainwindow/mainwindow.pro	2017-01-12 02:42:37 +0000
@@ -0,0 +1,5 @@
++CONFIG += custom_qpa   # needed by test to set device pixel ratio correctly
++include(../test-include.pri)
++
++QT += gui
++SOURCES += tst_mainwindow.cpp
 === added file 'tests/unit/mainwindow/tst_mainwindow.cpp'
 --- tests/unit/mainwindow/tst_mainwindow.cpp	1970-01-01 00:00:00 +0000
 +++ tests/unit/mainwindow/tst_mainwindow.cpp	2017-01-12 02:42:37 +0000
@@ -0,0 +1,127 @@
++/*
++ * Copyright 2012-2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ *
++ * Author: Christian Dywan <christian.dywan@canonical.com>
++ */
++
++#include <QtCore/QString>
++#include <QtCore/QTextCodec>
++#include <QtCore/QStandardPaths>
++#include <QtCore/QProcessEnvironment>
++#include <QtCore/QDebug>
++#include <QtTest/QTest>
++#include <QtTest/QSignalSpy>
++#include <QtCore/QCoreApplication>
++#include <QtQml/QQmlEngine>
++#include <QtQuick/QQuickView>
++#include <QtQuick/QQuickItem>
++#include <QtCore/QThread>
++#include <QtCore/QFileInfo>
++#include <QtCore/QDir>
++#include <QtCore/QCryptographicHash>
++#include <QtCore/QSettings>
++
++#include <QtQuick/QQuickItem>
++#include <QtQuick/QQuickView>
++#include <QtGui/QGuiApplication>
++#include <QtQml/QQmlEngine>
++#include <QtQml/QQmlContext>
++#include <QtQml/QQmlComponent>
++
++#include <UbuntuToolkit/ubuntutoolkitmodule.h>
++#include <UbuntuToolkit/private/ucapplication_p.h>
++#include <UbuntuToolkit/private/ucunits_p.h>
++
++UT_USE_NAMESPACE
++
++class tst_MainWindow : public QObject
++{
++    Q_OBJECT
++
++public:
++    tst_MainWindow()
++    {
++    }
++
++    QQuickWindow *loadTest(const QString &document)
++    {
++        // Can't use UbuntuTestCase: We need a Window root item
++        QPointer<QQmlEngine> engine(new QQmlEngine());
++        QString modulePath(UBUNTU_QML_IMPORT_PATH);
++        if (!QDir(modulePath).exists()) {
++            qWarning("'%s' doesn't exist", qPrintable(modulePath));
++            return 0;
++        }
++        engine->addImportPath(modulePath);
++        UbuntuToolkitModule::initializeContextProperties(engine);
++        QPointer<QQmlComponent> component(new QQmlComponent(engine));
++        component->loadUrl(QUrl::fromLocalFile(document), QQmlComponent::Asynchronous);
++        while (component->isLoading())
++            QCoreApplication::processEvents();
++        QObject *toplevel(component->create());
++        if (component->errorString() != "") {
++            qWarning("%s", qPrintable(component->errorString()));
++            return 0;
++        }
++        QQuickWindow* window(qobject_cast<QQuickWindow *>(toplevel));
++        if (window)
++            engine->setIncubationController(window->incubationController());
++        else {
++            QQuickItem *rootItem = qobject_cast<QQuickItem *>(toplevel);
++            if (rootItem) {
++                QQuickView *view(new QQuickView(engine, 0));
++                window = view;
++                view->setResizeMode(QQuickView::SizeRootObjectToView);
++                view->setContent(document, component, rootItem);
++            }
++        }
++        return window;
++    }
++
++    QQuickItem *testItem(QQuickItem *that, const QString &identifier)
++    {
++        if (that->property(identifier.toLocal8Bit()).isValid())
++            return that->property(identifier.toLocal8Bit()).value<QQuickItem*>();
++
++        QList<QQuickItem*> children = that->findChildren<QQuickItem*>(identifier);
++        return (children.count() > 0) ? children[0] : 0;
++    }
++
++private Q_SLOTS:
++
++    void initTestCase()
++    {
++    }
++
++    void cleanupTestCase()
++    {
++    }
++
++    // Note: tests/unit/mainview contains the UCApplication bits
++
++    void testCase_AppName()
++    {
++        QString applicationName("org.gnu.wildebeest");
++        QQuickWindow *mainWindow(loadTest("AppName.qml"));
++        QVERIFY(mainWindow);
++        QCOMPARE(applicationName, mainWindow->property("applicationName").toString());
++        QCOMPARE(applicationName, QCoreApplication::applicationName());
++        QCOMPARE(QString(""), QCoreApplication::organizationName());
++    }
++};
++
++QTEST_MAIN(tst_MainWindow)
++
++#include "tst_mainwindow.moc"
 === modified file 'tests/unit/unit.pro'
 --- tests/unit/unit.pro	2016-09-30 05:39:57 +0000
 +++ tests/unit/unit.pro	2017-01-12 02:42:37 +0000
@@ -41,6 +41,7 @@
      performance \
      mainview11 \
      mainview13 \
++    mainwindow \
      i18n \
      arguments \
      argument \