Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow

Revision history for this message
Zsombor Egri (zsombi) wrote :

Why do you move this to the main module? Why haven't you let it stay in Labs?

We discussed some time ago that we need a Window component which exports the units (and a hidden PopupContext), and derive the MainWindow from it, which adds MainView specific things (theme, applicationName, etc). I see you moved the component to main, and these haven't been addressed.

It can go into Labs without this but in the mains would mean API break if we do the super class change. Let's chat about it.

review: Needs Information

« Back to merge proposal