Merge autopkgtest-cloud:staging-net-name into autopkgtest-cloud:master

Proposed by Brian Murray
Status: Merged
Merged at revision: 0d6118fb191e19ed3b6fe17ad813c28858280b45
Proposed branch: autopkgtest-cloud:staging-net-name
Merge into: autopkgtest-cloud:master
Diff against target: 22 lines (+2/-2)
1 file modified
mojo/service-bundle (+2/-2)
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email: mp+444313@code.launchpad.net

Description of the change

Instead of modifying the code for different network names as in https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/444308, I opted to rename the PS45 staging network name to match that of PS5's staging network name.

Subsequently, it was necessary to change the network name in the service bundle so the correct net-name.rc file and worker-$REGION-$ARCH.conf files were written. (Haha - however the worker*.conf files weren't really updated when net-name changed - bug coming.)

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/mojo/service-bundle b/mojo/service-bundle
2index d7d8e9c..50018fb 100644
3--- a/mojo/service-bundle
4+++ b/mojo/service-bundle
5@@ -72,7 +72,7 @@ applications:
6 {%- if stage_name == "production" %}
7 net-name: net_prod-proposed-migration
8 {%- elif stage_name == "staging" %}
9- net-name: net_stg_proposed-migration
10+ net-name: net_stg-proposed-migration
11 {%- elif stage_name == "devel" %}
12 net-name: net_instances
13 mirror: http://ports.ubuntu.com/ubuntu-ports/
14@@ -164,7 +164,7 @@ applications:
15 {%- if stage_name == "production" %}
16 net-name: net_prod-proposed-migration
17 {%- elif stage_name == "staging" %}
18- net-name: net_stg_proposed-migration
19+ net-name: net_stg-proposed-migration
20 {%- elif stage_name == "devel" %}
21 net-name: net_instances
22 mirror: http://ports.ubuntu.com/ubuntu-ports/

Subscribers

People subscribed via source and target branches