Merge autopkgtest-cloud:net-name-for-region into autopkgtest-cloud:master

Proposed by Brian Murray
Status: Rejected
Rejected by: Brian Murray
Proposed branch: autopkgtest-cloud:net-name-for-region
Merge into: autopkgtest-cloud:master
Diff against target: 19 lines (+7/-1)
1 file modified
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/build-adt-image (+7/-1)
Reviewer Review Type Date Requested Status
Canonical's Ubuntu QA Pending
Review via email: mp+444308@code.launchpad.net

Description of the change

Then network in PS5 is named net_stg-proposed-migration while in PS45 it is named net_stg_proposed-migration. To be able to allow the PS45 autopkgtest-cloud-worker units to access PS5 I made changes to build-adt-image (this MP) and worker-lcy02.conf (hacking --net-id argument).

It's entirely possible there is an "easy" way to copy the net_stg-proposed-migration network to net_stg_proposed-migration in PS5 but I couldn't find it. I also took this direction given that PS45 accessing PS5 should be short lived because everything should move to PS5.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote (last edit ):

Well there was an "easy" way to rename the net_stg_proposed-migration to net_stg-proposed-migration so I did that instead.

This was the command:

openstack network set --name net_stg-proposed-migration c052b3b1-c074-45de-99be-fb331383b2cc

Although I had to use openstack on a cloud-worker and not the bastion because that version of openstack is soooo old.

Unmerged commits

cd564a3... by Brian Murray

tools: read and prefer net-name-$region rc files

Succeeded
[SUCCEEDED] build_charms:0 (build)
[SUCCEEDED] lint_test:0 (build)
12 of 2 results

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/build-adt-image b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/build-adt-image
2index be6b4d3..c2144a9 100755
3--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/build-adt-image
4+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/build-adt-image
5@@ -20,7 +20,13 @@ if [ -z "${MIRROR:-}" ]; then
6 fi
7 export MIRROR
8
9-[ -z "${NET_NAME:-}" ] && . ~/net-name.rc
10+if [ -z "${NET_NAME:-}" ]; then
11+ if [ -e ~/net-name-${REGION}.rc ]; then
12+ . ~/net-name-${REGION}.rc
13+ else
14+ ~/net-name.rc
15+ fi
16+fi
17 export NET_NAME
18
19 if [ -z "${USE_CLOUD_CONFIG_FROM_ENV:-}" ]; then

Subscribers

People subscribed via source and target branches