Code review comment for ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:initial-review

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

I forgot to also update the description, as requested in the review (that should be done now).

Moreover, on the CQLVERSION matter: that seems to be specific to the container image used for the sqlsh CLI right?

In their entrypoint, I see they set "export CQLVERSION=${CQLVERSION:-"3.4.4"}".

And in Cassandra cqlsh.py, we have "by default the highest version supported by the server will be used" for the --cqlversion description.

I'd expect the user to use a client compatible with the version of the server being deployed.

I also intend to snap the cqlsh in the future (ship it within the cassandra snap).

« Back to merge proposal