Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:initial-review into ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:main
Status: | Merged |
---|---|
Merged at revision: | c1ab28277af7506678d651682009b3b8d07cdb86 |
Proposed branch: | ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:initial-review |
Merge into: | ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:main |
Diff against target: |
161 lines (+39/-59) 3 files modified
Dockerfile (+31/-35) data/cassandra.yaml (+5/-4) entrypoint.sh (+3/-20) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Durigan Junior | Approve | ||
Bryce Harrington | Pending | ||
Canonical Server | Pending | ||
Review via email: mp+404127@code.launchpad.net |
Description of the change
Addressing Sergio's comments from the mailing list review at https:/
Two points are not being addressed here
1) Moving all RUN commands from the final build stage into a single RUN command:
This requires changes in the snap (marking the binary file as executable).
2) matching any Java version when setting the JAVA environment variable:
I'd rather explicitly tell what version to use in case the image ends up containing multiple Java versions installed by whatever reason (if this is ever the case, it should be fixed, but we may miss it and and up shipping a container that runs cassandra on an unexpected Java version. WDYT?)
I forgot to also update the description, as requested in the review (that should be done now).
Moreover, on the CQLVERSION matter: that seems to be specific to the container image used for the sqlsh CLI right?
In their entrypoint, I see they set "export CQLVERSION= ${CQLVERSION: -"3.4.4" }".
And in Cassandra cqlsh.py, we have "by default the highest version supported by the server will be used" for the --cqlversion description.
I'd expect the user to use a client compatible with the version of the server being deployed.
I also intend to snap the cqlsh in the future (ship it within the cassandra snap).