Merge lp:~ubuntu-branches/ubuntu/natty/liferea/natty-201103250153 into lp:ubuntu/natty/liferea

Proposed by James Westby
Status: Work in progress
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/liferea/natty-201103250153
Merge into: lp:ubuntu/natty/liferea
Diff against target: 210 lines (+204/-0) (has conflicts)
1 file modified
debian/patches/libunity.patch (+204/-0)
Conflict adding file debian/patches/libunity.patch.  Moved existing file to debian/patches/libunity.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/liferea/natty-201103250153
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+55051@code.launchpad.net

Description of the change

The package history in the archive and the history in the bzr branch differ. As the archive is authoritative the history of lp:ubuntu/natty/liferea now reflects that and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/natty/liferea/natty-201103250153. A merge should be performed if necessary.

To post a comment you must log in.

Unmerged revisions

111. By Ken VanDine

releasing version 1.6.4-1ubuntu6

110. By Ken VanDine

* debian/patches/libunity.patch
  - Displays the number of unread items in the Unity Launcher
    entry (LP: #732848).
* debian/control
  - Added missing build dep to libunity-dev

109. By Marc Deslauriers

* Fix indicator support again (LP: #723349)
  - debian/patches/libindicate.patch: updated check for new version of
    libindicate.
  - debian/control: bump libindicate-dev and libindicate-gtk-dev
    version requirement.

108. By Benjamin Drung

Change build dependency from libwebkit-dev to libwebkitgtk-dev
(LP: #703248).

107. By Marc Deslauriers

debian/control: Add libindicate-gtk-dev to Build-Depends so indicator
support gets built properly. (LP: #689710)

106. By Luke Yelavich

releasing version 1.6.4-1ubuntu2

105. By Luke Yelavich

debian/patches/libindicate.patch: Fixed reversed order and missing
favicons in indicator applet, thanks to Pavol Klačanský for the patch.
(LP: #653995)

104. By Luke Yelavich

Integrate indicator_icons.patch into libindicate.patch

103. By Luke Yelavich

Merge branch lp:~pavolzetor/ubuntu/natty/liferea/liferea-test with changes:
  - Kept src/ui/ui_indicator.{c,h} so they still have a revision history

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/libunity.patch'
2--- debian/patches/libunity.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/libunity.patch 2011-03-28 07:07:36 +0000
4@@ -0,0 +1,204 @@
5+=== modified file 'src/Makefile.am'
6+Index: fix-for-bug-732848/src/Makefile.am
7+===================================================================
8+--- fix-for-bug-732848.orig/src/Makefile.am 2011-03-12 12:50:17.735382000 +0100
9++++ fix-for-bug-732848/src/Makefile.am 2011-03-12 12:50:30.401905830 +0100
10+@@ -97,3 +97,9 @@
11+ liferea_LDADD += $(LIBINDICATE_LIBS)
12+
13+ endif
14++
15++if WITH_LIBUNITY
16++
17++liferea_LDADD += $(LIBUNITY_LIBS)
18++
19++endif
20+Index: fix-for-bug-732848/src/ui/Makefile.am
21+===================================================================
22+--- fix-for-bug-732848.orig/src/ui/Makefile.am 2011-03-12 12:50:17.735382000 +0100
23++++ fix-for-bug-732848/src/ui/Makefile.am 2011-03-12 12:50:30.401905830 +0100
24+@@ -8,7 +8,7 @@
25+
26+ noinst_LIBRARIES = libliui.a
27+
28+-libliui_a_CFLAGS = $(PACKAGE_CFLAGS) $(DBUS_CFLAGS) $(LIBINDICATE_CFLAGS)
29++libliui_a_CFLAGS = $(PACKAGE_CFLAGS) $(DBUS_CFLAGS) $(LIBINDICATE_CFLAGS) $(LIBUNITY_CFLAGS)
30+ libliui_a_SOURCES = \
31+ auth_dialog.c auth_dialog.h \
32+ browser_tabs.c browser_tabs.h \
33+@@ -35,4 +35,5 @@
34+ ui_session.c ui_session.h \
35+ ui_subscription.c ui_subscription.h \
36+ ui_tray.c ui_tray.h \
37++ ui_unity.c ui_unity.h \
38+ ui_update.c ui_update.h
39+Index: fix-for-bug-732848/src/ui/ui_tray.c
40+===================================================================
41+--- fix-for-bug-732848.orig/src/ui/ui_tray.c 2011-03-12 12:50:17.735382000 +0100
42++++ fix-for-bug-732848/src/ui/ui_tray.c 2011-03-12 12:50:30.405905830 +0100
43+@@ -188,6 +188,7 @@
44+ gchar *msg, *tmp;
45+
46+ ui_indicator_update ();
47++ ui_unity_update();
48+
49+ if (!trayIcon_priv)
50+ return;
51+Index: fix-for-bug-732848/src/ui/ui_unity.c
52+===================================================================
53+--- /dev/null 1970-01-01 00:00:00.000000000 +0000
54++++ fix-for-bug-732848/src/ui/ui_unity.c 2011-03-12 12:50:52.949905875 +0100
55+@@ -0,0 +1,62 @@
56++/*
57++ * Copyright (C) 2011 Jean-Philippe Orsini <jeanfi@gmail.com>
58++ *
59++ * This program is free software; you can redistribute it and/or modify
60++ * it under the terms of the GNU General Public License as published by
61++ * the Free Software Foundation; either version 2 of the License, or
62++ * (at your option) any later version.
63++ *
64++ * This program is distributed in the hope that it will be useful,
65++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
66++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
67++ * GNU Library General Public License for more details.
68++ *
69++ * You should have received a copy of the GNU General Public License
70++ * along with this program; if not, write to the Free Software
71++ * Foundation, Inc., 51 Franklin Street, Fifth Floor Boston, MA 02110-1301, USA
72++ */
73++
74++#include "ui_unity.h"
75++
76++#ifdef HAVE_LIBUNITY
77++
78++#include <feedlist.h>
79++
80++#include <unity.h>
81++
82++static UnityLauncherEntry *entry;
83++
84++void ui_unity_update (void)
85++{
86++ int count;
87++
88++ if (!entry)
89++ entry = unity_launcher_entry_get_for_desktop_file
90++ ("liferea.desktop");
91++
92++ if (entry) {
93++ count = feedlist_get_unread_item_count ();
94++
95++ if (count) {
96++ unity_launcher_entry_set_count (entry, count);
97++ unity_launcher_entry_set_count_visible (entry, TRUE);
98++ } else {
99++ unity_launcher_entry_set_count_visible (entry, FALSE);
100++ }
101++ }
102++}
103++
104++void ui_unity_destroy (void)
105++{
106++ if (entry) {
107++ unity_launcher_entry_set_count_visible (entry, FALSE);
108++ g_main_context_iteration(NULL, FALSE);
109++ }
110++}
111++
112++#else
113++
114++void ui_unity_update (void) {}
115++void ui_unity_destroy (void) {}
116++
117++#endif /* HAVE_LIBUNITY */
118+Index: fix-for-bug-732848/src/ui/ui_unity.h
119+===================================================================
120+--- /dev/null 1970-01-01 00:00:00.000000000 +0000
121++++ fix-for-bug-732848/src/ui/ui_unity.h 2011-03-12 12:50:30.405905830 +0100
122+@@ -0,0 +1,29 @@
123++/*
124++ * Copyright (C) 2011 Jean-Philippe Orsini <jeanfi@gmail.com>
125++ *
126++ * This program is free software; you can redistribute it and/or modify
127++ * it under the terms of the GNU General Public License as published by
128++ * the Free Software Foundation; either version 2 of the License, or
129++ * (at your option) any later version.
130++ *
131++ * This program is distributed in the hope that it will be useful,
132++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
133++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
134++ * GNU Library General Public License for more details.
135++ *
136++ * You should have received a copy of the GNU General Public License
137++ * along with this program; if not, write to the Free Software
138++ * Foundation, Inc., 51 Franklin Street, Fifth Floor Boston, MA 02110-1301, USA
139++ */
140++
141++#ifndef _UI_UNITY_H
142++#define _UI_UNITY_H
143++
144++#ifdef HAVE_CONFIG_H
145++ #include <config.h>
146++#endif
147++
148++void ui_unity_update ();
149++void ui_unity_destroy ();
150++
151++#endif /* _UI_UNITY_H */
152+Index: fix-for-bug-732848/configure.ac
153+===================================================================
154+--- fix-for-bug-732848.orig/configure.ac 2011-03-12 12:50:17.735382000 +0100
155++++ fix-for-bug-732848/configure.ac 2011-03-12 12:50:30.405905830 +0100
156+@@ -29,6 +29,7 @@
157+ AC_ARG_ENABLE(nm, AS_HELP_STRING([--disable-nm],[compile without NetworkManager support]),,enable_nm=yes)
158+ AC_ARG_ENABLE(libnotify, AS_HELP_STRING([--disable-libnotify],[don't compile the libnotify plugin]),,enable_libnotify=yes)
159+ AC_ARG_ENABLE(libindicate, AS_HELP_STRING([--disable-libindicate],[compile without libindicate support]),,enable_libindicate=yes)
160++AC_ARG_ENABLE(libunity, AS_HELP_STRING([--disable-libunity],[compile without libunity support]),,enable_libunity=yes)
161+ AC_ARG_ENABLE(lua, AS_HELP_STRING([--disable-lua],[don't compile with LUA scripting support]),,enable_lua=yes)
162+ dnl AC_ARG_ENABLE(avahi, AS_HELP_STRING([--disable-avahi],[don't compile with AVAHI support]),,enable_avahi=yes)
163+
164+@@ -119,6 +120,24 @@
165+
166+ AM_CONDITIONAL(WITH_LIBINDICATE, test "x$enable_libindicate" = "xyes")
167+
168++dnl *********
169++dnl libunity
170++dnl *********
171++
172++if test "x$enable_libunity" = "xyes"; then
173++ PKG_CHECK_MODULES([LIBUNITY], unity >= 3.4.2,enable_libunity=yes,enable_libunity=no)
174++ AC_SUBST(LIBUNITY_CFLAGS)
175++ AC_SUBST(LIBUNITY_LIBS)
176++else
177++ enable_libunity=no
178++fi
179++
180++if test "x$enable_libunity" = "xyes"; then
181++ AC_DEFINE(HAVE_LIBUNITY, 1, [Define if libunity support is enabled])
182++fi
183++
184++AM_CONDITIONAL(WITH_LIBUNITY, test "x$enable_libunity" = "xyes")
185++
186+ dnl *****
187+ dnl AVAHI
188+ dnl *****
189+@@ -260,6 +279,7 @@
190+ echo "Use DBUS........................ : $enable_dbus"
191+ echo "Use NetworkManager.............. : $enable_nm"
192+ echo "Use libindicate................. : $enable_libindicate"
193++echo "Use libunity.................... : $enable_libunity"
194+ dnl echo "AVAHI Support................... : $enable_avahi"
195+ echo
196+ eval eval echo Liferea will be installed in $bindir.
197+Index: fix-for-bug-732848/src/ui/liferea_shell.c
198+===================================================================
199+--- fix-for-bug-732848.orig/src/ui/liferea_shell.c 2011-03-12 12:50:17.735382000 +0100
200++++ fix-for-bug-732848/src/ui/liferea_shell.c 2011-03-12 12:50:30.409905830 +0100
201+@@ -1333,6 +1333,7 @@
202+ ui_feedlist_select (NULL);
203+ liferea_shell_save_position ();
204+ ui_indicator_destroy ();
205++ ui_unity_destroy ();
206+ ui_tray_enable (FALSE);
207+ notification_enable (FALSE);
208+ g_object_unref (shell->priv->tabs);
209
210=== renamed file 'debian/patches/libunity.patch' => 'debian/patches/libunity.patch.moved'

Subscribers

People subscribed via source and target branches